Re: Request Review: JDK-8213043: Add internal Unsafe xxxObject methods as jsr166 is broken

2018-10-26 Thread Mandy Chung
Great!  I have pushed this changeset. Mandy On 10/26/18 2:09 PM, Martin Buchholz wrote: Thanks for doing this - I tested the patch and it'll work for us. On Fri, Oct 26, 2018 at 8:46 AM, Mandy Chung > wrote: jsr166 depends on the internal Unsafe xxxObject m

Re: Request Review: JDK-8213043: Add internal Unsafe xxxObject methods as jsr166 is broken

2018-10-26 Thread Martin Buchholz
Thanks for doing this - I tested the patch and it'll work for us. On Fri, Oct 26, 2018 at 8:46 AM, Mandy Chung wrote: > jsr166 depends on the internal Unsafe xxxObject methods and is currently > broken. Since the rename is motivated by Valhalla, we agree to keep the > internal Unsafe xxxObject m

Re: Request Review: JDK-8213043: Add internal Unsafe xxxObject methods as jsr166 is broken

2018-10-26 Thread Alan Bateman
On 26/10/2018 16:46, Mandy Chung wrote: jsr166 depends on the internal Unsafe xxxObject methods and is currently broken. Since the rename is motivated by Valhalla, we agree to keep the internal Unsafe xxxObject methods as deprecated in the jdk repo. Webrev: http://cr.openjdk.java.net/~mchung/

Request Review: JDK-8213043: Add internal Unsafe xxxObject methods as jsr166 is broken

2018-10-26 Thread Mandy Chung
jsr166 depends on the internal Unsafe xxxObject methods and is currently broken. Since the rename is motivated by Valhalla, we agree to keep the internal Unsafe xxxObject methods as deprecated in the jdk repo. Webrev: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213043/webrev.00 Mandy