Re: Request for review: 8007454 Wrong parameters in Win32 native code.

2013-02-18 Thread Alan Bateman
On 18/02/2013 15:16, Alexey Utkin wrote: : Hmm... That was my mistake. HANDLE_FLAG_PROTECT_FROM_CLOSE bit has to be removed from mask. I mixed the variable names and did not understand clearly the handles life circle. My tests with redirected, direct and terminated input/output modes prove th

Re: Request for review: 8007454 Wrong parameters in Win32 native code.

2013-02-18 Thread Alexey Utkin
On 04.02.2013 18:25, Alan Bateman wrote: On 04/02/2013 12:28, Alexey Utkin wrote: Hi, Please review the fix. Bug description: http://bugs.sun.com/view_bug.do?bug_id=8007454 https://jbs.oracle.com/bugs/browse/JDK-8007454 The suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs

Re: Request for review: 8007454 Wrong parameters in Win32 native code.

2013-02-04 Thread Alan Bateman
On 04/02/2013 12:28, Alexey Utkin wrote: Hi, Please review the fix. Bug description: http://bugs.sun.com/view_bug.do?bug_id=8007454 https://jbs.oracle.com/bugs/browse/JDK-8007454 The suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8007454/webrev.01/ Summary: Old vers

Request for review: 8007454 Wrong parameters in Win32 native code.

2013-02-04 Thread Alexey Utkin
Hi, Please review the fix. Bug description: http://bugs.sun.com/view_bug.do?bug_id=8007454 https://jbs.oracle.com/bugs/browse/JDK-8007454 The suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8007454/webrev.01/ Summary: Old version of code for the [Java_java_lang_Proces