Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-05-06 Thread Florian Weimer
On 03/08/2014 12:30 AM, Mandy Chung wrote: On 3/7/14 2:20 PM, Sergey Bylokhov wrote: But after this fix: size of class files are increased, instead of usage of one or two classes we get 50 new lambdas, and of course this horrible cast. new GetPropertyAction(user.home)); vs

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Chris Hegarty
This looks good to me Mandy. Reviewed. -Chris. On 6 Mar 2014, at 21:10, Mandy Chung mandy.ch...@oracle.com wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/ This patch converts the use of sun.security.action.GetPropertyAction tolambda

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Alan Bateman
On 06/03/2014 21:10, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/ This patch converts the use of sun.security.action.GetPropertyAction tolambda (PrivilegedActionString) () - System.getProperty(key) Similarly for GetIntegerAction and

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Peter Levart
On 03/07/2014 12:31 PM, Alan Bateman wrote: On 06/03/2014 21:10, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/ This patch converts the use of sun.security.action.GetPropertyAction tolambda (PrivilegedActionString) () -

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Alan Bateman
On 07/03/2014 11:39, Peter Levart wrote: Maybe, if PrivilegedAction interface could be retrofitted as follows: public interface PrivilegedExceptionActionT { T run() throws Exception; } public interface PrivilegedActionT extends PrivilegedExceptionActionT {

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Florian Weimer
On 03/07/2014 12:31 PM, Alan Bateman wrote: This looks good to me as it reduces the number of inner classes, I think we had sun.security.action.GetPropertyAction for exactly this purpose. Consequently, the proposed change actually *increases* class size: -rw-rw-r--. 1 fweimer fweimer 6056

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Alan Bateman
On 07/03/2014 13:14, Florian Weimer wrote: I think we had sun.security.action.GetPropertyAction for exactly this purpose. Consequently, the proposed change actually *increases* class size: -rw-rw-r--. 1 fweimer fweimer 6056 Mar 7 14:00

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Sergey Bylokhov
On 3/7/14 3:31 PM, Alan Bateman wrote: On 06/03/2014 21:10, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/ This patch converts the use of sun.security.action.GetPropertyAction tolambda (PrivilegedActionString) () - System.getProperty(key)

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Sergey Bylokhov
Hi, Alan. Why we cannot move these classes to java.security.* package instead? On 3/7/14 6:36 PM, Alan Bateman wrote: On 07/03/2014 13:14, Florian Weimer wrote: I think we had sun.security.action.GetPropertyAction for exactly this purpose. Consequently, the proposed change actually

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Alan Bateman
On 07/03/2014 15:34, Sergey Bylokhov wrote: Hi, Alan. Why we cannot move these classes to java.security.* package instead? There's nothing to stop adding APIs in java.* but would need to consideration as to whether they hold their weight. It would be interesting to have some data on how many

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread Mandy Chung
On 3/7/14 7:03 AM, Sergey Bylokhov wrote: Is this absolutely necessary? Does it mean that Get**Actions are deprecated now? The question should be whether this dependency is absolutely necessary and it's not. Get**Action classes are simple convenient classes that you could either use lambda

Re: Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-07 Thread roger riggs
Hi, Lambda is deceptively lightweight. It seems like a straightforward operation but the real implementation is more costly than one might expect. There are other cases where the implementation doesn't match the appearance, for example, who pays any attention to the fact that String in

Review 8035808: Eliminate dependency to GetPropertyAction and other sun.security.action convenient classes

2014-03-06 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8035808/webrev.00/ This patch converts the use of sun.security.action.GetPropertyAction tolambda (PrivilegedActionString) () - System.getProperty(key) Similarly for GetIntegerAction and GetLongAction. The sun.security.action.*