Review JDK-8010837 - TEST_BUG: java/io/FileInputStream/LargeFileAvailable.java fails intermittently

2013-03-26 Thread Dan Xu
Hi All, In the old JVM function, os::available, it could return negative values because lseek() allows the file offset to be set beyond the end of a file. In the previous change of removing jvm functions, I wasn't aware of that and regardnegative values as invalid and return 0, which causes t

Re: Review JDK-8010837 - TEST_BUG: java/io/FileInputStream/LargeFileAvailable.java fails intermittently

2013-03-26 Thread Mandy Chung
Hi Dan, On 3/26/2013 12:29 PM, Dan Xu wrote: Hi All, In the old JVM function, os::available, it could return negative values because lseek() allows the file offset to be set beyond the end of a file. In the previous change of removing jvm functions, I wasn't aware of that and regard negative

Re: Review JDK-8010837 - TEST_BUG: java/io/FileInputStream/LargeFileAvailable.java fails intermittently

2013-03-30 Thread Alan Bateman
On 26/03/2013 19:29, Dan Xu wrote: Hi All, In the old JVM function, os::available, it could return negative values because lseek() allows the file offset to be set beyond the end of a file. In the previous change of removing jvm functions, I wasn't aware of that and regardnegative values as i

Re: Review JDK-8010837 - TEST_BUG: java/io/FileInputStream/LargeFileAvailable.java fails intermittently

2013-03-30 Thread Dan Xu
I see. So we will need clarify the spec and make corresponding changes. I think as long as we don't trigger exceptions and just return 0 will be backward-compatible, right? -Dan On 03/30/2013 10:23 AM, Alan Bateman wrote: On 26/03/2013 19:29, Dan Xu wrote: Hi All, In the old JVM function,

Re: Review JDK-8010837 - TEST_BUG: java/io/FileInputStream/LargeFileAvailable.java fails intermittently

2013-04-02 Thread Alan Bateman
On 30/03/2013 17:56, Dan Xu wrote: I see. So we will need clarify the spec and make corresponding changes. I think as long as we don't trigger exceptions and just return 0 will be backward-compatible, right? -Dan I've created 8011136 to track the issues. We need to be careful of course and w