Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-27 Thread Dan Xu
This change is to fix the java doc font issue for ByteArrayOutputStream class. In current javadoc, contents change to the wrong font starting from toString(String charsetName) in ByteArrayOutputStream.html, which can be viewed at http://docs.oracle.com/javase/7/docs/api/java/io/ByteArrayOutputS

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-27 Thread David Holmes
Hi Dan, On 28/08/2012 6:48 AM, Dan Xu wrote: This change is to fix the java doc font issue for ByteArrayOutputStream class. In current javadoc, contents change to the wrong font starting from toString(String charsetName) in ByteArrayOutputStream.html, which can be viewed at http://docs.oracle.co

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-28 Thread Alan Bateman
On 27/08/2012 21:48, Dan Xu wrote: This change is to fix the java doc font issue for ByteArrayOutputStream class. In current javadoc, contents change to the wrong font starting from toString(String charsetName) in ByteArrayOutputStream.html, which can be viewed at http://docs.oracle.com/javase

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-28 Thread Dan Xu
Hi David, Thank you for reviewing my changes. I tried using {@code } in my change, but it did not work correctly as the tag will be nested. And it will show "{@code charset}" in the generated java doc instead of "charset". And works fine in the nested situation. I also uploaded the generat

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-28 Thread Ulf Zibis
Am 28.08.2012 11:45, schrieb Alan Bateman: On 27/08/2012 21:48, Dan Xu wrote: This change is to fix the java doc font issue for ByteArrayOutputStream class. In current javadoc, contents change to the wrong font starting from toString(String charsetName) in ByteArrayOutputStream.html, which can

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-28 Thread Dan Xu
Thanks for your comments, Ulf. I looked at the definitions of @link and @linkplain again. And I find that this nested situation can be easily avoided by replacing @linkplain with @link as the following, {@link java.nio.charset.Charset charset} I will update my changes. -Dan On 08/28/

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-28 Thread Ulf Zibis
Thanks for your feedback Dan. But I still think, the link to the javadoc of a class should not be labelled by a variable name. So maybe use: 212 * Converts the buffer's contents into a string by decoding the bytes using 213 * the {@link java.nio.charset.Charset}, specified by it's n

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-28 Thread Dan Xu
I will update the change with your suggestion. Thanks! -Dan On 08/28/2012 04:52 PM, Ulf Zibis wrote: Thanks for your feedback Dan. But I still think, the link to the javadoc of a class should not be labelled by a variable name. So maybe use: 212 * Converts the buffer's contents into

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-29 Thread Dan Xu
Thanks for your comments. I have updated my fix and posted at, http://cr.openjdk.java.net/~dxu/7193710/webrev.01/. I think the effort to upgrade to use new tags is out of the scope of this fix and will be addressed against the whole JDK in one chunk later. -Dan On 08/28/2012 05:13 PM, Dan X

Re: Review Request: 7193710 ByteArrayOutputStream Javadoc contains unclosed element

2012-08-30 Thread Alan Bateman
On 29/08/2012 22:47, Dan Xu wrote: Thanks for your comments. I have updated my fix and posted at, http://cr.openjdk.java.net/~dxu/7193710/webrev.01/. I think the effort to upgrade to use new tags is out of the scope of this fix and will be addressed against the whole JDK in one chunk later.