Re: Review Request: JDK-8165563 ClassLoader::getSystemClassLoader will never be null

2016-09-08 Thread Mandy Chung
> On Sep 7, 2016, at 11:52 PM, Alan Bateman wrote: > > On 08/09/2016 03:53, David Holmes wrote: > >> Despite code to contrary, I don't think the system classloader has "ever" >> been allowed to be null. If it can't be constructed then the whole >> initialization process will fail with an exce

Re: Review Request: JDK-8165563 ClassLoader::getSystemClassLoader will never be null

2016-09-07 Thread Alan Bateman
On 08/09/2016 03:53, David Holmes wrote: Despite code to contrary, I don't think the system classloader has "ever" been allowed to be null. If it can't be constructed then the whole initialization process will fail with an exception. In the JDK then that's true, I think allowing it be null was

Re: Review Request: JDK-8165563 ClassLoader::getSystemClassLoader will never be null

2016-09-07 Thread David Holmes
Hi Mandy, On 8/09/2016 5:42 AM, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165563/webrev.00/ ClassLoader::getPlatformClassLoader [1] is added in JDK 9 that is parent or ancestor of the system class loader [1]. The system class loader will never be null. An

Re: Review Request: JDK-8165563 ClassLoader::getSystemClassLoader will never be null

2016-09-07 Thread Patrick Reinhart
Hi Mandy Found a tiny typo ony line 1453, that could also be fixed with this change: 1451 * @throws IOException 1452 * If I/O errors occur 1453 1454 * @since 1.2 1455 */ 1456 public static Enumeration getSystemResources(String name) -Patrick On 07.09.2016 21:

Re: Review Request: JDK-8165563 ClassLoader::getSystemClassLoader will never be null

2016-09-07 Thread Mandy Chung
> On Sep 7, 2016, at 2:02 PM, Paul Sandoz wrote: > > >> On 7 Sep 2016, at 12:42, Mandy Chung wrote: >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165563/webrev.00/ >> > > +1 > > Do we have any tests that can be cleaned up? If so log a separate issue for > that? I did

Re: Review Request: JDK-8165563 ClassLoader::getSystemClassLoader will never be null

2016-09-07 Thread Paul Sandoz
> On 7 Sep 2016, at 12:42, Mandy Chung wrote: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165563/webrev.00/ > +1 Do we have any tests that can be cleaned up? If so log a separate issue for that? Paul. > ClassLoader::getPlatformClassLoader [1] is added in JDK 9 that is p

Review Request: JDK-8165563 ClassLoader::getSystemClassLoader will never be null

2016-09-07 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165563/webrev.00/ ClassLoader::getPlatformClassLoader [1] is added in JDK 9 that is parent or ancestor of the system class loader [1]. The system class loader will never be null. Another relevant change in JDK 9 was that the system ini