Re: Review Request JDK-8152721: Java Web Start splash mechanism is not working in JDK9

2016-05-31 Thread Kumar Srinivasan
Hi Mandy, I am ok with the changes. Thanks Kumar On 31/05/2016 03:59, Mandy Chung wrote: SelectVersion is called for launching any application. It processes -splash option separately from the launcher argument processing. To hit this bug, it will need to launch with the new module-syste

Re: Review Request JDK-8152721: Java Web Start splash mechanism is not working in JDK9

2016-05-30 Thread Alan Bateman
On 31/05/2016 03:59, Mandy Chung wrote: SelectVersion is called for launching any application. It processes -splash option separately from the launcher argument processing. To hit this bug, it will need to launch with the new module-system option together with -splash. I have verified wit

Re: Review Request JDK-8152721: Java Web Start splash mechanism is not working in JDK9

2016-05-30 Thread Mandy Chung
> On May 27, 2016, at 9:54 PM, Alan Bateman wrote: > > On 28/05/2016 05:29, Mandy Chung wrote: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152721/webrev.00/ >> >> The launcher does not handle the new options with whitespace separated >> arguments properly. This patch applies that cons

Re: Review Request JDK-8152721: Java Web Start splash mechanism is not working in JDK9

2016-05-27 Thread Alan Bateman
On 28/05/2016 05:29, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152721/webrev.00/ The launcher does not handle the new options with whitespace separated arguments properly. This patch applies that consistently in java.c I leave arg.c as is that Kumar/Henry can consid

Review Request JDK-8152721: Java Web Start splash mechanism is not working in JDK9

2016-05-27 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8152721/webrev.00/ The launcher does not handle the new options with whitespace separated arguments properly. This patch applies that consistently in java.c I leave arg.c as is that Kumar/Henry can consider cleanup in the future. Mandy