Re: Review Request JDK-8218461: test/jdk/java/lang/invoke/VarHandles should be generated rather than manually edited

looks good to me, Vicente On 2/6/19 3:13 PM, Mandy Chung wrote: This patch fixes up X-VarHandleTest* template files that are used to generate VarHandles tests.  Since VarHandle::equals and VarHandle::hashCode methods are no longer implemented [1], I rename the testEqualsAndHashCode method to

Re: Review Request JDK-8218461: test/jdk/java/lang/invoke/VarHandles should be generated rather than manually edited

On 2/6/19 12:22 PM, Brian Burkhalter wrote: Hi Mandy, I verified that running the script generates the same test files which are checked in to the repo, as it should be. Thanks for verifying. The tests shown in the webrev are generated by the script, not manually edited. Someone else

Re: Review Request JDK-8218461: test/jdk/java/lang/invoke/VarHandles should be generated rather than manually edited

> On Feb 6, 2019, at 12:44 PM, Mandy Chung wrote: > >> I verified that running the script generates the same test files which are >> checked in to the repo, as it should be. > > Thanks for verifying. The tests shown in the webrev are generated > by the script, not manually edited. Right,

Re: Review Request JDK-8218461: test/jdk/java/lang/invoke/VarHandles should be generated rather than manually edited

Hi Mandy, I verified that running the script generates the same test files which are checked in to the repo, as it should be. Someone else should review the actual test template content however. Thanks, Brian > On Feb 6, 2019, at 12:13 PM, Mandy Chung wrote: > > This patch fixes up

Review Request JDK-8218461: test/jdk/java/lang/invoke/VarHandles should be generated rather than manually edited

This patch fixes up X-VarHandleTest* template files that are used to generate VarHandles tests. Since VarHandle::equals and VarHandle::hashCode methods are no longer implemented [1], I rename the testEqualsAndHashCode method to testEquals and further clean up the test case. Webrev: