Alan, David,
Thanks for the review. Comments inlined below.
Alan Bateman wrote:
Minor nit but I assume you can initialize perf as:
private static final Perf perf =
AccessController.doPrivileged(new Perf.GetPerfAction());
Fixed.
David Holmes wrote:
Just to add 2c to Alan's method namin
Just to add 2c to Alan's method naming comments:
Alan Bateman said the following on 09/13/09 18:07:
Method naming is hard (and often subjective) but there are updates like
this:
PerfCounter.getParentDelegationTime.inc(t1 - t0);
which might be easier to read as:
PerfCounter.getParentDelegation
Mandy Chung wrote:
Alan, David, Remi, Iris,
Thanks for the review and the revised webrev at:
http://cr.openjdk.java.net/~mchung/6878481/webrev.01/
I incorporate the comments you have and minimize the number of
System.nanoTime() calls and also remove the number of opened jars perf
counters
Alan, David, Remi, Iris,
Thanks for the review and the revised webrev at:
http://cr.openjdk.java.net/~mchung/6878481/webrev.01/
I incorporate the comments you have and minimize the number of
System.nanoTime() calls and also remove the number of opened jars perf
counters. Please let me kno
David Holmes - Sun Microsystems wrote:
Hi Mandy,
Mandy Chung said the following on 09/03/09 05:25:
This is related to 6857194: Add hotspot new perf counters to aid
class loading performance measurement.
It's useful to add performance counters in the library code so that
perf data from the JD
Alan Bateman wrote:
Mandy Chung wrote:
This is related to 6857194: Add hotspot new perf counters to aid
class loading performance measurement.
It's useful to add performance counters in the library code so that
perf data from the JDK and VM can be collected and output in a
unified way (writt
2009/9/3 Mandy Chung :
> Alan Bateman wrote:
>>
>> Andrew John Hughes wrote:
>>>
>>> :
>>> The use of synchronized at present seems flawed as only the set
>>> methods are protected and not the get. So lb.get could be called
>>> while in an lb.put call. I don't see the reason for using a
>>> LongB
Alan Bateman wrote:
Andrew John Hughes wrote:
:
The use of synchronized at present seems flawed as only the set
methods are protected and not the get. So lb.get could be called
while in an lb.put call. I don't see the reason for using a
LongBuffer either, as only index 0 is ever used. Why not
Andrew John Hughes wrote:
:
The use of synchronized at present seems flawed as only the set
methods are protected and not the get. So lb.get could be called
while in an lb.put call. I don't see the reason for using a
LongBuffer either, as only index 0 is ever used. Why not use an
AtomicLong?
2009/9/3 Rémi Forax :
> Le 03/09/2009 10:54, Alan Bateman a écrit :
>>
>> Mandy Chung wrote:
>>>
>>> This is related to 6857194: Add hotspot new perf counters to aid class
>>> loading performance measurement.
>>>
>>> It's useful to add performance counters in the library code so that perf
>>> data
Le 03/09/2009 11:56, Alan Bateman a écrit :
Rémi Forax wrote:
:
Hi Alan,
Classloading is now done in parallele, zip and jar can be loaded by
different threads.
"for the synchronization there are places where both a counter and an
elapsed time are updated"
=> the problem is that these synchro
Rémi Forax wrote:
:
Hi Alan,
Classloading is now done in parallele, zip and jar can be loaded by
different threads.
"for the synchronization there are places where both a counter and an
elapsed time are updated"
=> the problem is that these synchronisations are done on two
different monitors
Le 03/09/2009 10:54, Alan Bateman a écrit :
Mandy Chung wrote:
This is related to 6857194: Add hotspot new perf counters to aid
class loading performance measurement.
It's useful to add performance counters in the library code so that
perf data from the JDK and VM can be collected and output
Mandy Chung wrote:
This is related to 6857194: Add hotspot new perf counters to aid class
loading performance measurement.
It's useful to add performance counters in the library code so that
perf data from the JDK and VM can be collected and output in a unified
way (written in the jvmstat sha
Hi Mandy,
Mandy Chung said the following on 09/03/09 05:25:
This is related to 6857194: Add hotspot new perf counters to aid class
loading performance measurement.
It's useful to add performance counters in the library code so that perf
data from the JDK and VM can be collected and output in
Le 03/09/2009 01:04, ir...@alum.mit.edu a écrit :
Hi, Mandy.
This is related to 6857194: Add hotspot new perf counters to aid class
loading performance measurement.
[ ... ]
Webrev:
http://cr.openjdk.java.net/~mchung/6878481/webrev.00/
Looks good.
iris
In Per
Hi, Mandy.
> This is related to 6857194: Add hotspot new perf counters to aid class
> loading performance measurement.
[ ... ]
> Webrev:
> http://cr.openjdk.java.net/~mchung/6878481/webrev.00/
Looks good.
iris
This is related to 6857194: Add hotspot new perf counters to aid class
loading performance measurement.
It's useful to add performance counters in the library code so that perf
data from the JDK and VM can be collected and output in a unified way
(written in the jvmstat shared memory buffer).
18 matches
Mail list logo
