looks fine.
-sherman
On 10/4/13 7:45 AM, roger riggs wrote:
The webrev has been updated to:
- In the until methods, add exclusive to the descriptions in the
@param tags in addition to the parameter name
- Optimize the use of requireNonNull so it appears only in the paths
for instanceof ==
(1) until(Temporal endExclusive, TEmporalUnit unit)
- Shouldn't we invoke requireNonNull() for unit before invoking
unit.between(...)?
(2) It appears we started to use endExclusive in until() methods, while the
param
has been renamed to be exclusive explicitly, personally I prefer
Please review these changes from the Threeten project for integration
into jdk-tl.
http://cr.openjdk.java.net/~rriggs/webrev-period-until-8023762-807-834-835/
8023762: Add ChronoPeriod interface and bind period to Chronology
Summary: Make Period ISO-only, adding a Chronology-specific period
