Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-26 Thread Alan Bateman
On 26/11/2012 10:38, Alexey Utkin wrote: I need the second reviewer. -uta One reviewer is fine. -Alan

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-26 Thread Alexey Utkin
I need the second reviewer. -uta On 23.11.2012 15:57, Alan Bateman wrote: On 23/11/2012 11:40, Alexey Utkin wrote: I mean: # jdk_io -# 7162111 - these tests need to be updated to run headless -java/io/Serializable/resolveClass/deserializeButton/run.sh macosx-all -java/io/Serializable/se

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alan Bateman
On 23/11/2012 11:40, Alexey Utkin wrote: I mean: # jdk_io -# 7162111 - these tests need to be updated to run headless -java/io/Serializable/resolveClass/deserializeButton/run.sh macosx-all -java/io/Serializable/serialver/classpath/run.sh macosx-all -java/io/Serializable/ser

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alexey Utkin
On 23.11.2012 15:24, Alan Bateman wrote: On 23/11/2012 11:22, Alexey Utkin wrote: On 23.11.2012 14:58, Alan Bateman wrote: On 23/11/2012 10:40, Alexey Utkin wrote: The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alan Bateman
On 23/11/2012 11:22, Alexey Utkin wrote: On 23.11.2012 14:58, Alan Bateman wrote: On 23/11/2012 10:40, Alexey Utkin wrote: The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account (changes in TraceJFrame.java): http://cr.o

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alexey Utkin
On 23.11.2012 14:58, Alan Bateman wrote: On 23/11/2012 10:40, Alexey Utkin wrote: The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account (changes in TraceJFrame.java): http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alan Bateman
On 23/11/2012 10:40, Alexey Utkin wrote: The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account (changes in TraceJFrame.java): http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.03/ This looks good to me.

Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-23 Thread Alexey Utkin
The sub-task JDK-8003898 (X11 toolkit can be chosen as the default toolkit) was resolved. New version that takes it into account (changes in TraceJFrame.java): http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.03/ On 22.11.2012 13:57, Alan Bateman wrote: On 22/11/2012 07:38

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part)

2012-11-22 Thread Alan Bateman
On 22/11/2012 07:38, Alexey Utkin wrote: Bug description: https://jbs.oracle.com/bugs/browse/JDK-7162111 Here is the suggested fix that contains the changes in JFrameCreateTime.java: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.02 The changes to test/java/io/Serializable

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part)

2012-11-22 Thread Alexey Utkin
On 22.11.2012 12:41, Alan Bateman wrote: On 22/11/2012 07:38, Alexey Utkin wrote: : I take in account the AWT problem on Mac OS: in ssh session due to compatibility reason AWT switches to X11 toolkit if DISPLAY variable is defined. But Mac OS implementation of X11 toolkit has a deadlock/lin

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part)

2012-11-22 Thread Alan Bateman
On 22/11/2012 07:38, Alexey Utkin wrote: : I take in account the AWT problem on Mac OS: in ssh session due to compatibility reason AWT switches to X11 toolkit if DISPLAY variable is defined. But Mac OS implementation of X11 toolkit has a deadlock/linkage problems. In JDK8 the X11 toolkit sup

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part)

2012-11-21 Thread Alexey Utkin
Bug description: https://jbs.oracle.com/bugs/browse/JDK-7162111 Here is the suggested fix that contains the changes in JFrameCreateTime.java: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.02 JPRT results: http://prt-web.us.oracle.com//archive/2012/11/2012-11-2

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part)

2012-11-19 Thread Alan Bateman
On 19/11/2012 14:54, Alexey Utkin wrote: Here is the updated version: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.01/ In Foo.java then I assume Vector would be better. I don't think you can remove the javax/script/** tests from the exclude list without adding -Djava

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part)

2012-11-19 Thread Alexey Utkin
Here is the updated version: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/webrev.01/ On 19.11.2012 16:26, Alan Bateman wrote: On 19/11/2012 09:57, Alexey Utkin wrote: Bug description: https://jbs.oracle.com/bugs/browse/JDK-7162111 Here is the suggested fix: http://cr

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part)

2012-11-19 Thread Alan Bateman
On 19/11/2012 09:57, Alexey Utkin wrote: Bug description: https://jbs.oracle.com/bugs/browse/JDK-7162111 Here is the suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/ Thanks for taking this one on. The change to JFrameCreateTime.java looks fine to me. For tes

Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part)

2012-11-19 Thread Alexey Utkin
Bug description: https://jbs.oracle.com/bugs/browse/JDK-7162111 Here is the suggested fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7162111/ Summary: Tests that are not changed and pass successfully (all tests run for jdk8): ---

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx]

2012-11-15 Thread Alan Bateman
On 15/11/2012 15:08, Alexey Utkin wrote: : Questions: 1] That have I do with tests marked as "Easy to fix, but it cuts off test coverage"? 2] Should I remove/move the manual tests and tests that essentially depends from AWT or Swing? It seems that the switch "-Djava.awt.headless=true" is use

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx]

2012-11-15 Thread Jim Gish
Alexey -- where's the webrev? This message just appeared in core-libs-dev, but I don't see the previous message(s) it appears to be a follow-up to. Thanks, Jim On 11/15/2012 10:08 AM, Alexey Utkin wrote: Let's move forward step by step and be very accurate. There are ~35 CoreLib tests with

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx]

2012-11-15 Thread Alexey Utkin
Let's move forward step by step and be very accurate. There are ~35 CoreLib tests with AWT/Swing. Here they are with short annotation (sub-question: is [closed/com/sun/jmx] a part of CoreLib? It is not in your list.): *closed/com/sun/jmx/snmp/B7159066.java : * test for AppContext - Useless in a