Re: Review request 7190657 Modify getDriver() to call Thread.currentThread().getContextClassLoader();

2012-08-12 Thread David Holmes
Lance, On 11/08/2012 3:19 AM, Lance Andersen - Oracle wrote: Looking for a reviewer for the following change: - add a call to Thread.currentThread().getContextClassLoader() to DriverManager.getDriver() - Remove the synchronized block for the same call in getConnection() What is the context

Re: Review request 7190657 Modify getDriver() to call Thread.currentThread().getContextClassLoader();

2012-08-11 Thread Lance Andersen - Oracle
For completeness, they could be added and I guess I can do it as part of this particular change. I would probably move the call to DriverManager.getCallerClassLoader() to avoid the duplication of the if block. Best Lance On Aug 10, 2012, at 5:02 PM, David Schlosnagle wrote: > Lance, > > Ther

Re: Review request 7190657 Modify getDriver() to call Thread.currentThread().getContextClassLoader();

2012-08-10 Thread David Schlosnagle
Lance, There are a couple of other uses of DriverManager.getCallerClassLoader() that do no fall back to Thread.currentThread().getContextClassLoader() if the caller class loader is null (bootstrap loader). Should these be updated as well? >From >http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/

Review request 7190657 Modify getDriver() to call Thread.currentThread().getContextClassLoader();

2012-08-10 Thread Lance Andersen - Oracle
Looking for a reviewer for the following change: - add a call to Thread.currentThread().getContextClassLoader() to DriverManager.getDriver() - Remove the synchronized block for the same call in getConnection() Thank you. Best Lance localhost:sql lanceandersen$ hg diff DriverManager.java diff