Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-13 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 12 Nov 2013, at 20:29, Mandy Chung wrote: > This is a simple code deletion in sun.misc.JavaAWTAccess and its > implementation class: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ > > This patch removes the methods from sun.mi

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-13 Thread Daniel Fuchs
Hi Mandy, looks good! -- daniel On 11/12/13 8:29 PM, Mandy Chung wrote: This is a simple code deletion in sun.misc.JavaAWTAccess and its implementation class: Webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ This patch removes the methods from sun.misc.JavaAWTAccess

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-13 Thread Artem Ananiev
Hi, Mandy, the fix looks fine to me. Other people might want to ask why these methods are no longer used and can be safely removed, so be prepared to the questions :) Thanks, Artem On 11/13/2013 2:15 AM, Mandy Chung wrote: Adding awt-dev for the review. Mandy On 11/12/2013 11:29 AM, Mand

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-12 Thread Mandy Chung
Adding awt-dev for the review. Mandy On 11/12/2013 11:29 AM, Mandy Chung wrote: This is a simple code deletion in sun.misc.JavaAWTAccess and its implementation class: Webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ This patch removes the methods from sun.misc.JavaA

Re: Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-12 Thread Lance Andersen - Oracle
+1 On Nov 12, 2013, at 2:29 PM, Mandy Chung wrote: > This is a simple code deletion in sun.misc.JavaAWTAccess and its > implementation class: > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ > > This patch removes the methods from sun.misc.JavaAWTAccess that are

Review request for 8028234: Remove unused methods in sun.misc.JavaAWTAccess

2013-11-12 Thread Mandy Chung
This is a simple code deletion in sun.misc.JavaAWTAccess and its implementation class: Webrev: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8028234/webrev.00/ This patch removes the methods from sun.misc.JavaAWTAccess that are no longer used. The only dependency remaining from core-libs to