Re: Review request for JDK-8051536: Convert JAXP function tests: javax.xml.parsers to jtreg(testng) tests

2014-12-02 Thread huizhe wang
I agree with Lance's suggestion on utilizing the @BeforeMethod methods to instantiate factories, or DocumentBuilder where there's no change in state on the DocumentBuilderFactory (that is, no set** in any of the tests, such as DocumentBuilderImpl01), or using DataProvider. However, if you do

Review request for JDK-8051536: Convert JAXP function tests: javax.xml.parsers to jtreg(testng) tests

2014-12-01 Thread Frank Yuan
Hi, Joe and All We are working on moving internal jaxp functional tests to open jdk repo. This is the parsers suite. Would you please review these test? Any comment will be appreciated. bug: https://bugs.openjdk.java.net/browse/JDK-8051536 webrev: