Re: Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

Hi Joe If you’re okay with the code; would you be my sponsor for this. We need move forward and push these tests into openjdk repo. Thank you so much Tristan > On Aug 29, 2014, at 11:21 AM, huizhe wang wrote: > > Hi Tristan, > > Looks good. I left notes in the bug's comment section as a record

Re: Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

Hi Tristan, Looks good. I left notes in the bug's comment section as a record and status of the original test development. Thanks, Joe On 8/29/2014 9:50 AM, Tristan Yan wrote: Hi Joe, Alan and others I took over Eric’s last work and did some refactor for his code. Please help to review the

Re: Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

Hi Joe, Alan and others I took over Eric’s last work and did some refactor for his code. Please help to review the code change again. webrev: http://cr.openjdk.java.net/~tyan/JDK-8051561/webrev.01/ bug: https://bugs.openjdk.java.net/brows

Re: Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

Hi Eric, This is a good start! The code looks much more cleaner than the previous tests, great work! 1. Base class I see that you picked a small set of tests from the Product group (a small surprise :-) since I thought you'd had the Auction-portal group). You probably already considere

Re: Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

Hi Eric, A few comments: - TestBase.java: 39: typo "Unexcepted" -> "Unexpected" - TestUtils.java: 32: Consider moving XML_DIR to TestBase.java, it seems similar to the other static final strings - TestBase.java: 57,66; Is the extra starting/ending output useful for TestNg Tests? T

Review request for JDK-8051561: Convert JAXP function tests: javax.xml.xpath.* to jtreg (testNG) tests

Hi Joe, alan and every one I'm working on jaxp functional test colocation which is traced by the bug JDK-8043091 . We have finished to convert a few suite and the jaxp/xpath tracked by bug JDK-8051561