Re: Review request for JDK-8156680: jdeps implementation refresh

2016-05-11 Thread Mandy Chung
> On May 11, 2016, at 10:39 AM, Daniel Fuchs wrote: > > Hi Mandy, > > I had a look at the first webrev. > > Code reorganization in some of the files makes it difficult > to follow what is going on. I will try to import > the changes in my local workspace tomorrow and play with > it a bit. Tha

Re: Review request for JDK-8156680: jdeps implementation refresh

2016-05-11 Thread Daniel Fuchs
On 11/05/16 02:12, Mandy Chung wrote: JDK-8153481: tools/jdeps/modules/GenModuleInfo.java and ModuleTest.java fails intermittently Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8153481/webrev.00/ Mandy second webrev above looks good. best regards, -- daniel

Re: Review request for JDK-8156680: jdeps implementation refresh

2016-05-11 Thread Daniel Fuchs
Hi Mandy, I had a look at the first webrev. Code reorganization in some of the files makes it difficult to follow what is going on. I will try to import the changes in my local workspace tomorrow and play with it a bit. I have two small comments so far: On 11/05/16 02:12, Mandy Chung wrote: J

Review request for JDK-8156680: jdeps implementation refresh

2016-05-10 Thread Mandy Chung
JDK-8156680: jdeps implementation refresh JDK-8153042: jdeps should continue to report JDK internal APIs that are removed/renamed in JDK 9 Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8156680/webrev.00/ This refactors the jdeps implementation that regression tests can be develop