Re: Selector cleanup

2008-01-25 Thread Matthias Ernst
On Jan 25, 2008 2:59 PM, Alan Bateman <[EMAIL PROTECTED]> wrote: > > I not agree, reading the code, idle set is used when setInterestOps(0) > > is called. > > I'm not sure that case is not frequent. > I've only observed it on a few occasions. Hmm? I thought a boilerplate selection loop looks mor

Re: Selector cleanup

2008-01-25 Thread Alan Bateman
Rémi Forax wrote: : We have observed that a selector doesn't work well with a lot of keys. Is this just Windows? I ask because the Selector implementations on Solaris and Linux scale very well and there are many people using it on servers that are handling thousands of concurrent connections.

Re: Selector cleanup

2008-01-25 Thread Rémi Forax
Alan Bateman a écrit : Rémi Forax wrote: ok, no valueOf(), i'm not an expert in Windows API. But are you agree that class FdMap is not necessary. I agree and I assume you will replace it with an embedded Map. I suspect it will be hard to see a difference (with the server VM anyway). i'am prett

Re: Selector cleanup

2008-01-24 Thread Alan Bateman
Rémi Forax wrote: ok, no valueOf(), i'm not an expert in Windows API. But are you agree that class FdMap is not necessary. I agree and I assume you will replace it with an embedded Map. I suspect it will be hard to see a difference (with the server VM anyway). yes, very hard to mesure until y

Re: Selector cleanup

2008-01-24 Thread Rémi Forax
Alan Bateman a écrit : Rémi Forax wrote: Hi all, i currently develop a small web server and I think codes related to selectors can be improved just by changing some small pieces of code. To be crystal clear, i don't want to re-implement all selector related stuffs but just patch some parts o

Re: Selector cleanup

2008-01-24 Thread Alan Bateman
Rémi Forax wrote: Hi all, i currently develop a small web server and I think codes related to selectors can be improved just by changing some small pieces of code. To be crystal clear, i don't want to re-implement all selector related stuffs but just patch some parts of the actual code. There

Selector cleanup

2008-01-24 Thread Rémi Forax
Hi all, i currently develop a small web server and I think codes related to selectors can be improved just by changing some small pieces of code. To be crystal clear, i don't want to re-implement all selector related stuffs but just patch some parts of the actual code. There are some allocatio