s
URL:
https://git.openjdk.java.net/jdk/commit/3d9dc8f824abf597d9b28f456cfeb5af927221b8
Stats: 539 lines in 4 files changed: 147 ins; 388 del; 4 mod
8273430: Suspicious duplicate condition in
java.util.regex.Grapheme#isExcludedSpacingMark
Reviewed-by: naoto
-
PR:
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote:
>> The duplicate condition in this chain of expressions needs to be shrunk to
>> drop a couple of character that are not excluded spacing marks.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote:
>> The duplicate condition in this chain of expressions needs to be shrunk to
>> drop a couple of character that are not excluded spacing marks.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the
> The duplicate condition in this chain of expressions needs to be shrunk to
> drop a couple of character that are not excluded spacing marks.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Refactoring test to whitebox
-
On Wed, 8 Sep 2021 20:24:31 GMT, Ian Graves wrote:
> The duplicate condition in this chain of expressions needs to be shrunk to
> drop a couple of character that are not excluded spacing marks.
The copyright year in Grapheme.java should be 2021, otherwise looks good.
-
Marked as
The duplicate condition in this chain of expressions needs to be shrunk to drop
a couple of character that are not excluded spacing marks.
-
Commit messages:
- 8273430: Suspicious duplicate condition in
java.util.regex.Grapheme#isExcludedSpacingMark
Changes: https
It does look incorrect. I will take a look.
Naoto
On 9/6/21 12:16 AM, Andrey Turbanov wrote:
Hello.
I found suspicious condition in the method
java.util.regex.Grapheme#isExcludedSpacingMark
It's detected by IntelliJ IDEA inspection 'Condition is covered by
further condition'
Bug submitted on your behalf.
https://bugs.openjdk.java.net/browse/JDK-8273430
> On Sep 6, 2021, at 4:16 AM, Andrey Turbanov wrote:
>
> Hello.
> I found suspicious condition in the method
> java.util.regex.Grapheme#isExcludedSpacingMark
> It's detected by IntelliJ IDEA inspection 'Condition is
Hello.
I found suspicious condition in the method
java.util.regex.Grapheme#isExcludedSpacingMark
It's detected by IntelliJ IDEA inspection 'Condition is covered by
further condition'
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/regex/Grapheme.java#L157
```
