Re[2]: The final optimized version of Dual-Pivot Quicksort (ver.19.1)

2019-08-01 Thread Vladimir Yaroslavskiy
Hi Brent, see my comments inline: >Четверг, 1 августа 2019, 9:23 +03:00 от Laurent Bourgès >: > >Hi Brent, > >Le jeu. 1 août 2019 à 02:32, Brent Christian < brent.christ...@oracle.com > a >écrit : >>Thanks, Laurent.  I can sponsor this fix, get a RFR thread going for >>JDK-8226297, keep

Re: The final optimized version of Dual-Pivot Quicksort (ver.19.1)

2019-08-01 Thread Laurent Bourgès
Hi Brent, Le jeu. 1 août 2019 à 02:32, Brent Christian a écrit : > Thanks, Laurent. I can sponsor this fix, get a RFR thread going for > JDK-8226297, keep webrevs updated as the review progresses, etc. > Excellent, I will let you and Vladimir work on this review. FYI I have implemented DPQS

Re: The final optimized version of Dual-Pivot Quicksort (ver.19.1)

2019-07-31 Thread Brent Christian
Thanks, Laurent. I can sponsor this fix, get a RFR thread going for JDK-8226297, keep webrevs updated as the review progresses, etc. However I've uncovered an issue with the fix that should be resolved before proceeding. Specifically, the new Arrays.COMMON_PARALLELISM static constant causes

Re: The final optimized version of Dual-Pivot Quicksort (ver.19.1)

2019-07-26 Thread Laurent Bourgès
Hi all, I updated the DPQS patch thanks to latest release from Vladimir ([image: Pièces jointes]2019.07.25): http://cr.openjdk.java.net/~lbourges/dpqs/dpqs-8226297/dpqs-8226297.1/ " Updated version of Arrays and DualPivotQuicksort files, the summary of changes: 1. Corrected minimal threshold

Re: The final optimized version of Dual-Pivot Quicksort (ver.19.1)

2019-07-17 Thread Laurent Bourgès
> >> Is the webrev incomplete? It only contains the changes for >> DualPivotQuicksort.java, and not for Arrays.java, etc. >> >> Thanks, >> -Brent >> >> On 6/18/19 2:37 PM, Vladimir Yaroslavskiy wrote: >> > Hi team, >> > >> > Pleas

Re: The final optimized version of Dual-Pivot Quicksort (ver.19.1)

2019-07-12 Thread Laurent Bourgès
ys.java, etc. > > Thanks, > -Brent > > On 6/18/19 2:37 PM, Vladimir Yaroslavskiy wrote: > > Hi team, > > > > Please review the final optimized version of Dual-Pivot Quicksort > (ver.19.1), > > see http://cr.openjdk.java.net/~alanb/8226297/0/webrev > >

Re: The final optimized version of Dual-Pivot Quicksort (ver.19.1)

2019-07-09 Thread Brent Christian
Hi, Is the webrev incomplete? It only contains the changes for DualPivotQuicksort.java, and not for Arrays.java, etc. Thanks, -Brent On 6/18/19 2:37 PM, Vladimir Yaroslavskiy wrote: Hi team, Please review the final optimized version of Dual-Pivot Quicksort (ver.19.1), see http

The final optimized version of Dual-Pivot Quicksort (ver.19.1)

2019-06-18 Thread Vladimir Yaroslavskiy
Hi team, Please review the final optimized version of Dual-Pivot Quicksort (ver.19.1), see http://cr.openjdk.java.net/~alanb/8226297/0/webrev (link to Jira task https://bugs.openjdk.java.net/browse/JDK-8226297) The new version was published here more than one year ago (on Jan 19, 2018). Since