Hello.
During my review of the JDK codebase, I found that launcher's 'main.c'
still has code, which included only with Visual Studio 2005 and 2008.

https://github.com/openjdk/jdk/blob/3f923b82c31325504430b50dee262fd460004e7b/src/java.base/share/native/launcher/main.c#L38

#if _MSC_VER > 1400 && _MSC_VER < 1600

/*
* When building for Microsoft Windows, main has a dependency on msvcr??.dll.
*
* When using Visual Studio 2005 or 2008, that must be recorded in
#ifdef _MSC_VER


I wonder, shouldn't such code be removed, when JDK drops support of
old compiler/toolchains?
As I know, JDK now supports only recent versions of Visual Studio. (2017+).
Or this file should be compilable with older versions as well?

Andrey Turbanov

Reply via email to