Re: Warning Fixes from LJC Hack Session

2012-02-17 Thread Michael Barker
Hi Stuart, Thank you for the reviewing the patches. I forgot about the Contributed-by header, sorry about that. That's one I'll put on the list to make sure I have sorted next time. I've split the contributors up according to the two patches supplied. See below: AWT, beans & printing: Contr

Re: Warning Fixes from LJC Hack Session

2012-02-13 Thread Stuart Marks
Great, I've pushed in the remaining changes: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/445ada5e6b4a I hope these patches are providing value for the OpenJDK team as we plan to do more. I know that there is a bit of a cost for you guys in terms of reviewing and merging. I'm starting to get a

Re: Warning Fixes from LJC Hack Session

2012-02-10 Thread Chris Hegarty
On 02/10/12 03:58 AM, Michael Barker wrote: Hi Stuart, Thank you for the reviewing the patches. I forgot about the Contributed-by header, sorry about that. That's one I'll put on the list to make sure I have sorted next time. I've split the contributors up according to the two patches supplie

Re: Warning Fixes from LJC Hack Session

2012-02-09 Thread Weijun Wang
Just give me anything that includes the jars not found yet. I just want to extract the hash line and cert info from them to make sure they can be removed from trusted.libraries safely. Thanks Max On 02/10/2012 11:11 AM, Stuart Marks wrote: Hi Mike, I finally got back to this. These fixes lo

Re: Warning Fixes from LJC Hack Session

2012-02-09 Thread Stuart Marks
Hi Mike, I finally got back to this. These fixes look pretty good and knock off 100+ additional warnings! I've filed bug 7143230 [1] to track this. I took a look through the code and I took the liberty of fixing up a few very minor things: 1. Removed unnecessary casts to ZipEntry in JarVerifi

Re: Warning Fixes from LJC Hack Session

2012-02-08 Thread Michael Barker
> I see Rémi has suggested a slice & dice but I think that's a bit too much > work for the changes involved. Instead I would suggest a simple split, send > the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else to > core-libs-dev. Attached is the patch that contains "everthing els

Re: Warning Fixes from LJC Hack Session

2012-02-04 Thread Chris Hegarty
Thanks for this, looks great. Good to see JarVerifier getting some much needed TLC. -Chris. On 02/ 4/12 07:50 AM, Michael Barker wrote: I see Rémi has suggested a slice& dice but I think that's a bit too much work for the changes involved. Instead I would suggest a simple split, send the AWT