Looks good
>
> Original Message
> Subject: code review request : 8003147 port fix for BCEL bug 39695
> Date: Mon, 10 Dec 2012 15:25:54 +0900
> From: David Buck
> To: core-libs-dev@openjdk.java.net
>
> Hi!
>
> I would like to request a code
On 12/12/2012 8:37 PM, David Buck wrote:
Hi Joe!
Thank you for looking at this.
> You didn't apply the original Apache completely. Was the omission of
the
> change in toString() method intentional?
Yes, the improvement in toString() was not related to the issue and
seems to have been incl
Hi Joe!
Thank you for looking at this.
> You didn't apply the original Apache completely. Was the omission of the
> change in toString() method intentional?
Yes, the improvement in toString() was not related to the issue and
seems to have been included in the apache version of this fix on a wh
Hi David,
You didn't apply the original Apache completely. Was the omission of the
change in toString() method intentional?
I see that you've sent your test to Patrick. Have you run regression
test for this patch?
Thanks,
Joe
On 12/9/2012 10:25 PM, David Buck wrote:
Hi!
I would like to r
Hi!
I would like to request a code review of my JDK8 fix for the following
issue:
[ 8003147 : port fix for BCEL bug 39695 to our copy bundled as part of
jaxp ]
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003147
In addition to the fix that the BCEL project had for this issue, I
need
