Re: codereview request: 6639443/

Sherman, Martin, Why you don't commit this change to the repository ? Especially please add Character.isSurrogate(char ch) soon. I like to get rid of using the sun.nio.cs.Surrogate class in my changes. IMO, there only should remain Surrogate.Parser and Surrogate.Generator, if someone likes to

Re: codereview request: 6639443/

Sherman, another 2 cents: Please note, that 6798511 is more than duplicate of 6860431. 6860431 only cares about method isSurrogate(). -Ulf Am 14.07.2009 23:42, Xueming Shen schrieb: Ulf, Usually I should close the newly filed bug 6860431 as the dup of yours. But I have already used 6860431

Re: codereview request: 6639443/

Martin Buchholz wrote: On Tue, Jul 14, 2009 at 12:50, Xueming Shen > wrote: (2) a)return (int)(char) uc ==uc; is nice:-) but I would go with the "more easy to read" return uc < Surrogate.UCS4_MIN; if it were my code. Is there a b

Re: codereview request: 6639443/

Martin, no problem! See: http://mail.openjdk.java.net/pipermail/web-discuss/2009-March/66.html -Ulf Am 14.07.2009 23:36, Martin Buchholz schrieb: Sorry, Ulf. The bug duplication might have been avoided if the bug database was more searchable. I need a command named jbugs ... Mart

Re: codereview request: 6639443/

Sorry, Ulf. The bug duplication might have been avoided if the bug database was more searchable. I need a command named jbugs ... Martin On Tue, Jul 14, 2009 at 14:01, Ulf Zibis wrote: > Am 14.07.2009 21:50, Xueming Shen schrieb: > >> I included the core-libs-dev as you suggested. >> >> (

Re: codereview request: 6639443/

Am 14.07.2009 21:50, Xueming Shen schrieb: I included the core-libs-dev as you suggested. (3)6860431: Character.isSurrogate(char ch) has been filed on your behalf, as well as the CCC http://ccc.sfbay.sun.com/6860431. Masayoshi, would you please review the spec and add yourself as the reviewer

Re: codereview request: 6639443/

On Tue, Jul 14, 2009 at 12:50, Xueming Shen wrote: > > (2) > > a)return (int)(char) uc ==uc; > > is nice:-) but I would go with the "more easy to read" > > return uc < Surrogate.UCS4_MIN; > > if it were my code. Is there a big performance gain by doing that? > That's almost, but not ex

Re: codereview request: 6639443/

I included the core-libs-dev as you suggested. (1)The toCodePoint change looks good. (2) a)return (int)(char) uc ==uc; is nice:-) but I would go with the "more easy to read" return uc < Surrogate.UCS4_MIN; if it were my code. Is there a big performance gain by doing that? b)