+1, Reviewed
On 5/24/2017 11:59 AM, Brent Christian wrote:
Looks fine to me, Hamlin.
Thanks,
-Brent
On 5/24/17 2:18 AM, Hamlin Li wrote:
Hi Roger, Brent,
Thank you for reviewing, please check new webrev at :
http://cr.openjdk.java.net/~mli/8180732/webrev.01/
Thank you
-Hamlin
On 2017/5/24
Thank you for review Brent.
I still need a official reviewer to review the change.
Thank you
-Hamlin
On 2017/5/24 23:59, Brent Christian wrote:
Looks fine to me, Hamlin.
Thanks,
-Brent
On 5/24/17 2:18 AM, Hamlin Li wrote:
Hi Roger, Brent,
Thank you for reviewing, please check new webrev
Looks fine to me, Hamlin.
Thanks,
-Brent
On 5/24/17 2:18 AM, Hamlin Li wrote:
Hi Roger, Brent,
Thank you for reviewing, please check new webrev at :
http://cr.openjdk.java.net/~mli/8180732/webrev.01/
Thank you
-Hamlin
On 2017/5/24 1:05, Roger Riggs wrote:
Hi,
Security.java: 25-27: Style c
Hi Roger, Brent,
Thank you for reviewing, please check new webrev at :
http://cr.openjdk.java.net/~mli/8180732/webrev.01/
Thank you
-Hamlin
On 2017/5/24 1:05, Roger Riggs wrote:
Hi,
Security.java: 25-27: Style conventions call for " * " on every line
in comment blocks.
On 5/23/2017 12:5
Hi,
Security.java: 25-27: Style conventions call for " * " on every line in
comment blocks.
On 5/23/2017 12:53 PM, Brent Christian wrote:
Hi, Hamlin
That looks pretty good. A couple comments:
* If I'm not mistaken, main/othervm/policy=... is sufficient to enable
the default security manag
Hi, Hamlin
That looks pretty good. A couple comments:
* If I'm not mistaken, main/othervm/policy=... is sufficient to enable
the default security manager, and specifying "-Djava.security.manager"
is unnecessary.
* Please add 8180732 to the @bug tag
You will also need approval from a JDK 10
Would you please review the below patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8180732
webrev: http://cr.openjdk.java.net/~mli/8180732/webrev.00/
Thank you
-Hamlin
