Re: RFR(s) 8145139 clean up jdk_collections and jdk_concurrent test groups (was: question on jdk_collections group in jdk/test/TEST.groups)

2015-12-11 Thread Martin Buchholz
This is "fine", but jsr166 maintainers won't use it - we maintain our own list of tests to run. There's enough collection/concurrency overlap and too much testing ad-hoc-ery in existing jtreg tests. Eg. MOAT should be run for changes to any collection. If this is a test set you personally like,

RFR(s) 8145139 clean up jdk_collections and jdk_concurrent test groups (was: question on jdk_collections group in jdk/test/TEST.groups)

2015-12-10 Thread Stuart Marks
Bug: https://bugs.openjdk.java.net/browse/JDK-8145139 I've appended a patch below; please review. Thanks, s'marks # HG changeset patch # User smarks # Date 1449787050 28800 # Thu Dec 10 14:37:30 2015 -0800 # Node ID 5b630d0c118b115439672b29aff0d195132d4f96 # Parent 7f644a5d554a67457f3dd5

Re: question on jdk_collections group in jdk/test/TEST.groups

2015-12-10 Thread Stuart Marks
Hi Martin, Thanks for looking at this. I also heard offline from Mike Duigou that the current grouping was meant to be an intermediate step. He mentioned plans to break it into multiple sub-groups, but that didn't happen. But cleaning up the jdk_collections group seems sensible. In any case

Re: question on jdk_collections group in jdk/test/TEST.groups

2015-12-10 Thread Martin Buchholz
I don't know how jdk_collections was defined. I recommend fixing it as below. The distinction between "maintained by JSR-166" and other collections is useful when knowing who to contact and whether to make changes to particular source files (or defer to JSR-166). But it's not useful for knowing

question on jdk_collections group in jdk/test/TEST.groups

2015-12-09 Thread Stuart Marks
Hi, maybe somebody can fill me in on the history here. There's a nice test group called jdk_collections defined in jdk/test/TEST.groups. It runs the tests for the collections in java/util (but not java/util/concurrent) and it excludes all the stuff in java/util that isn't collections-related.