Re: review request: 8006505 additional updates for JSR 310

2013-02-06 Thread Lance Andersen - Oracle
On Feb 6, 2013, at 9:26 AM, Ulf Zibis wrote: > > Am 06.02.2013 13:15, schrieb Lance Andersen - Oracle: >> I am going to change the message from >> >> "readObject not implemented" >> >> to "method readObject(Class) not implemented" > > There is 1 % missing to be perfect: "method T readObject(

Re: review request: 8006505 additional updates for JSR 310

2013-02-06 Thread Ulf Zibis
Am 06.02.2013 13:15, schrieb Lance Andersen - Oracle: I am going to change the message from "readObject not implemented" to "method readObject(Class) not implemented" There is 1 % missing to be perfect: "method T readObject(Class type) not implemented" ;-) I was also thinking about this 10

Re: review request: 8006505 additional updates for JSR 310

2013-02-06 Thread Lance Andersen - Oracle
Thank you again for the feedback Ulf On Feb 5, 2013, at 7:22 PM, Ulf Zibis wrote: > Am 06.02.2013 00:54, schrieb Lance Andersen - Oracle: >> >> I can change that text and will do so before i put back. > > fine! I am going to change the message from "readObject not implemented" to "method read

Re: review request: 8006505 additional updates for JSR 310

2013-02-05 Thread Ulf Zibis
Am 06.02.2013 00:54, schrieb Lance Andersen - Oracle: I can change that text and will do so before i put back. fine! Have you observed internal review ID of 2426775? I have not seen this come through as of yet but will let you know when I do. It was from 16.01.2013 15:19 +0100 -Ulf

Re: review request: 8006505 additional updates for JSR 310

2013-02-05 Thread Lance Andersen - Oracle
Hi Ulf, On Feb 5, 2013, at 6:07 PM, Ulf Zibis wrote: > Am 05.02.2013 15:40, schrieb Lance Andersen - Oracle: >> HI, >> >> >> This is a review request for >> http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to >> SQLInput/Ouput (used for UDTs) to have generic methods for

Re: review request: 8006505 additional updates for JSR 310

2013-02-05 Thread Ulf Zibis
Am 05.02.2013 15:40, schrieb Lance Andersen - Oracle: HI, This is a review request for http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to SQLInput/Ouput (used for UDTs) to have generic methods for types allowing support for JSR 310. Hi Lance, I would set the exce

review request: 8006505 additional updates for JSR 310

2013-02-05 Thread Lance Andersen - Oracle
HI, This is a review request for http://cr.openjdk.java.net/~lancea/8006505/webrev.00/ which adds support to SQLInput/Ouput (used for UDTs) to have generic methods for types allowing support for JSR 310. Also now that 310 is in M6, update Types and JDBCType to add entries for TIME/TIMESTAMP