Re: review request 7097386: Correct error in Predicate javadoc example --- Still need an approval from a reviewer

2013-09-17 Thread Lance Andersen - Oracle
On Sep 17, 2013, at 7:14 AM, Alan Bateman wrote: > On 17/09/2013 11:55, Lance Andersen - Oracle wrote: >> Hi Folks, >> >> Aleksey has been kind enough to review this change. Still need the blessing >> of a reviewer to put this back... >> >> any takers :-) > It looks okay although if is this i

Re: Fwd: review request 7097386: Correct error in Predicate javadoc example --- Still need an approval from a reviewer

2013-09-17 Thread Alan Bateman
On 17/09/2013 11:55, Lance Andersen - Oracle wrote: Hi Folks, Aleksey has been kind enough to review this change. Still need the blessing of a reviewer to put this back... any takers :-) It looks okay although if is this is sample code that we expect developers to copy then we could do more,

Fwd: review request 7097386: Correct error in Predicate javadoc example --- Still need an approval from a reviewer

2013-09-17 Thread Lance Andersen - Oracle
ore-libs-dev Core-Libs-Dev > Subject: Re: review request 7097386: Correct error in Predicate javadoc > example > > Thanks for the input. > On Sep 16, 2013, at 4:58 AM, Aleksey Shipilev wrote: > >> On 09/15/2013 10:38 PM, Lance Andersen - Oracle wrote: >>> I

Re: review request 7097386: Correct error in Predicate javadoc example

2013-09-16 Thread Aleksey Shipilev
On 09/16/2013 03:12 PM, Lance Andersen - Oracle wrote: > Changes are at http://cr.openjdk.java.net/~lancea/7097386/webrev.01/ Thumbs up. -Aleksey.

Re: review request 7097386: Correct error in Predicate javadoc example

2013-09-16 Thread Lance Andersen - Oracle
Thanks for the input. On Sep 16, 2013, at 4:58 AM, Aleksey Shipilev wrote: > On 09/15/2013 10:38 PM, Lance Andersen - Oracle wrote: >> I added a webrev >> http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be >> a bit easier for this review. > > Notes: > - change C-style "int v[]"

Re: review request 7097386: Correct error in Predicate javadoc example

2013-09-16 Thread Aleksey Shipilev
On 09/15/2013 10:38 PM, Lance Andersen - Oracle wrote: > I added a webrev > http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be > a bit easier for this review. Notes: - change C-style "int v[]" declarations to Java-ish "int[] v". - catching SQLException should probably return

Re: review request 7097386: Correct error in Predicate javadoc example

2013-09-15 Thread Lance Andersen - Oracle
I added a webrev http://cr.openjdk.java.net/~lancea/7097386/webrev.00/ as it might be a bit easier for this review. Best lance On Sep 13, 2013, at 4:40 PM, Lance Andersen - Oracle wrote: > Hi Everyone, > > Looking for a reviewer for this trivial fix to correct the sample example in > the Predi

review request 7097386: Correct error in Predicate javadoc example

2013-09-13 Thread Lance Andersen - Oracle
Hi Everyone, Looking for a reviewer for this trivial fix to correct the sample example in the Predicate javadoc for the evaluate method() -- !hg hg diff Predicate.java diff -r 60d6f60416ca src/share/classes/javax/sql/rowset/Predicate.java --- a/src/share/classes/javax/sql/rowse