On Apr 26, 2013, at 8:35 AM, Alan Bateman wrote:
> On 25/04/2013 21:53, Lance Andersen - Oracle wrote:
>> http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos
>> that were pointed out and also fixes a couple javadoc warnings
>>
> This looks okay to me.
>
> One small sugge
On 25/04/2013 21:53, Lance Andersen - Oracle wrote:
http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that
were pointed out and also fixes a couple javadoc warnings
This looks okay to me.
One small suggestion for DriverAction and the first statement where it
reads "
http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that
were pointed out and also fixes a couple javadoc warnings
Best,
Lance
On Apr 22, 2013, at 11:17 AM, Lance Andersen - Oracle wrote:
>
> On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote:
>
>> On 21/04/2013 12:45, Lanc
On Apr 21, 2013, at 11:09 AM, Ulf Zibis wrote:
> Minor nits:
> DriverManager line 349: I would break the line right after the opening
> parenthesis.
I did not change this as other methods break after the 1st parameter
(getConnection is one example) so I would prefer to keep it consistent (or a
On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote:
> On 21/04/2013 12:45, Lance Andersen - Oracle wrote:
>> :
>>>
>>> DriverManager
>>>
>>> - one point that isn't covered in the spec is whether the DriverAction's
>>> deregister is invoked before or after it is deregistered. This distinction
>>>
On 21/04/2013 12:45, Lance Andersen - Oracle wrote:
:
DriverManager
- one point that isn't covered in the spec is whether the DriverAction's
deregister is invoked before or after it is deregistered. This distinction is
probably only interesting for the case that the deregister method fails w
Minor nits:
DriverManager line 349: I would break the line right after the opening
parenthesis.
DriverManager line 355: missing space after comma.
-Ulf
Am 21.04.2013 13:45, schrieb Lance Andersen - Oracle:
Thank you for the feedback Alan,
Please see below and the webrev
http://cr.openjdk.jav
Thank you for the feedback Alan,
Please see below and the webrev
http://cr.openjdk.java.net/~lancea/8010416/webrev.02/
On Apr 21, 2013, at 4:34 AM, Alan Bateman wrote:
> On 19/04/2013 18:34, Lance Andersen - Oracle wrote:
>> Hi,
>>
>> We have been asked by a few JDBC driver vendors to allow a
On 19/04/2013 18:34, Lance Andersen - Oracle wrote:
Hi,
We have been asked by a few JDBC driver vendors to allow a JDBC driver to be
notified when/if it was deregistered via DriverManager.deregisterDriver if
desired.
The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/web
Hi,
We have been asked by a few JDBC driver vendors to allow a JDBC driver to be
notified when/if it was deregistered via DriverManager.deregisterDriver if
desired.
The webrev can be found at http://cr.openjdk.java.net/~lancea/8010416/webrev.01
Best
Lance
Lance Andersen| Principal Memb
10 matches
Mail list logo