On 25/10/2012 22:26, Dan Xu wrote:
Hi,
Please review the code change to avoid native codes when creating the
FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/.
In the change, the native codes for windows and unix platforms are
removed. Instead, corresponding Java codes are a
Changeset: 0b52c87c39da
Author:dxu
Date: 2012-10-26 11:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b52c87c39da
4239752: FileSystem should be a platform-specific class to avoid native code
Reviewed-by: alanb, dholmes, erikj, jgish
! make/java/java/Exportedfiles.gmk
! m
Looks good to me. You also fixed the new build to include
java.io.FileSystem - that's good.
Mandy
On 10/25/2012 2:26 PM, Dan Xu wrote:
Hi,
Please review the code change to avoid native codes when creating the
FileSystem object, http://cr.openjdk.java.net/~dxu/4239752/webrev/.
In the chan
Changeset: 217c265158fe
Author:jjg
Date: 2012-10-26 13:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/217c265158fe
8001219: Clean up use of URLs in javadoc Extern class
Reviewed-by: darcy
! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java
Changeset: 3fc5457cf779
Author:dl
Date: 2012-10-26 21:34 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fc5457cf779
8001575: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012
Reviewed-by: chegar, dholmes
! src/share/classes/java/util/concurrent/AbstractExecutorService.java
Thanks David,
java.sun.com... D'oh. Updated and pushed. The meat will come shortly!
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fc5457cf779
-Chris.
On 10/26/2012 03:06 AM, David Holmes wrote:
Hi Chris,
You can count me as a reviewer anyway. :)
A couple of observations:
--- old/src/share
Changeset: 64fce9f95b1d
Author:jjg
Date: 2012-10-26 17:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64fce9f95b1d
8001714: add missing tests for 7199925
Reviewed-by: darcy
+ test/tools/javac/annotations/repeatingAnnotations/ClassReaderDefault.java
+ test/tools/java
