hg: jdk8/tl/langtools: 5053846: javac: MethodRef entries are duplicated in the constant pool

2013-03-15 Thread vicente . romero
Changeset: fa24eba012bd Author:vromero Date: 2013-03-15 09:02 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fa24eba012bd 5053846: javac: MethodRef entries are duplicated in the constant pool Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.j

Review request: JDK-8006193 (process) Clean-up java.lang.ProcessImpl.finalize, does not need to be public.

2013-03-15 Thread Alexey Utkin
Bug description: https://jbs.oracle.com/bugs/browse/JDK-8006193 http://bugs.sun.com/view_bug.do?bug_id=8006193 Here is the suggested trivial fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8006193/ Summary: Makes [FindBug] code analyzer happy. -public void finalize() { +

Re: Review request: JDK-8006193 (process) Clean-up java.lang.ProcessImpl.finalize, does not need to be public.

2013-03-15 Thread Alan Bateman
On 15/03/2013 09:20, Alexey Utkin wrote: Summary: Makes [FindBug] code analyzer happy. -public void finalize() { +protected void finalize() { This looks fine to me, it's a package-private class so there's no issue. -Alan.

Re: RFR 8005696: Add CompletableFuture - JEP 155

2013-03-15 Thread Doug Lea
On 03/14/13 23:25, Martin Buchholz wrote: Doing a mini-audit of these methods, here is a change to what seems to be the intent: Yes, thanks! This keeps the exception specs consistent across similar methods. -Doug Index: ./java/util/concurrent/CompletableFuture.java

hg: jdk8/tl/langtools: 8007767: TargetAnnoCombo.java need to be updated to add a new test mode

2013-03-15 Thread joel . franck
Changeset: 195b71850b56 Author:mnunez Date: 2013-03-15 13:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/195b71850b56 8007767: TargetAnnoCombo.java need to be updated to add a new test mode Reviewed-by: jjg, strarup ! test/tools/javac/annotations/repeatingAnnotation

Re: RFR 8005696: Add CompletableFuture - JEP 155

2013-03-15 Thread Chris Hegarty
On 15/03/2013 12:00, Doug Lea wrote: On 03/14/13 23:25, Martin Buchholz wrote: Doing a mini-audit of these methods, here is a change to what seems to be the intent: Yes, thanks! This keeps the exception specs consistent across similar methods. Now that I reread these method descriptions, I t

hg: jdk8/tl/jdk: 8010136: Make jrunscript's init.js to work on nashorn

2013-03-15 Thread sundararajan . athijegannathan
Changeset: 46ad8dfabd5f Author:sundar Date: 2013-03-15 19:30 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ad8dfabd5f 8010136: Make jrunscript's init.js to work on nashorn Reviewed-by: lagergren, hannesw ! src/share/classes/com/sun/tools/script/shell/init.js

Re: Please review fix for JDK-8010083: Fix ASM doc comments to avoid javadoc errors

2013-03-15 Thread Kumar Srinivasan
I concur too, I will chat with the Objectweb folks and see what needs to be done. Kumar - Original Message - On 14/03/2013 14:03, A. Sundararajan wrote: Please review http://cr.openjdk.java.net/~sundar/8010083/ Thanks -Sundar This looks okay to me but do we want to be changing the A

Re: @Supported design issues

2013-03-15 Thread mark . reinhold
2013/3/4 2:58 -0800, joe.da...@oracle.com: > On 02/28/2013 11:31 AM, mark.reinh...@oracle.com wrote: >> 2013/2/23 5:10 -0800, joe.da...@oracle.com: >>> Having Supported take a boolean value both allows the explicit statement >>> that an item is not supported as well as providing a possible transiti

Re: @Supported design issues

2013-03-15 Thread Joe Darcy
On 03/15/2013 02:12 PM, mark.reinh...@oracle.com wrote: 2013/3/4 2:58 -0800, joe.da...@oracle.com: On 02/28/2013 11:31 AM, mark.reinh...@oracle.com wrote: 2013/2/23 5:10 -0800, joe.da...@oracle.com: Having Supported take a boolean value both allows the explicit statement that an item is not su