Please reviewthe patch for java/net/ipv6tests/UdpTest.java
bug: https://bugs.openjdk.java.net/browse/JDK-8143097
webrev: http://cr.openjdk.java.net/~amlu/8143097/webrev.00/
This test fails intermittently in a test scenario for checking
DatagramSocket (with SO_TIMEOUT enabled) 'receive'works eve
Amy,
> On 2 Nov 2016, at 09:43, Amy Lu wrote:
>
> Please reviewthe patch for java/net/ipv6tests/UdpTest.java
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8143097
> webrev: http://cr.openjdk.java.net/~amlu/8143097/webrev.00/
I think what you have will probably be ok, given the 50% toleranc
I agree with Nadeesh, the updated code can still throw
DateTimeException from the call to getLong(). Unlike before, this
DateTimeException is desired.
Stephen
On 28 October 2016 at 16:58, nadeesh tv wrote:
>
> Hi Anubhav,
>
>
> - * @throws DateTimeException if the field is not available and
On 11/2/16 6:17 PM, Chris Hegarty wrote:
Amy,
On 2 Nov 2016, at 09:43, Amy Lu wrote:
Please reviewthe patch for java/net/ipv6tests/UdpTest.java
bug: https://bugs.openjdk.java.net/browse/JDK-8143097
webrev: http://cr.openjdk.java.net/~amlu/8143097/webrev.00/
I think what you have will probab
On 2 Nov 2016, at 02:47, Amy Lu wrote:
>
> Please review the patch for fixing typo in steam tests:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8151511
> webrev: http://cr.openjdk.java.net/~amlu/8151511/webrev.00/
This looks good. Thanks Amy.
-Chris.
> 1) In CollectionAndMapModifyStreamT
Hi team,
Please review a very small fix for tests related to java/io/Serializable
pack.
BugID: https://bugs.openjdk.java.net/browse/JDK-8169055
WebRev: http://cr.openjdk.java.net/~skovalev/8169055/webrev.00/
Issue: Several tests failing in case usage of "--limit-modules" command
line option.
On 2 Nov 2016, at 11:06, Amy Lu wrote:
>
> On 11/2/16 6:17 PM, Chris Hegarty wrote:
>> Amy,
>>
>>> On 2 Nov 2016, at 09:43, Amy Lu wrote:
>>>
>>> Please reviewthe patch for java/net/ipv6tests/UdpTest.java
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8143097
>>> webrev: http://cr.open
Hi Sergey,
I do not see any dependency on jdk.jdeps in the test sources.
What I do see is a dependency on java.compiler though.
So why @modules jdk.jdeps and not @modules java.compiler?
best regards,
-- daniel
On 02/11/16 11:22, Sergei Kovalev wrote:
Hi team,
Please review a very small fix
Hi Daniel,
Thank you for looking this.
We have six java files: CheckInputOrderTest.java,
FilterWithSecurityManagerTest.java, GlobalFilterTest.java,
MixedFiltersTest.java, SerialFilterTest.java.
Last one has declared import:
import javax.lang.model.SourceVersion;
that is a part of jdk.jdeps
> On 2 Nov 2016, at 12:31, Sergei Kovalev wrote:
>
> javax.lang.model.SourceVersion
This type is in the java.compiler module.
-Chris.
Fixed
http://cr.openjdk.java.net/~skovalev/8169055/webrev.01/
02.11.16 15:34, Chris Hegarty wrote:
On 2 Nov 2016, at 12:31, Sergei Kovalev wrote:
javax.lang.model.SourceVersion
This type is in the java.compiler module.
-Chris.
--
With best regards,
Sergei
Hi,
Instead of adding more dependencies, let me look and see if there is way
to remove the dependency.
Roger
On 11/2/16 8:51 AM, Sergei Kovalev wrote:
Fixed
http://cr.openjdk.java.net/~skovalev/8169055/webrev.01/
02.11.16 15:34, Chris Hegarty wrote:
On 2 Nov 2016, at 12:31, Sergei Kovalev
Hi,
This are the changes needed to the tests in the jdk repository
to work with s390.
In test/sun/tools/jhsdb I just use the other Platform.java which
gets it's shouldSAAttach() method changed to return 'false' on
S390. (I sent that part of the change to the hs-compiler list.)
test/java/awt/JAWT
Hi Sergey,
On 02/11/16 12:31, Sergei Kovalev wrote:
Hi Daniel,
Thank you for looking this.
We have six java files: CheckInputOrderTest.java,
FilterWithSecurityManagerTest.java, GlobalFilterTest.java,
MixedFiltersTest.java, SerialFilterTest.java.
Last one has declared import:
import javax.lan
Hi Sergey,
Why jdk.compiler? Why not simply java.compiler?
best regards,
-- daniel
On 02/11/16 12:51, Sergei Kovalev wrote:
Fixed
http://cr.openjdk.java.net/~skovalev/8169055/webrev.01/
02.11.16 15:34, Chris Hegarty wrote:
On 2 Nov 2016, at 12:31, Sergei Kovalev
wrote:
javax.lang.model.
Thank you all,
java.compiler is enough.
http://cr.openjdk.java.net/~skovalev/8169055/webrev.02/
02.11.16 16:25, Daniel Fuchs wrote:
Hi Sergey,
Why jdk.compiler? Why not simply java.compiler?
best regards,
-- daniel
On 02/11/16 12:51, Sergei Kovalev wrote:
Fixed
http://cr.openjdk.java.ne
Hi Goetz,
the change looks good except the two throws declarations in:
test/sun/tools/jhsdb/BasicLauncherTest.java
test/sun/tools/jhsdb/HeapDumpTest.java
I think "throws Exception" should be enough - we don't need "throws
IOException, Exception".
Thanks,
Volker
PS: we should really get rid of
Thank you Brian for review!
On 31.10.2016 21:23, Brian Burkhalter wrote:
One more thing …
In [1] lines 58-59 could be corrected in the same way.
Yes, right. Thanks for catching it!
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8168923/01/webrev/
Thanks,
Brian
[1]
htt
Hi Ivan,
This all looks good. +1.
Thanks,
Brian
On Nov 2, 2016, at 7:39 AM, Ivan Gerasimov wrote:
> Thank you Brian for review!
>
>
> On 31.10.2016 21:23, Brian Burkhalter wrote:
>> One more thing …
>>
>> In [1] lines 58-59 could be corrected in the same way.
>
> Yes, right. Thanks for c
Moving discussion to core-libs-dev. Please follow-up there.
Thanks,
David
On 3/11/2016 1:20 AM, Dmitry Zhikharev wrote:
Hi!
ForkJoinPool class documentation says nothing about it using daemon threads
since Java 8
(https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ForkJoinPool.ht
Thank you Joe for review!
On 31.10.2016 20:11, joe darcy wrote:
Hi Ivan,
The code change in src look fine, but please update the existing test
test/java/lang/annotation/AnnotationToStringTest.java
rather than introducing a new test file.
Yes, right, this is better. Here's the updated
On 2016-11-02 16:58, Ivan Gerasimov wrote:
Thank you Joe for review!
On 31.10.2016 20:11, joe darcy wrote:
Hi Ivan,
The code change in src look fine, but please update the existing test
test/java/lang/annotation/AnnotationToStringTest.java
rather than introducing a new test file.
Y
Hi,
I would rather switch the test to use a type in the base module.
Switching from SourceVersion to javax.net.ssl.SSLEngineResult enables
the test to run
without additional @modules.
Webrev/patch:
http://cr.openjdk.java.net/~rriggs/webrev-filter-classes-8169055/
Roger
On 11/2/2016 9:31 AM,
Looks good Ivan; thanks,
-Joe
On 11/2/2016 8:58 AM, Ivan Gerasimov wrote:
Thank you Joe for review!
On 31.10.2016 20:11, joe darcy wrote:
Hi Ivan,
The code change in src look fine, but please update the existing test
test/java/lang/annotation/AnnotationToStringTest.java
rather than in
Hi all,
The diff below takes advantage the since element that was added to the
Deprecated annotation to clarify when the JDBC methods where deprecated in Java
SE.
The CCC has been approved
Best
Lance
———
ljanders-mac:jdk ljanders$ hg diff
diff -r 77f35eef4ef9 src/java.sql/share/classes/ja
jdeps now has a new option [1] to make it easy to analyze the test dependency;
—-list-deps and —-list-reduced-deps
$ jdeps --list-deps -cp testng.jar
JTwork/classes/java/io/Serializable/serialFilter/
java.base
java.compiler
unnamed module: testng.jar
This will also list internal AP
Looks fine Lance; cheers,
-Joe
On 11/2/2016 11:04 AM, Lance Andersen wrote:
Hi all,
The diff below takes advantage the since element that was added to the
Deprecated annotation to clarify when the JDBC methods where deprecated in Java
SE.
The CCC has been approved
Best
Lance
———
ljand
On 02/11/16 17:39, Roger Riggs wrote:
Hi,
I would rather switch the test to use a type in the base module.
Switching from SourceVersion to javax.net.ssl.SSLEngineResult enables
the test to run
without additional @modules.
Webrev/patch:
http://cr.openjdk.java.net/~rriggs/webrev-filter-classes-81
Hi Amy
Oops. Looks good.
Paul.
> On 1 Nov 2016, at 19:47, Amy Lu wrote:
>
> Please review the patch for fixing typo in steam tests:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8151511
> webrev: http://cr.openjdk.java.net/~amlu/8151511/webrev.00/
>
> 1) In CollectionAndMapModifyStreamTe
> On 2 Nov 2016, at 18:14, Daniel Fuchs wrote:
>
> On 02/11/16 17:39, Roger Riggs wrote:
>> Hi,
>>
>> I would rather switch the test to use a type in the base module.
>> Switching from SourceVersion to javax.net.ssl.SSLEngineResult enables
>> the test to run
>> without additional @modules.
>>
Hi All,
Our most recent DirectIO patch is available at
http://cr.openjdk.java.net/~igraves/8164900-3/
In this version, we made following changes:
1. Removed the flag "direct" from FileDescriptor class. Instead, moved it to
the FileChannelImpl class.
2. Provided a way for user to allocate a pa
Hello,
As found by Phil Race, the original substitution text for
Class.newInstance (JDK-8159330) is not equivalent in all cases. This
should be addressed. The current suggested replacement text is
"The call
clazz.newInstance()
can be replaced by
clazz.getConstructor().newInstance()"
The
> On Nov 2, 2016, at 5:51 PM, joe darcy wrote:
>
> :
> The getConstructor call only returns *public* constructors while newInstance
> can call non-public constructors too, subject to the appropriate security
> checks.
>
>
> Therefore, using "getDeclaredConstructor()" is a better replacement
33 matches
Mail list logo
