On 03/09/2018 05:54, Ivan Gerasimov wrote:
Thanks Sherman and Stuart for the review!
On 9/2/18 2:45 PM, Stuart Marks wrote:
Yes, the fix itself looks fine. Quite subtle, good catch.
But should this have a regression test? I can imagine somebody coming
along later and "simplifying" (!(... > ..
Hi,
following the latest updates to the idea.sh script, Mac users reported
issues - mostly having to do with usage of 'sed' - more specifically:
* sed -i option is not portable - it has different formats in Mac vs.
Linux. This patch does without -i, by moving the replaced file onto a
temporar
Hi Max, I
- moved getErrorPosition method to Manifest.java
- in read() method, removed "int offset"
- in the exception message, I write now " manifest of " ... (without
mentioning a manifest name)
http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.8/
Best regards, Matthias
> --
Hi Matthias
The change looks fine. We can enhance the name if we want to support .SF
parsing later.
Please revise your CSR and get it approved first.
Thanks
Max
> On Sep 3, 2018, at 10:19 PM, Baesken, Matthias
> wrote:
>
> Hi Max, I
>
> - moved getErrorPosition method to Manifest.java
Looks good to me. I would add a call to
new MyDecoder(ascii, 0.5f, 1.5f)
to make sure all calls to the constructor don't throw (because e.g. for
ASCII we know the correct values are 1.0f).
(In any case it feels like an API design mistake - the Charset itself
should be the source of truth about
On 29/08/2018 22:56, Xueming Shen wrote:
It appears it's not necessary to have the "hasAbsolutePath" and pay
the price to check in
initCEN(). I managed to do it locally inside copyLOCEntry(...).
http://cr.openjdk.java.net/~sherman/8197398/webrev/
This approach looks good.
-Alan
Hi folks,
I'd like to get a re-review of this change:
https://bugs.openjdk.java.net/browse/JDK-8139965
http://cr.openjdk.java.net/~robm/8139965/webrev/
In case the original has gone stale:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-August/042767.html
-Rob
test/jdk/jdk/internal/reflect/Reflection/GetCallerClassTest.sh
Please review this patch to refactor above shell script test to java.
bug: https://bugs.openjdk.java.net/browse/JDK-8209832
webrev: http://cr.openjdk.java.net/~amlu/8209832/webrev.00/
Thanks,
Amy
Please review the changes to add 10 JNDI tests to com/sun/jndi/dns/FedTests/ in
OpenJDK, thanks
bug: https://bugs.openjdk.java.net/browse/JDK-8210339
webrev: http://cr.openjdk.java.net/~xyin/8210339/webrev.00/
Regards,
Chris
