Re: RFR(XS): 8075658: Mark intermittently failuring core-svc tests

Hi Katja, Looks ok to me too. It has been a relatively manual process and I'm not aware of a mechanism how to sync test-key-bug. What I can do is to mark bugs I went through with for example 'key-intermittent' label to distinguish them form the new ones. That's another additional label, and

[9] RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Please review this fix in for wrong rounding-mode mode behavior of NumberFormat.format(double) in HALF_UP case. https://bugs.openjdk.java.net/browse/JDK-8039915 webrev: http://cr.openjdk.java.net/~olagneau/8039915/webrev.00 Bug came

Please review [9] RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Could someone please review this code change ? Thanks in advance, Olivier Lagneau On 09/09/2014 22:44, olivier.lagn...@oracle.com wrote: Please review this fix in for wrong rounding-mode mode behavior of NumberFormat.format(double) in HALF_UP case. https://bugs.openjdk.java.net/browse/JDK

Re: Urgent [9] RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

/2014 18:07, olivier.lagn...@oracle.com wrote: Could someone please review this code change ? Thanks in advance, Olivier Lagneau On 09/09/2014 22:44, olivier.lagn...@oracle.com wrote: Please review this fix in for wrong rounding-mode mode behavior of NumberFormat.format(double) in HALF_UP case

Re: Urgent [9] RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Hi William, Thanks a lot for your time and checks ! On 19/09/2014 22:02, William Price wrote: Hi Oliver, First, sorry about mistyping your name, Olivier! I copied your patch into my shim locally and ran my test cases and still get a couple failures (see output below). Your patch and my vers

Re: Urgent [9] RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

bleToTest).toString()); +System.out.print(" Rounding mode: " + rm); +System.out.print(", fract digits : " + mfd); +System.out.print(", position : " + tiePosition + " tie"); +System.out.print(", result : " + result); +Sys

Re: Urgent [9] RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Thanks Brian, Will take into account your wording remarks. Olivier. On 22/09/2014 17:50, Brian Burkhalter wrote: Hi Olivier, On Sep 22, 2014, at 7:56 AM, olivier.lagn...@oracle.com <mailto:olivier.lagn...@oracle.com> wrote: and 2) use braces around all the statements contained in i

Re: Urgent [9] RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

3 cases in the same manner when very close to tie. Will change the code to group HALF_UP and HALF_DOWN. Thanks, Olivier. Thanks, -Joe On 09/22/2014 08:50 AM, Brian Burkhalter wrote: Hi Olivier, On Sep 22, 2014, at 7:56 AM, olivier.lagn...@oracle.com wrote: and 2) use braces around all

Urgent [9], 2nd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Please review this 2nd version of the fix taking into account your feedback. Bug : https://bugs.openjdk.java.net/browse/JDK-8039915 webrev : http://cr.openjdk.java.net/~olagneau/8039915/webrev.00

Urgent [9], 2nd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Please review this 2nd version of the fix taking into account your feedback. Bug : https://bugs.openjdk.java.net/browse/JDK-8039915 webrev : http://cr.openjdk.java.net/~olagneau/8039915/webrev.01 I have changed the code following your r

Re: Urgent [9], 2nd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Oops, please forget this one that is missing text of what is done in this webrev. wrong gui manipulation ... Sorry for this, Olivier. On 02/10/2014 18:08, olivier.lagn...@oracle.com wrote: Please review this 2nd version of the fix taking into account your feedback. Bug : https

Re: Urgent [9], 2nd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

Hi William, On 07/10/2014 18:33, William Price wrote: Please review this 2nd version of the fix taking into account your feedback. I'm not recognized here as a reviewer, but the code looked OK to me and it passed my patch test suite. Thanks for letting me know. That provides additional confiden

Re: Urgent [9], 2nd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

suitable comment. Please make these adjustments and I'll do a careful review of the rounding logic. Thanks, -Joe On 10/2/2014 9:29 AM, olivier.lagn...@oracle.com wrote: Please review this 2nd version of the fix taking into account your feedback. Bug : https://bugs.openjdk.java.net/browse/JDK-80

Re: Urgent [9], 3rd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

undingMode == RoundingMode.HALF_UP; with a suitable comment. Please make these adjustments and I'll do a careful review of the rounding logic. Thanks, -Joe On 10/2/2014 9:29 AM, olivier.lagn...@oracle.com wrote: Please review this 2nd version of the fix taking into account

Re: Urgent [9], 3rd round, RFR (S) : JDK-8039915 NumberFormat.format() does not consider required no. of fraction digits properly

On 10/9/2014 3:27 AM, olivier.lagn...@oracle.com wrote: Please review this 3rd version of the fix taking into account latest feedback from Joe. Bug : https://bugs.openjdk.java.net/browse/JDK-8039915 Webrev : http://cr.openjdk.java.net/~olagneau/8039915/webrev.02/ <http://cr.openjdk.

Sponsor needed : JDK-8039915 : Wrong NumberFormat.format() HALF_UP rounding when last digit exactly at rounding position greater than 5

Could someone please sponsor this change for 9 ? The webrev and patch are here: http://cr.openjdk.java.net/~olagneau/8039915/webrev.03 And the review discussions are here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/028956.html http://mail.openjdk.java.net/pipermail/core-l

Re: DecimalFormat rounding changes in 8 (JEP 177)?

Hello, On 04/05/2014 20:41, Joe Darcy wrote: Hello, On 5/4/2014 9:56 AM, solo-java-core-l...@goeswhere.com wrote: Hey, Could someone please help me understand what changes have happened in rounding in DecimalFormat in Java 8? new DecimalFormat("0.00").format(1.035) is 1.04 on Java 7, and 1.0

Re: DecimalFormat rounding changes in 8 (JEP 177)?

On 05/05/2014 09:59, Bernd wrote: Hello, Can you maybe point to the commit or Bug Number for this? The outcome of this correctness fit is pretty unfortunate (at least for the Number in question). Initial bug Number in JDK7 is JDK-7131459: https://bugs.openjdk.java.net/browse/JDK-7131459 relat