> Can I please get a review for this change which fixes an issue in
> `jdk.internal.jimage.ImageReader`?
>
> The `ImageReader` maintains a map of `nodes` which it uses to keep track of
> directories/resources from within the image. When a `findNode` is called, it
> leads to building the
On Wed, 8 Jun 2022 13:12:09 GMT, Raffaello Giulietti wrote:
> These 19'545 doubles were generated on purpose by Paul Zimmermann of INRIA as
> hard test cases.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9084
On Thu, 9 Jun 2022 18:38:18 GMT, Brian Burkhalter wrote:
>> Modify native multi-byte read-write code used by the `java.io` classes to
>> limit the size of the allocated native buffer thereby decreasing off-heap
>> memory footprint and increasing throughput.
>
> Brian Burkhalter has updated the
> Modify native multi-byte read-write code used by the `java.io` classes to
> limit the size of the allocated native buffer thereby decreasing off-heap
> memory footprint and increasing throughput.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase.
On Fri, 17 Jun 2022 08:43:00 GMT, Andrey Turbanov wrote:
> Fields `STARTTIME_ANY` and `STARTTIME_PROCESS_UNKNOWN` are actually unused,
> but they are useful as documentation on the interface to native.
> Make them `static` to reduce memory usage.
Marked as reviewed by iris (Reviewer).
On Fri, 17 Jun 2022 16:44:30 GMT, Raffaello Giulietti wrote:
> Extend delegation by instance returned by Random.from() to all methods
> exposed by RandomGenerator.
Looks fine. I agree this implementation is more in keeping with the intent of
the specification.
-
Marked as
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes an issue in
> `jdk.internal.jimage.ImageReader`?
>
> The `ImageReader` maintains a map of `nodes` which it uses to keep track of
> directories/resources from within the image. When a
On Fri, 24 Jun 2022 18:51:40 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList tools/jlink/plugins/CompressorPluginTest.java.
This pull request has now been integrated.
Changeset: 08288819
Author:Daniel D. Daugherty
URL:
On Fri, 24 Jun 2022 18:54:42 GMT, Leonid Mesnik wrote:
>> A trivial fix to ProblemList tools/jlink/plugins/CompressorPluginTest.java.
>
> Marked as reviewed by lmesnik (Reviewer).
@lmesnik and @bplb - Thanks for the lightning fast reviews!
-
PR:
On Fri, 24 Jun 2022 18:51:40 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList tools/jlink/plugins/CompressorPluginTest.java.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9285
On Fri, 24 Jun 2022 18:51:40 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList tools/jlink/plugins/CompressorPluginTest.java.
Marked as reviewed by lmesnik (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9285
A trivial fix to ProblemList tools/jlink/plugins/CompressorPluginTest.java.
-
Commit messages:
- 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java
Changes: https://git.openjdk.org/jdk/pull/9285/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=9285=00
Issue:
On Thu, 23 Jun 2022 07:18:07 GMT, Alan Bateman wrote:
>> src/java.base/unix/classes/sun/nio/fs/UnixFileAttributes.java line 80:
>>
>>> 78: static UnixFileAttributes getIfExists(UnixPath path) throws
>>> UnixException {
>>> 79: UnixFileAttributes attrs = new UnixFileAttributes();
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes an issue in
> `jdk.internal.jimage.ImageReader`?
>
> The `ImageReader` maintains a map of `nodes` which it uses to keep track of
> directories/resources from within the image. When a
On Fri, 17 Jun 2022 08:43:00 GMT, Andrey Turbanov wrote:
> Fields `STARTTIME_ANY` and `STARTTIME_PROCESS_UNKNOWN` are actually unused,
> but they are useful as documentation on the interface to native.
> Make them `static` to reduce memory usage.
Marked as reviewed by bpb (Reviewer).
On Wed, 22 Jun 2022 18:19:56 GMT, Roger Riggs wrote:
> The RuntimeException from OutputAnalyzer for expected and unexpected exit
> values should include both the actual and expected values.
> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the
> value expected and the
On Fri, 17 Jun 2022 08:43:00 GMT, Andrey Turbanov wrote:
> Fields `STARTTIME_ANY` and `STARTTIME_PROCESS_UNKNOWN` are actually unused,
> but they are useful as documentation on the interface to native.
> Make them `static` to reduce memory usage.
LGTM
-
Marked as reviewed by
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes an issue in
> `jdk.internal.jimage.ImageReader`?
>
> The `ImageReader` maintains a map of `nodes` which it uses to keep track of
> directories/resources from within the image. When a
On Thu, 23 Jun 2022 10:55:00 GMT, Alan Bateman wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
On Wed, 22 Jun 2022 22:26:23 GMT, Brian Burkhalter wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> -
On Thu, 23 Jun 2022 08:05:42 GMT, Chris Hegarty wrote:
>> Hi,
>>
>> Please review the following patch which will:
>>
>> - Enhance the java.nio.file.spi.FileSystemProvider abstract class to include
>> the methods
>>
>> - public boolean exists(Path path, LinkOption... options)
>> - public
On Wed, 22 Jun 2022 21:29:50 GMT, Andrey Turbanov wrote:
>> Instead of separate ConcurrentHashMap.get call, we can use result of
>> previous putIfAbsent call.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8288723:
On Fri, 17 Jun 2022 08:43:00 GMT, Andrey Turbanov wrote:
> Fields `STARTTIME_ANY` and `STARTTIME_PROCESS_UNKNOWN` are actually unused,
> but they are useful as documentation on the interface to native.
> Make them `static` to reduce memory usage.
Marked as reviewed by jpai (Reviewer).
23 matches
Mail list logo
