Re: RFR: 8288984: Simplification in Shutdown.exit [v2]

2022-07-02 Thread kristylee88
On Sat, 2 Jul 2022 21:21:37 GMT, Ryan Ernst wrote: >> This is a followup to simplify Shutdown.exit after the removal of >> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement >> on the approach has been reached in this PR, a CSR will be filed to >> propose the spec change to

Re: RFR: 8288984: Simplification in Shutdown.exit

2022-07-02 Thread Chris Hegarty
On Sat, 2 Jul 2022 13:23:27 GMT, David Holmes wrote: > Sorry, I did not think this issue was intended to change the specification in > any way, but I see now that it actually does - whether that was the intent or > not. While, maybe, not strictly envisioned by the JIRA issue, the

Re: RFR: 8288984: Simplification in Shutdown.exit [v2]

2022-07-02 Thread Ryan Ernst
On Sat, 2 Jul 2022 19:32:04 GMT, Alan Bateman wrote: >> If a shutdown hook is running, then shutdown has started, right? This new >> wording isn’t really a change, it’s the current behavior (the “otherwise” >> portion of the old wording). But the wording is meant to be more accurate >> for

Re: RFR: 8288984: Simplification in Shutdown.exit [v2]

2022-07-02 Thread Ryan Ernst
> This is a followup to simplify Shutdown.exit after the removal of > finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement > on the approach has been reached in this PR, a CSR will be filed to > propose the spec change to Runtime.exit. Ryan Ernst has updated the pull request

Re: RFR: 8288984: Simplification in Shutdown.exit

2022-07-02 Thread kristylee88
On Fri, 1 Jul 2022 20:01:48 GMT, Ryan Ernst wrote: > This is a followup to simplify Shutdown.exit after the removal of > finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement > on the approach has been reached in this PR, a CSR will be filed to > propose the spec change to

Re: RFR: 8288984: Simplification in Shutdown.exit

2022-07-02 Thread Alan Bateman
On Sat, 2 Jul 2022 14:07:57 GMT, Ryan Ernst wrote: >> src/java.base/share/classes/java/lang/Runtime.java line 88: >> >>> 86: * Invocations of this method block indefinitely. It is >>> therefore >>> 87: * inadvisable to invoke this method from a shutdown hook as it will >>> 88:

Re: RFR: Merge jdk19 [v2]

2022-07-02 Thread kristylee88
On Sat, 2 Jul 2022 18:13:28 GMT, Jesper Wilhelmsson wrote: >> Forwardport JDK 19 -> JDK 20 > > Jesper Wilhelmsson has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains 199 commits: > > - Merge remote-tracking branch 'jdk19/master'

Re: RFR: Merge jdk19 [v2]

2022-07-02 Thread Jesper Wilhelmsson
> Forwardport JDK 19 -> JDK 20 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 199 commits: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8289603: Code change for JDK-8170762 breaks all build

Integrated: Merge jdk19

2022-07-02 Thread Jesper Wilhelmsson
On Sat, 2 Jul 2022 11:03:38 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: 70f56933 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/70f5693356277c0685668219a79819707d099d9f Stats: 382 lines

Re: RFR: 8288984: Simplification in Shutdown.exit

2022-07-02 Thread Ryan Ernst
On Sat, 2 Jul 2022 13:21:06 GMT, David Holmes wrote: >> This is a followup to simplify Shutdown.exit after the removal of >> finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement >> on the approach has been reached in this PR, a CSR will be filed to >> propose the spec change

Re: RFR: 8288984: Simplification in Shutdown.exit

2022-07-02 Thread David Holmes
On Fri, 1 Jul 2022 20:01:48 GMT, Ryan Ernst wrote: > This is a followup to simplify Shutdown.exit after the removal of > finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement > on the approach has been reached in this PR, a CSR will be filed to > propose the spec change to

Re: RFR: 8288984: Simplification in Shutdown.exit

2022-07-02 Thread David Holmes
On Fri, 1 Jul 2022 20:01:48 GMT, Ryan Ernst wrote: > This is a followup to simplify Shutdown.exit after the removal of > finalizers (https://bugs.openjdk.org/browse/JDK-8198250). Once agreement > on the approach has been reached in this PR, a CSR will be filed to > propose the spec change to

RFR: Merge jdk19

2022-07-02 Thread Jesper Wilhelmsson
Forwardport JDK 19 -> JDK 20 - Commit messages: - Merge remote-tracking branch 'jdk19/master' into Merge_jdk19 - 8245268: -Xcomp is missing from java launcher documentation - 8288703: GetThreadState returns 0 for virtual thread that has terminated - 8288854: