Re: [jdk19] RFR: 8289930: Improve Thread description of inherited AccessControlContext [v2]

2022-07-10 Thread Alan Bateman
> This is a javadoc only change. The "Inheritance when creating threads" > section in the Thread description lists the things that are inherited when > creating a Thread. This includes the somewhat obscure "inherited > AccessControlContext" where the first sentence looks like it wants to be a

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v15]

2022-07-10 Thread Laurent Bourgès
On Thu, 7 Jul 2022 15:58:33 GMT, iaroslavski wrote: >> Sorting: >> >> - adopt radix sort for sequential and parallel sorts on >> int/long/float/double arrays (almost random and length > 6K) >> - fix tryMergeRuns() to better handle case when the last run is a single >> element >> - minor javado

Re: RFR: 8288723: Avoid redundant ConcurrentHashMap.get call in java.time [v3]

2022-07-10 Thread Attila Szegedi
On Mon, 4 Jul 2022 07:06:30 GMT, Andrey Turbanov wrote: >> Instead of separate ConcurrentHashMap.get call, we can use result of >> previous putIfAbsent call. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8288723: Avoi

Re: RFR: 8289711: Add container configuration data to mbeans [v2]

2022-07-10 Thread xpbob
On Wed, 6 Jul 2022 05:59:21 GMT, Alan Bateman wrote: >> xpbob has updated the pull request incrementally with one additional commit >> since the last revision: >> >> update header > > It's not clear that introducing this as a standard API is the right thing to > do. Are you 100% confident th

Re: JMH results for IndexedLinkedList

2022-07-10 Thread Tagir Valeev
Hello! On Sun, Jul 10, 2022 at 6:33 AM Rodion Efremov wrote: > I am interested in > https://bugs.openjdk.org/browse/JDK-8143850 > > Is there a way for becoming an assignee for the above issue? If yes, how do I > proceed and what is the schedule? Stuart Marks might be the right person to ask. Ad

ArrayList grow method optimization and documentation improvement

2022-07-10 Thread Periklis Ntanasis
Hi all, I was reading the ArrayList source code and I think that the "private Object[] grow(int minCapacity)" method does not work as it was intended by the author. Currently the method looks like this ( https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/ArrayList.ja

Re: ArrayList grow method optimization and documentation improvement

2022-07-10 Thread Bernd Eckenfels
I think it means for the zero case it should not use the else part if it has not the default sizing, since somebody might have created it with a specific size. Not sure if it matters much either way. -- http://bernd.eckenfels.net Von: core-libs-dev im Auftrag v

Re: ArrayList grow method optimization and documentation improvement

2022-07-10 Thread Periklis Ntanasis
Thanks for your response. Sure, maybe it doesn't really matter because it is about micro-optimization. The code is correct in any case. However, as I see it the else part could be executed for the following two cases which currently does not: 1. If the ArrayList is initialized as empty and the sha