On Fri, 15 Jul 2022 19:33:56 GMT, Ryan Ernst wrote:
>> This commit guards uses of Files methods returning path streams in
>> java.base to use try-with-resources.
>
> Ryan Ernst has updated the pull request incrementally with one additional
> commit since the last revision:
>
> address
> Initial implementation.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Preserve NaN sign bit.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9422/files
- new:
> Initial implementation.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 15 additional commits since the
last revision:
- Respond to
On Wed, 13 Jul 2022 13:11:33 GMT, Raffaello Giulietti wrote:
>> Initial implementation.
>
> src/java.base/share/classes/java/lang/Float.java line 1174:
>
>> 1172:
>> 1173: short result = 0;
>> 1174: result = (short)(((exp + 15) << 10) | signif_bits);
>
> result =
On Fri, 15 Jul 2022 16:06:21 GMT, Ryan Ernst wrote:
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
Thanks Alan. The 8 space indents were unintentional. I think I've addressed all
your comments in
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
Ryan Ernst has updated the pull request incrementally with one additional
commit since the last revision:
address formatting feedback
-
Changes:
- all:
On Thu, 14 Jul 2022 21:01:05 GMT, Mandy Chung wrote:
> It's expected that [JDK-8287596](https://bugs.openjdk.org/browse/JDK-8287596)
> has resolved [JDK-8288286](https://bugs.openjdk.org/browse/JDK-8288286).
> Remove ReflectionCallerCacheTest.java from the problem list for test
> execution.
On Thu, 14 Jul 2022 21:01:05 GMT, Mandy Chung wrote:
> It's expected that [JDK-8287596](https://bugs.openjdk.org/browse/JDK-8287596)
> has resolved [JDK-8288286](https://bugs.openjdk.org/browse/JDK-8288286).
> Remove ReflectionCallerCacheTest.java from the problem list for test
> execution.
On Fri, 15 Jul 2022 15:31:45 GMT, Roger Riggs wrote:
>> The test `java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java`
>> Fails intermittently when expected output from a subprocess is not found.
>>
>> I suspect a race between the Cleaner that is going to call JNI_OnUnload (in
On Fri, 15 Jul 2022 16:06:21 GMT, Ryan Ernst wrote:
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
src/java.base/share/classes/jdk/internal/module/ModuleHashes.java line 119:
> 117: }
> 118: try {
> 119:
On Fri, 15 Jul 2022 12:40:50 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8290300: Revert jops
> - 8290300: Revert jops
Changes to `Locale` look
This commit adds try-with-resources for uses of Stream from Files
methods that walk directories.
-
Commit messages:
- 8290359: Ensure that all directory streams are closed in jdk.link
Changes: https://git.openjdk.org/jdk/pull/9520/files
Webrev:
This commit guards uses of Files methods returning path streams in
java.base to use try-with-resources.
-
Commit messages:
- 8290316: Ensure that all directory streams are closed in java.base
Changes: https://git.openjdk.org/jdk/pull/9518/files
Webrev:
> The test `java/lang/ClassLoader/loadLibraryUnload/LoadLibraryUnloadTest.java`
> Fails intermittently when expected output from a subprocess is not found.
>
> I suspect a race between the Cleaner that is going to call JNI_OnUnload (in
> NativeLibraries.java:377) when the ClassLoader is no
Hello Roger,
Thanks for the Tipp, that’s indeed a good reason why it’s not needed in the
legacy SDF API.
Gruss
Bernd
--
http://bernd.eckenfels.net
Von: core-libs-dev im Auftrag von Roger Riggs
Gesendet: Friday, July 15, 2022 4:14:16 PM
An:
Hi Bernd,
Perhaps use java.time.format.DateTimeFormatter.
You can create a case-insensitive DateTimeFormatterBuilder using
.parseCaseInsensitive().
https://docs.oracle.com/en/java/javase/18/docs/api/java.base/java/time/format/DateTimeFormatterBuilder.html#parseCaseInsensitive()
Regards,
On Fri, 15 Jul 2022 12:25:07 GMT, Jim Laskey wrote:
>> Сергей Цыпанов has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8290300: Revert jops
>> - 8290300: Revert jops
>
> LGTM, however are there tests that ensure the changes are
On Fri, 15 Jul 2022 12:03:13 GMT, Сергей Цыпанов wrote:
> Simplify code with `String.join()`
Reverted jops
-
PR: https://git.openjdk.org/jdk/pull/9513
On Fri, 15 Jul 2022 12:03:13 GMT, Сергей Цыпанов wrote:
> Simplify code with `String.join()`
joptsimple is a 3rd party code so we probably don't want to change that.
-
PR: https://git.openjdk.org/jdk/pull/9513
On Fri, 15 Jul 2022 12:03:13 GMT, Сергей Цыпанов wrote:
> Simplify code with `String.join()`
LGTM, however are there tests that ensure the changes are benign?
-
PR: https://git.openjdk.org/jdk/pull/9513
Hello,
I noticed that it is surprisingly hard to make SimpleDateFormat accept
all-uppercase month names while parsing. Even with a custom DateFormatSymbols
that’s hard because you can only specify a single symbol for a month name. For
parsing it would be good if you can either specify a list
Simplify code with `String.join()`
-
Commit messages:
- 8290300: Fix copy-right year
- 8290300: Use standard String-joining tools where applicable
Changes: https://git.openjdk.org/jdk/pull/9513/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=9513=00
Issue:
On Tue, 17 May 2022 04:40:50 GMT, liach wrote:
> Generic repositories, the implementation detail for generic information in
> core reflection, can be updated to use the `@Stable` annotation to replace
> their `volatile` access. Their existing accessor code is already safe,
> reading the cache
On Thu, 14 Jul 2022 21:01:05 GMT, Mandy Chung wrote:
> It's expected that [JDK-8287596](https://bugs.openjdk.org/browse/JDK-8287596)
> has resolved [JDK-8288286](https://bugs.openjdk.org/browse/JDK-8288286).
> Remove ReflectionCallerCacheTest.java from the problem list for test
> execution.
OpenJDK bug: JDK-8289471
PR: https://github.com/openjdk/jdk/pull/9369
On Wed, 13 Jul 2022 04:30:39 GMT, Yoshiki Sato wrote:
> Please review this PR. The PR open sources the closed timezone tests.
This pull request has now been integrated.
Changeset: 92deab54
Author:Yoshiki Sato
Committer: Sean Coffey
URL:
On Thu, 14 Jul 2022 21:01:05 GMT, Mandy Chung wrote:
> It's expected that [JDK-8287596](https://bugs.openjdk.org/browse/JDK-8287596)
> has resolved [JDK-8288286](https://bugs.openjdk.org/browse/JDK-8288286).
> Remove ReflectionCallerCacheTest.java from the problem list for test
> execution.
27 matches
Mail list logo
