On Thu, 16 Jun 2022 08:08:15 GMT, Aleksey Shipilev wrote:
> Test appears to pass fine with G1. But it fails with other GCs, for example
> Parallel, Shenandoah, etc, it fails:
>
>
> $ CONF=linux-x86_64-server-fastdebug make test
> TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
>
On Thu, 16 Jun 2022 08:08:15 GMT, Aleksey Shipilev wrote:
> Test appears to pass fine with G1. But it fails with other GCs, for example
> Parallel, Shenandoah, etc, it fails:
>
>
> $ CONF=linux-x86_64-server-fastdebug make test
> TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
>
Test appears to pass fine with G1. But it fails with other GCs, for example
Parallel, Shenandoah, etc, it fails:
$ CONF=linux-x86_64-server-fastdebug make test
TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
TEST_VM_OPTS="-XX:+UseParallelGC"
test ObjectStreamClassCaching.testCach
> Simplify code with `String.join()`
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8290300: Remove unused piece of code in formatList()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9513/files
- new: https:/
On Fri, 15 Jul 2022 12:25:07 GMT, Jim Laskey wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8290300: Remove unused piece of code in formatList()
>
> LGTM, however are there tests that ensure the changes are beni
> Simplify code with `String.join()`
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8290300: Remove unused import
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9513/files
- new: https://git.openjdk.org/jdk/pu
> This commit guards uses of Files methods returning path streams in
> java.base to use try-with-resources.
Ryan Ernst has updated the pull request incrementally with one additional
commit since the last revision:
fix compile and address more feedback
-
Changes:
- all: https://
This commit adds additional clarification to the javadocs of
ModuleReader::list about needing to close the stream. The new wording is
similar to that used in Files::find and other similar methods.
-
Commit messages:
- 8290353: Clarify the streams returned by ModuleReader::list
Chang
Until [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059) is solved, I'd
like to disable
- java/foreign/TestUpcallAsync.java
- java/foreign/enablenativeaccess/TestEnableNativeAccess.java
on muslc to take load from our CIs.
Tests: tested locally that the tests are excluded on Alpine, and
On Thu, 16 Jun 2022 08:08:15 GMT, Aleksey Shipilev wrote:
> Test appears to pass fine with G1. But it fails with other GCs, for example
> Parallel, Shenandoah, etc, it fails:
>
>
> $ CONF=linux-x86_64-server-fastdebug make test
> TEST=java/io/ObjectStreamClass/ObjectStreamClassCaching.java
>
On Fri, 15 Jul 2022 18:41:09 GMT, Eric Caspole wrote:
> Adds Warmup, Measurement and Fork annotations to reduce the run time from 1
> day 16 hours to 8 hours for this set.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9523
On Mon, 18 Jul 2022 14:06:00 GMT, Ryan Ernst wrote:
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
src/java.base/share/classes/java/lang/mod
On Mon, 18 Jul 2022 14:06:00 GMT, Ryan Ernst wrote:
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
Given the recommendation to close streams
On Fri, 15 Jul 2022 18:41:09 GMT, Eric Caspole wrote:
> Adds Warmup, Measurement and Fork annotations to reduce the run time from 1
> day 16 hours to 8 hours for this set.
LGTM, some suggestions inline that you can choose to ignore
test/micro/org/openjdk/bench/java/util/ArraysFill.java line 48
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote:
> Please review these changes to the nroff manpage files so that they match
> their markdown sources that Oracle maintains.
>
> All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022
> if needed. Additionally:
>
> T
On Mon, 18 Jul 2022 14:02:47 GMT, Ryan Ernst wrote:
>> This commit guards uses of Files methods returning path streams in
>> java.base to use try-with-resources.
>
> Ryan Ernst has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix compile and
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote:
> Please review these changes to the nroff manpage files so that they match
> their markdown sources that Oracle maintains.
>
> All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022
> if needed. Additionally:
>
> T
On Fri, 15 Jul 2022 16:18:17 GMT, Ryan Ernst wrote:
> This commit adds try-with-resources for uses of Stream from Files
> methods that walk directories.
Changes requested by chegar (Reviewer).
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 834:
> 832:
On Mon, 18 Jul 2022 04:14:03 GMT, Ioi Lam wrote:
>> Since the impact of this bug can be big, and the fix is simple and low risk
>> (just avoids doing optimizations), I'd like to put this into JDK 19 before
>> RDP2 (Jul 21).
>>
>> CDS cannot handle Lambda proxy classes that are generated in the
On Mon, 18 Jul 2022 11:08:24 GMT, Сергей Цыпанов wrote:
> For `Locale` all the call sites of `formatList()` never pass null, so the
> code in `if` block is never executed. I think we can delete this unused parts
> of the code in `Locale`,
Are you sure about this? `pattern` is derived from
`Lo
> Adds Warmup, Measurement and Fork annotations to reduce the run time from 1
> day 16 hours to 8 hours for this set.
Eric Caspole has updated the pull request incrementally with one additional
commit since the last revision:
Apply @cl4es comments
-
Changes:
- all: https://git
On Thu, 7 Jul 2022 10:21:06 GMT, Сергей Цыпанов wrote:
> We can skip bounds check and null check for Charset in case we use the array
> entirely and the Charset is either default one or proven to be non-null.
>
> Benchmark results:
>
> before
>
> Benchmark
On Mon, 18 Jul 2022 17:11:08 GMT, Eric Caspole wrote:
>> Adds Warmup, Measurement and Fork annotations to reduce the run time from 1
>> day 16 hours to 8 hours for this set.
>
> Eric Caspole has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> The `ProcessBuilder.pipelineStart()` implementation does not close all of the
> file descriptors it uses to create the pipeline of processes.
>
> The process calling `pipelineStart()` is creating the pipes between the
> stages.
> As each process is launched, the file descriptor is inherited by
On Fri, 8 Jul 2022 13:29:12 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits sin
On Mon, 18 Jul 2022 04:14:03 GMT, Ioi Lam wrote:
>> Since the impact of this bug can be big, and the fix is simple and low risk
>> (just avoids doing optimizations), I'd like to put this into JDK 19 before
>> RDP2 (Jul 21).
>>
>> CDS cannot handle Lambda proxy classes that are generated in the
On Mon, 18 Jul 2022 14:53:19 GMT, Chris Hegarty wrote:
>> This commit adds additional clarification to the javadocs of
>> ModuleReader::list about needing to close the stream. The new wording is
>> similar to that used in Files::find and other similar methods.
>
> src/java.base/share/classes/java
On Mon, 18 Jul 2022 14:06:00 GMT, Ryan Ernst wrote:
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
I relaxed the wording in
[0b3ca18](https
> This commit adds try-with-resources for uses of Stream from Files
> methods that walk directories.
Ryan Ernst has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request c
On Mon, 18 Jul 2022 15:35:25 GMT, Chris Hegarty wrote:
>> Ryan Ernst has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
Ryan Ernst has updated the pull request incrementally with two additional
commits since the la
> Simplify code with `String.join()`
Сергей Цыпанов has updated the pull request incrementally with one additional
commit since the last revision:
8290300: Revert erroneous changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9513/files
- new: https://git.openjdk.org/jd
On Mon, 18 Jul 2022 11:31:59 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Remove unused import
Right, my bad. I've confused arguments. The chan
> Since the impact of this bug can be big, and the fix is simple and low risk
> (just avoids doing optimizations), I'd like to put this into JDK 19 before
> RDP2 (Jul 21).
>
> CDS cannot handle Lambda proxy classes that are generated in the
> useImplMethodHandle mode. This could happen with cla
On Mon, 18 Jul 2022 16:15:26 GMT, Calvin Cheung wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed typo
>
> test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java
> line 41:
>
On Mon, 18 Jul 2022 17:56:23 GMT, Mandy Chung wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed typo
>
> test/hotspot/jtreg/runtime/cds/appcds/test-classes/pkg1/BaseWithProtectedMethod.java
> line 29:
>
>> 27: pub
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Revert erroneous changes
Marked as reviewed by naoto (Reviewer).
---
> Since the impact of this bug can be big, and the fix is simple and low risk
> (just avoids doing optimizations), I'd like to put this into JDK 19 before
> RDP2 (Jul 21).
>
> CDS cannot handle Lambda proxy classes that are generated in the
> useImplMethodHandle mode. This could happen with cla
On Mon, 18 Jul 2022 18:40:51 GMT, Сергей Цыпанов wrote:
>> Simplify code with `String.join()`
>
> Сергей Цыпанов has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8290300: Revert erroneous changes
Marked as reviewed by rriggs (Reviewer).
--
On Mon, 18 Jul 2022 18:19:48 GMT, Ryan Ernst wrote:
>> This commit adds additional clarification to the javadocs of
>> ModuleReader::list about needing to close the stream. The new wording is
>> similar to that used in Files::find and other similar methods.
>
> Ryan Ernst has updated the pull req
On Mon, 18 Jul 2022 19:01:28 GMT, Ioi Lam wrote:
>> Since the impact of this bug can be big, and the fix is simple and low risk
>> (just avoids doing optimizations), I'd like to put this into JDK 19 before
>> RDP2 (Jul 21).
>>
>> CDS cannot handle Lambda proxy classes that are generated in the
> Initial implementation.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Add NaN test.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9422/files
- new: https://git.openjdk.org/jdk/pull/9422/files/420a9f3f..a30daf2f
On Mon, 18 Jul 2022 20:30:21 GMT, Joe Darcy wrote:
>> Initial implementation.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add NaN test.
I added NaN round-trip tests is a separate file since the properties being
testing a
On Sat, 16 Jul 2022 22:08:12 GMT, Alexey Semenyuk wrote:
>> 8283707: Support version format on Windows
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Comments fixed and better naming in the code.
Marked as reviewed by
On Sat, 16 Jul 2022 21:22:46 GMT, Alexey Semenyuk wrote:
> 8290398: jpackage exe instellers are not installed in jtreg tests
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9530
On Sat, 16 Jul 2022 21:32:07 GMT, Alexey Semenyuk wrote:
> 8290400: Must run exe installers in jpackage jtreg tests without UI
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9531
On Sat, 16 Jul 2022 21:47:43 GMT, Alexey Semenyuk wrote:
> 8290402: jpackage exe uninstallers don't return correct exit code in case of
> failure
src/jdk.jpackage/windows/native/msiwrapper/MsiWrapper.cpp line 53:
> 51:
> 52: // Uninstall product.
> 53: msi::SuppressUI suppress
On Mon, 18 Jul 2022 14:21:19 GMT, Thomas Stuefe wrote:
> Until [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059) is solved,
> I'd like to disable
>
> - java/foreign/TestUpcallAsync.java
> - java/foreign/enablenativeaccess/TestEnableNativeAccess.java
>
> on muslc to take load from our
When running with -Xcomp it seems the wait time for GC to clear references is
insufficient.
Extend timeout waiting for GC.
-
Commit messages:
- 8290397: LoadLibraryUnload.java failed with "Too few cleared WeakReferences"
Changes: https://git.openjdk.org/jdk/pull/9545/files
Webrev
It is proposed to introduce support for `--win-codepage` argument, and
substitute the `Codepage` attribute with `--win-codepage` specified value in
primary l10n file when it is being copied to the config dir.
Instead of copying all internal l10n files, it is proposed to copy only the
primary fi
On Mon, 18 Jul 2022 22:01:09 GMT, Alexander Matveev
wrote:
>> 8290402: jpackage exe uninstallers don't return correct exit code in case of
>> failure
>
> src/jdk.jpackage/windows/native/msiwrapper/MsiWrapper.cpp line 53:
>
>> 51:
>> 52: // Uninstall product.
>> 53: msi::Suppre
On Mon, 18 Jul 2022 22:33:15 GMT, Alex Kasko wrote:
> It is proposed to introduce support for `--win-codepage` argument, and
> substitute the `Codepage` attribute with `--win-codepage` specified value in
> primary l10n file when it is being copied to the config dir.
>
> Instead of copying all
On Mon, 18 Jul 2022 15:26:23 GMT, Jonathan Gibbons wrote:
>> Please review these changes to the nroff manpage files so that they match
>> their markdown sources that Oracle maintains.
>>
>> All pages at a minimum have 19-ea replaced with 19, and copyright set to
>> 2022 if needed. Additionall
On Sat, 16 Jul 2022 21:47:43 GMT, Alexey Semenyuk wrote:
> 8290402: jpackage exe uninstallers don't return correct exit code in case of
> failure
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9532
On Mon, 18 Jul 2022 22:31:13 GMT, Roger Riggs wrote:
> When running with -Xcomp it seems the wait time for GC to clear references
> is insufficient.
> Extend timeout waiting for GC.
For timeout factor = 10, it will wait for 300 seconds which seem okay.
-
Marked as reviewed by mch
On Mon, 18 Jul 2022 03:41:45 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed tier4 failure with hotspot_appcds_dynamic testing
>
> Looks good!
>
> Thanks.
Thanks @dholmes-ora, @calvinccheung, @
On Mon, 18 Jul 2022 03:15:02 GMT, Ioi Lam wrote:
> Since the impact of this bug can be big, and the fix is simple and low risk
> (just avoids doing optimizations), I'd like to put this into JDK 19 before
> RDP2 (Jul 21).
>
> CDS cannot handle Lambda proxy classes that are generated in the
> u
On Mon, 18 Jul 2022 14:21:19 GMT, Thomas Stuefe wrote:
> Until [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059) is solved,
> I'd like to disable
>
> - java/foreign/TestUpcallAsync.java
> - java/foreign/enablenativeaccess/TestEnableNativeAccess.java
>
> on muslc to take load from our
On Fri, 8 Jul 2022 12:10:29 GMT, Jaikiran Pai wrote:
>> I removed a section of via JDK_JAVA_OPTIONS because including main class is
>> not allowed in the specification.
>> This behavior is added in JDK-8170832, which add JAVA_OPTIONS environment
>> variable. At this time, this test is mismatch
59 matches
Mail list logo
