Re: RFR: 8290489: Initial nroff manpage generation for JDK 20

2022-07-20 Thread David Holmes
On Thu, 21 Jul 2022 01:03:46 GMT, Daniel D. Daugherty wrote: >> The version will be 20-ea and the copyright year 2023 (for March 2023 >> release date). >> >> Thanks. > > Thumbs up. This is a trivial change. Thanks @dcubed-ojdk ! - PR: https://git.openjdk.org/jdk/pull/9581

Re: RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v4]

2022-07-20 Thread Jaikiran Pai
On Wed, 20 Jul 2022 20:57:05 GMT, Ryan Ernst wrote: >> This commit adds additional clarification to the javadocs of >> ModuleReader::list about needing to close the stream. The new wording is >> similar to that used in Files::find and other similar methods. > > Ryan Ernst has updated the pull

Re: RFR: 8205592: BigDecimal.doubleValue() is depressingly slow

2022-07-20 Thread Julian Waters
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote: > A reimplementation of `BigDecimal.[double|float]Value()` to enhance > performance, avoiding an intermediate string and its subsequent parsing on > the slow path. Impressive performance improvements, I also like the PR title :P

Re: RFR: JDK-8277095 : Empty streams create too many objects [v2]

2022-07-20 Thread John R Rose
On Tue, 16 Nov 2021 20:53:26 GMT, kabutz wrote: >> This is a draft proposal for how we could improve stream performance for the >> case where the streams are empty. Empty collections are common-place. If we >> iterate over them with an Iterator, we would have to create one small >> Iterator

Re: RFR: 8290489: Initial nroff manpage generation for JDK 20

2022-07-20 Thread Daniel D . Daugherty
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote: > The version will be 20-ea and the copyright year 2023 (for March 2023 release > date). > > Thanks. Thumbs up. This is a trivial change. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.org/jdk/pull/9581

RFR: 8290489: Initial nroff manpage generation for JDK 20

2022-07-20 Thread David Holmes
The version will be 20-ea and the copyright year 2023 (for March 2023 release date). Thanks. - Commit messages: - 8290489: Initial nroff manpage generation for JDK 20 Changes: https://git.openjdk.org/jdk/pull/9581/files Webrev: https://webrevs.openjdk.org/?repo=jdk=9581=00

Withdrawn: 8279986: methods Math::asXExact for safely checked primitive casts

2022-07-20 Thread duke
On Thu, 5 May 2022 10:11:05 GMT, Raffaello Giulietti wrote: > Add a family of "safe" cast methods. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/8548

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v7]

2022-07-20 Thread Brian Burkhalter
> Modify native multi-byte read-write code used by the `java.io` classes to > limit the size of the allocated native buffer thereby decreasing off-heap > memory footprint and increasing throughput. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase.

Integrated: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. This pull request has now been integrated. Changeset: 9c19d89c Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/9c19d89c9c564e436732c5f7851f4960fb5d783c Stats: 504 lines in

Re: RFR: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. Mach5 Tier1 passed. - PR: https://git.openjdk.org/jdk/pull/9578

RFR: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
Merge jdk19 -> jdk20. - Commit messages: - Merge - 8290625: Test jdk/javadoc/tool/CheckManPageOptions.java after manpage update - 8278274: Update nroff pages in JDK 19 before RC - 8287916: Address the inconsistency between the constant array and pool size - 8285407: Improve

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v14]

2022-07-20 Thread Brent Christian
> Please review this change to replace the finalizer in > `AbstractLdapNamingEnumeration` with a Cleaner. > > The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult > res`, and `LdapClient enumClnt`) are moved to a static inner class . From > there, the change is fairly

Re: RFR: 8290504: Close streams returned by ModuleReader::list [v3]

2022-07-20 Thread Ryan Ernst
> This commit ensures streams returned by ModuleReader::list are closed. Ryan Ernst has updated the pull request incrementally with one additional commit since the last revision: silly spaces - Changes: - all: https://git.openjdk.org/jdk/pull/9557/files - new:

Re: RFR: 8290504: Close streams returned by ModuleReader::list [v2]

2022-07-20 Thread Petr Portnov | PROgrm_JARvis
On Wed, 20 Jul 2022 20:58:55 GMT, Ryan Ernst wrote: >> This commit ensures streams returned by ModuleReader::list are closed. > > Ryan Ernst has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by

Re: RFR: 8290504: Close streams returned by ModuleReader::list [v2]

2022-07-20 Thread Ryan Ernst
On Wed, 20 Jul 2022 20:17:27 GMT, Mandy Chung wrote: >> test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java line >> 411: >> >>> 409: try (ModuleReader reader = mref.open(); >>> 410: Stream stream = reader.list()) { >>> 411: return stream >> >>

Re: RFR: 8290504: Close streams returned by ModuleReader::list [v2]

2022-07-20 Thread Ryan Ernst
> This commit ensures streams returned by ModuleReader::list are closed. Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional

Re: RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v4]

2022-07-20 Thread Ryan Ernst
> This commit adds additional clarification to the javadocs of > ModuleReader::list about needing to close the stream. The new wording is > similar to that used in Files::find and other similar methods. Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase.

Re: RFR: 8290504: Close streams returned by ModuleReader::list

2022-07-20 Thread Mandy Chung
On Wed, 20 Jul 2022 08:14:39 GMT, Chris Hegarty wrote: >> This commit ensures streams returned by ModuleReader::list are closed. > > test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java line 411: > >> 409: try (ModuleReader reader = mref.open(); >> 410:

Re: RFR: 8288723: Avoid redundant ConcurrentHashMap.get call in java.time [v4]

2022-07-20 Thread Roger Riggs
On Wed, 20 Jul 2022 11:19:07 GMT, Andrey Turbanov wrote: >> Instead of separate ConcurrentHashMap.get call, we can use result of >> previous putIfAbsent call. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8288723:

Re: RFR: 8288723: Avoid redundant ConcurrentHashMap.get call in java.time [v2]

2022-07-20 Thread Attila Szegedi
On Wed, 20 Jul 2022 11:19:11 GMT, Andrey Turbanov wrote: >> The comment was about WeekFields.of(), I misplaced the comment. >> >> @szegedi All good points about modernizing code... >> One of the reasons to ask about specific performance data is to validate the >> general performance impact of

Re: RFR: 8288723: Avoid redundant ConcurrentHashMap.get call in java.time [v4]

2022-07-20 Thread Attila Szegedi
On Wed, 20 Jul 2022 11:19:07 GMT, Andrey Turbanov wrote: >> Instead of separate ConcurrentHashMap.get call, we can use result of >> previous putIfAbsent call. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8288723:

Re: RFR: 8290471: jpackage: allow to specify codepage on Windows

2022-07-20 Thread Alex Kasko
On Mon, 18 Jul 2022 22:33:15 GMT, Alex Kasko wrote: > It is proposed to introduce support for `--win-codepage` argument, and > substitute the `Codepage` attribute with `--win-codepage` specified value in > primary l10n file when it is being copied to the config dir. > > Instead of copying all

Re: RFR: 8290471: jpackage: allow to specify codepage on Windows [v2]

2022-07-20 Thread Alex Kasko
> It is proposed to introduce support for `--win-codepage` argument, and > substitute the `Codepage` attribute with `--win-codepage` specified value in > primary l10n file when it is being copied to the config dir. > > Instead of copying all internal l10n files, it is proposed to copy only the

Re: RFR: 8288723: Avoid redundant ConcurrentHashMap.get call in java.time [v2]

2022-07-20 Thread Andrey Turbanov
On Wed, 6 Jul 2022 14:11:39 GMT, Roger Riggs wrote: >> @RogerRiggs in my view, it's not about performance per se… I'll sometimes >> help along these kinds of small fix PRs (that are more likely than not >> driven by IntelliJ code refactoring suggestions) if I think they lead to >> more

Re: RFR: 8288723: Avoid redundant ConcurrentHashMap.get call in java.time [v4]

2022-07-20 Thread Andrey Turbanov
> Instead of separate ConcurrentHashMap.get call, we can use result of previous > putIfAbsent call. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8288723: Avoid redundant ConcurrentHashMap.get call in java.time revert

Re: RFR: 8290504: Close streams returned by ModuleReader::list

2022-07-20 Thread Chris Hegarty
On Tue, 19 Jul 2022 14:07:17 GMT, Ryan Ernst wrote: > This commit ensures streams returned by ModuleReader::list are closed. test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java line 411: > 409: try (ModuleReader reader = mref.open(); > 410: Stream stream =

Integrated: Merge jdk19

2022-07-20 Thread Jesper Wilhelmsson
On Tue, 19 Jul 2022 16:41:54 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: a3e07d95 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/a3e07d950ae752daf779607693c422a4c35924a6 Stats: 510 lines