On Mon, 15 Aug 2022 14:49:09 GMT, Alan Bateman wrote:
>>> > Shouldn't we throw a SkippedException in this case?
>>>
>>> It's the child VM that skips so throwing SkippedException would require
>>> special handling in the parent.
>>
>> Like this?
>>
>> diff --git
>> a/test/jdk/java/lang/Thread
On Mon, 15 Aug 2022 11:16:06 GMT, Aleksey Shipilev wrote:
> The affected file was added by
> [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059), and the code that
> fails the compilation is under `#ifdef _WIN32`, and it only (?) gets compiled
> for tests. Looks like we really need the
The affected file was added by
[JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059), and the code that
fails the compilation is under `#ifdef _WIN32`, and it only (?) gets compiled
for tests. Looks like we really need the "WINAPI" macro in the definition, so
that we match the stdcall. See
On Mon, 15 Aug 2022 11:16:06 GMT, Aleksey Shipilev wrote:
> The affected file was added by
> [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059), and the code that
> fails the compilation is under `#ifdef _WIN32`, and it only (?) gets compiled
> for tests. Looks like we really need the
We have a few reports that existing Weak* VarHandle tests are still flaky, for
example on large AArch64 machines or small RISC-V machines.
The flakiness is intrinsic to the nature of Weak* operations under tests, that
can spuriously fail. The last attempt to fix these was
[JDK-8155739](https://
On Tue, 16 Aug 2022 02:08:43 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8290041?
>>
>> As noted by the reporter, the current implementation is buggy since the
>> calculation can result in a different value
On Sat, 6 Aug 2022 08:08:43 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8290041?
>
> As noted by the reporter, the current implementation is buggy since the
> calculation can result in a different value of the
On Wed, 10 Aug 2022 09:18:01 GMT, Alan Bateman wrote:
> Change the test to use a custom scheduler so there is better control on when
> the carrier threads terminates. Also convert test to TestNG so that all test
> cases can be run in the context of a virtual thread.
test/jdk/jdk/internal/misc/
On Tue, 16 Aug 2022 06:26:24 GMT, Alan Bateman wrote:
>> Not sure about this one? `fill()` is specified to throw an `IOException` and
>> `EOFException` is an `IOException`. It probably depends on how you interpret
>> the current "*if an I/O error has occurred*" description in the throws
>> sec
On Tue, 16 Aug 2022 08:23:11 GMT, Aleksey Shipilev wrote:
> We have a few reports that existing Weak* VarHandle tests are still flaky,
> for example on large AArch64 machines or small RISC-V machines.
>
> The flakiness is intrinsic to the nature of Weak* operations under tests,
> that can spur
On Mon, 15 Aug 2022 20:23:16 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
On Mon, 15 Aug 2022 20:23:16 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
On Tue, 16 Aug 2022 09:15:03 GMT, Volker Simonis wrote:
> And what do we want to do about JDK 19?
It's not a P1 so I don't think it's a change for the RC builds. It is a
regression in 19 so we will need to create a RN-KnownIssue release note (I will
do that).
I agree with Lance's suggestion
On Tue, 16 Aug 2022 09:06:31 GMT, Peter Levart wrote:
>> Change the test to use a custom scheduler so there is better control on when
>> the carrier threads terminates. Also convert test to TestNG so that all test
>> cases can be run in the context of a virtual thread.
>
> test/jdk/jdk/internal
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
> Second attempt at resolving
> [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less
> intrusive approach this time
>
> Side note: While it might be preferred to remove this entirely, other areas
> of the JDK also use the same flawed logic, and removing this would simply
> p
On Tue, 16 Aug 2022 08:23:11 GMT, Aleksey Shipilev wrote:
> We have a few reports that existing Weak* VarHandle tests are still flaky,
> for example on large AArch64 machines or small RISC-V machines.
>
> The flakiness is intrinsic to the nature of Weak* operations under tests,
> that can spur
> Change the test to use a custom scheduler so there is better control on when
> the carrier threads terminates. Also convert test to TestNG so that all test
> cases can be run in the context of a virtual thread.
Alan Bateman has updated the pull request incrementally with two additional
commit
On Tue, 16 Aug 2022 09:41:07 GMT, Alan Bateman wrote:
>> Volker Simonis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor changes regarding indentation, naming and spelling
>
> test/jdk/java/util/zip/InflaterInputStream/UnexpectedEnd
On Tue, 16 Aug 2022 11:12:35 GMT, Alan Bateman wrote:
>> Change the test to use a custom scheduler so there is better control on when
>> the carrier threads terminates. Also convert test to TestNG so that all test
>> cases can be run in the context of a virtual thread.
>
> Alan Bateman has upda
> These changes reduce the default run time from about 1 day 22 hours to about
> 6 hours with good stability we can use in weekly testing.
Eric Caspole has updated the pull request incrementally with one additional
commit since the last revision:
Clean up imports and shorten run time preservi
On Tue, 16 Aug 2022 14:35:14 GMT, Eric Caspole wrote:
>> These changes reduce the default run time from about 1 day 22 hours to about
>> 6 hours with good stability we can use in weekly testing.
>
> Eric Caspole has updated the pull request incrementally with one additional
> commit since the l
On Wed, 10 Aug 2022 01:54:56 GMT, Joe Darcy wrote:
>> JDK-8289106: Add model of class file versions to core reflection
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/
I noticed that current VarHandle/Unsafe test cases do not test the
always-failing cases. Strong CASes do test both always-success and
always-failing scenarios, while weak CASes only test spurious-failure tests. We
should be also testing always-failing cases for these. Weak CAS can spuriously
fa
> We have a few reports that existing Weak* VarHandle tests are still flaky,
> for example on large AArch64 machines or small RISC-V machines.
>
> The flakiness is intrinsic to the nature of Weak* operations under tests,
> that can spuriously fail. The last attempt to fix these was
> [JDK-81557
On Tue, 16 Aug 2022 15:06:50 GMT, Aleksey Shipilev wrote:
> I noticed that current VarHandle/Unsafe test cases do not test the
> always-failing cases. Strong CASes do test both always-success and
> always-failing scenarios, while weak CASes only test spurious-failure tests.
> We should be also
On Mon, 15 Aug 2022 14:34:58 GMT, Roger Riggs wrote:
>> Eric Caspole has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up imports and shorten run time preserving result stability
>
> test/micro/org/openjdk/bench/java/util/stream/ops/
On Tue, 16 Aug 2022 15:48:15 GMT, Aleksey Shipilev wrote:
>> We have a few reports that existing Weak* VarHandle tests are still flaky,
>> for example on large AArch64 machines or small RISC-V machines.
>>
>> The flakiness is intrinsic to the nature of Weak* operations under tests,
>> that can
On Fri, 5 Aug 2022 21:58:40 GMT, Vladimir Kozlov wrote:
> Please add JMH microbenchmark and show results.
Also please update the unit tests to run with and without the intrinsics
enabled.
-
PR: https://git.openjdk.org/jdk/pull/9781
On Thu, 11 Aug 2022 20:09:06 GMT, Daniel D. Daugherty
wrote:
> Split the java/util/stream/SpinedBufferTest.java test into two parts:
> - java/util/stream/SpinedBufferTest1.java has the first 6 test cases
> - java/util/stream/SpinedBufferTes2.java has the second 6 test cases
>
> I couldn't figur
> The problem is that after
> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
> unconditionally (and before calling `Inflater::inflate()`) in
> `InflaterInputStream::read()` if `Inflater::needsInput()` is true. This
> misses the case where the native inflater has con
On Tue, 16 Aug 2022 11:25:03 GMT, Volker Simonis wrote:
>> test/jdk/java/util/zip/InflaterInputStream/UnexpectedEndOfZlibStream.java
>> line 48:
>>
>>> 46: };
>>> 47: String deflated = "@ObjectiveCName(\"DYNSApi\")\npackage
>>> com.google.apps.dynamite.v1.shared.api;\n\n"+
>>>
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
`jdk.compiler` and `jdk.javadoc` changes look OK
-
Marked as reviewed by jjg (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9445
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
Those `.properties` bundle changes look good.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9445
On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote:
>> Please review this change to the cgroup v1 subsystem which makes it more
>> resilient on some of the stranger systems. Unfortunately, I wasn't able to
>> re-create a similar system as the reporter. The idea of using the longest
>> sub
On Tue, 16 Aug 2022 17:31:33 GMT, Volker Simonis wrote:
>> First of all I just realized that `deflated` is the wrong name, it should
>> actually be `inflated`.
>>
>> The deflated source (in `bytes`) is the payload which triggers the bug and I
>> can't simply change the string to which it decom
On Tue, 16 Aug 2022 14:40:41 GMT, Roger Riggs wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 18 additional commits
>> since
On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote:
> 8289562: Change bugs.java.com and bugreport.java.com URL's to https
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9445
> JDK-8289106: Add model of class file versions to core reflection
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 20 additional commits since
On Mon, 27 Jun 2022 20:26:52 GMT, Joe Darcy wrote:
> JDK-8289106: Add model of class file versions to core reflection
This pull request has now been integrated.
Changeset: e44e3f0c
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/e44e3f0c1976a513c6637545f49f49de84cbac02
Stat
On Tue, 16 Aug 2022 17:34:58 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
On Thu, 11 Aug 2022 20:09:06 GMT, Daniel D. Daugherty
wrote:
> Split the java/util/stream/SpinedBufferTest.java test into two parts:
> - java/util/stream/SpinedBufferTest1.java has the first 6 test cases
> - java/util/stream/SpinedBufferTes2.java has the second 6 test cases
>
> I couldn't figur
On Tue, 16 Aug 2022 14:35:14 GMT, Eric Caspole wrote:
>> These changes reduce the default run time from about 1 day 22 hours to about
>> 6 hours with good stability we can use in weekly testing.
>
> Eric Caspole has updated the pull request incrementally with one additional
> commit since the l
On Tue, 16 Aug 2022 09:53:54 GMT, Alan Bateman wrote:
>> I've updated the link in the description (sorry, copy-paste error) and
>> opened a [JBS issue for
>> `fill()`](https://bugs.openjdk.org/browse/JDK-8292427).
>>
>> What else is needed to push this to HEAD?
>>
>> And what do we want to do
On Tue, 16 Aug 2022 17:34:58 GMT, Volker Simonis wrote:
>> The problem is that after
>> [JDK-8281962](https://bugs.openjdk.org/browse/JDK-8281962) we call `fill()`
>> unconditionally (and before calling `Inflater::inflate()`) in
>> `InflaterInputStream::read()` if `Inflater::needsInput()` is t
Trivial fixes to ProblemList two different tests.
-
Commit messages:
- 8292510: ProblemList runtime/cds/appcds/cacheObject/ArchivedEnumTest.java
- 8292509: ProblemList java/lang/invoke/lambda/LogGeneratedClassesTest.java on
windows
Changes: https://git.openjdk.org/jdk/pull/9894/fi
On Tue, 16 Aug 2022 22:43:39 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to ProblemList two different tests.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9894
On Tue, 16 Aug 2022 22:47:12 GMT, Joe Darcy wrote:
>> Trivial fixes to ProblemList two different tests.
>
> Marked as reviewed by darcy (Reviewer).
@jddarcy - Thanks for the fast review. I'm now waiting for the bots to catch
up...
-
PR: https://git.openjdk.org/jdk/pull/9894
On Tue, 16 Aug 2022 22:43:39 GMT, Daniel D. Daugherty
wrote:
> Trivial fixes to ProblemList two different tests.
This pull request has now been integrated.
Changeset: da477b13
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk/commit/da477b13661b39e1f48b674f7fd9ea1d26521fc
On Sun, 19 Jun 2022 23:38:36 GMT, Chris Hennick wrote:
>> This PR improves both the performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra
50 matches
Mail list logo
