On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
JDK20 has Random.from(RandomGenerator) which could be used to do something like
Collections.shuffle(List, Random.from(rg)).
List.shuffle(RandomGenerator ) would allow for more efficient
CopyOnWriteArrayList shuffle.
Jason
From: core-libs-dev on behalf
This JavaDoc change attempts to shine some light on the `combiner`-function as
it relates to the third variant of `Stream.reduce` since it according to the
bug submission in JBS can be confusing that the `combiner` is not mentioned in
the code example in the documentation.
-
On Fri, 26 Aug 2022 15:48:55 GMT, Lance Andersen wrote:
> Please review this PR which updates the JarInputStream class description to
> clarify when the Manifest is accessible via JarInputStream::getManifest and
> JarInputStream::get[Jar]Entry.
>
> It is worth noting that with this update,
On Fri, 23 Sep 2022 17:45:26 GMT, Sean Mullan wrote:
> Do you also want to say "Otherwise, the method returns `null`."
The method description has that already, it might be too much detail to include
in the class description,.
-
PR: https://git.openjdk.org/jdk/pull/10045
On Tue, 20 Sep 2022 18:08:23 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
>> It is worth noting that with this
On Mon, 26 Sep 2022 19:12:16 GMT, Andrey Turbanov wrote:
> Found this redundant suppressions by IntelliJ IDEA inspection.
> Seems initially `Chronology` was generic class?
This pull request has now been integrated.
Changeset: 9309786d
Author:Andrey Turbanov
URL:
On Wed, 28 Sep 2022 09:45:32 GMT, KIRIYAMA Takuya wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windows API
>> WideCharToMultiByte()
>>
On Mon, 19 Sep 2022 08:51:24 GMT, Xiaohong Gong wrote:
> "`VectorSupport.indexVector()`" is used to compute a vector that contains the
> index values based on a given vector and a scale value (`i.e. index = vec +
> iota * scale`). This function is widely used in other APIs like
>
> 8289552: Make intrinsic conversions between bit representations of half
> precision values and floats
Smita Kamath has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comment to update test case
-
Changes:
- all:
On Wed, 28 Sep 2022 09:40:56 GMT, KIRIYAMA Takuya wrote:
> It is difficult to add all the encodings, so I will fix for Japanese and
> would like people who need other languages to do the same.
It would be good to have a comment in the source code describing that this
works only for Japanese
On Wed, 28 Sep 2022 12:52:02 GMT, Sean Coffey wrote:
>> Ok, just so I understand, you want to make sure that if JFR is started after
>> the security properties have already been read, then they are still
>> recorded, right?
>
> Correct - this type of event period (beginChunk) will fire once
> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
> values by identity. Updated API documentation of these two methods
> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Object,java.lang.Object)))
> to mention such behavior.
On Sun, 26 Dec 2021 17:30:41 GMT, Markus KARG wrote:
> Implementation of JDK-8279283
This pull request has now been integrated.
Changeset: 7515b304
Author:Markus Karg
Committer: Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/7515b304ca5598558424ea6ba90f2f71b36a8e4c
On Mon, 26 Sep 2022 21:35:26 GMT, Brian Burkhalter wrote:
>> @bplb Fixed the issues you pointed out. Kindly requesting approval. :-)
>
>> @bplb Fixed the issues you pointed out.
>
> @mkarg You are welcome.
> @bplb I would be very glad if you would `/sponsor` my PR. :-)
Done.
-
On Fri, 6 May 2022 22:05:35 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>>
That looks reasonable.
Thinking a little more broadly.
We could also change Collections.shuffle(List) to use ThreadLocalRandom so it
does not have to cache the Random instance, plus it has better concurrent and
PRNG properties. The spec does not describe the precise details of randomness.
On Wed, 28 Sep 2022 15:26:13 GMT, Alexey Ivanov wrote:
> The title says under `test/jdk/*`, yet there are lots of files changed in
> `src/*`.
The title was edited by someone other than me, as you can see from the PR
history.
-
PR: https://git.openjdk.org/jdk/pull/10029
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate
On Wed, 28 Sep 2022 14:45:54 GMT, Michael Ernst wrote:
>> Michael Ernst has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - Reinstate typos in Apache code that is copied into the JDK
>> - Merge ../jdk-openjdk
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate
On Wed, 28 Sep 2022 11:24:11 GMT, Aleksey Shipilev wrote:
> Problemlist-ing this tier2 test due to
> [JDK-8294519](https://bugs.openjdk.org/browse/JDK-8294519).
>
> Additional testing:
> - [x] Linux x86_64 fastdebug, test is now skipped
This pull request has now been integrated.
Changeset:
On Wed, 28 Sep 2022 11:24:11 GMT, Aleksey Shipilev wrote:
> Problemlist-ing this tier2 test due to
> [JDK-8294519](https://bugs.openjdk.org/browse/JDK-8294519).
>
> Additional testing:
> - [x] Linux x86_64 fastdebug, test is now skipped
Thanks, I am integrating to get clean `tier2`.
On Tue, 27 Sep 2022 12:14:23 GMT, Pavel Rappo wrote:
>> This adds exception documentation to JDK methods that would otherwise lose
>> that documentation once JDK-8287796 is integrated. While adding this
>> exception documentation now does not change [^1] the JDK API Documentation,
>> it will
On Wed, 28 Sep 2022 13:36:18 GMT, Daniel Fuchs wrote:
> If you can assert that the generated docs are the same before and after the
> proposed change then that's enough for me.
Would it suffice if I show the result of the diff between JDK API Documentation
built at the tip of this PR branch
On Wed, 28 Sep 2022 13:34:08 GMT, Daniel Fuchs wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert an extraneous change to jdk.javadoc
>
>
On Tue, 27 Sep 2022 12:14:23 GMT, Pavel Rappo wrote:
>> This adds exception documentation to JDK methods that would otherwise lose
>> that documentation once JDK-8287796 is integrated. While adding this
>> exception documentation now does not change [^1] the JDK API Documentation,
>> it will
On Tue, 27 Sep 2022 23:12:43 GMT, Michael Ernst wrote:
> Feel free to break up the pull request if that is what is needed to free it
> from red tape.
Only you can do that @mernst
-
PR: https://git.openjdk.org/jdk/pull/10029
On Wed, 28 Sep 2022 12:26:49 GMT, Sean Mullan wrote:
>> Yes - the thinking here is that since this is a one time event, we can have
>> it enabled. It's similar to the InitialSystemProperty event.
>>
>> We won't force loading of Security properties/class. We shouldn't at least.
>> If no
On Wed, 28 Sep 2022 11:24:11 GMT, Aleksey Shipilev wrote:
> Problemlist-ing this tier2 test due to
> [JDK-8294519](https://bugs.openjdk.org/browse/JDK-8294519).
>
> Additional testing:
> - [x] Linux x86_64 fastdebug, test is now skipped
Marked as reviewed by alanb (Reviewer).
-
On Wed, 28 Sep 2022 10:06:54 GMT, Sean Coffey wrote:
>> src/jdk.jfr/share/conf/jfr/default.jfc line 713:
>>
>>> 711:
>>> 712:
>>> 713: true
>>
>> The other security related events are not enabled by default. Is this one
>> enabled because it is only generated once? It seems it may
On Mon, 26 Sep 2022 15:47:51 GMT, Julian Waters wrote:
>> EDIT: Cave and add the ErrorOrigin enum, to differentiate which error type
>> the error reporting functions in libjava will look up. RUNTIME refers to
>> errors passed through the runtime via errno, and SYSTEM is for native errors
>>
Problemlist-ing this tier2 test due to
[JDK-8294519](https://bugs.openjdk.org/browse/JDK-8294519).
Additional testing:
- [x] Linux x86_64 fastdebug, test is now skipped
-
Commit messages:
- Fix
Changes: https://git.openjdk.org/jdk/pull/10465/files
Webrev:
On Wed, 28 Sep 2022 07:06:30 GMT, Jaikiran Pai wrote:
> Hello Sean,
>
> > Debug output is also now added for these properties via
> > -Djava.security.debug=properties
>
> Looking at the existing code upstream, it appears that the value `properties`
> is already recognized for
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
Null check on Properties
On Tue, 27 Sep 2022 20:29:31 GMT, Sean Mullan wrote:
>> New JFR event to record state of initial security properties.
>>
>> Debug output is also now added for these properties via
>> -Djava.security.debug=properties
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line
> This PR adds a new jlink plugin (`--save-jlink-argfiles=`) to
> support persisting jlink options.
>
>
>> echo "--add-modules jdk.internal.vm.ci --add-options=-Dfoo=xyzzy
>> --vendor-version="XyzzyVM 3.14.15" --vendor-bug-url=https://bugs.xyzzy.com/;
>> > my_image.argfile
>> export
On Mon, 26 Sep 2022 18:15:17 GMT, Dmitry Samersoff
wrote:
> If the user has set LD_LIBRARY_PATH to use a particular libjvm.so, options
> from the JDK_JAVA_OPTIONS environment variable are picked up twice.
>
> If an option cannot be accepted twice (e.g., -agentlib), the application
> fails to
On Wed, 14 Sep 2022 21:07:41 GMT, Naoto Sato wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windows API
>> WideCharToMultiByte()
>> from
> Could you please review the JDK-8293579 bug fixes?
>
> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to give
> the launcher the character which is encoded by Windows API
> WideCharToMultiByte()
> from UNICODE "é"(0x00e9) as an argument. However, this test fails
On Thu, 22 Sep 2022 10:22:40 GMT, Raffaello Giulietti
wrote:
>> Add support for named groups to java.util.regex.MatchResult
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8065554: MatchResult should provide values
On Fri, 16 Sep 2022 08:26:00 GMT, Matthias Baesken wrote:
> We noticed that with certain jar file input, jdeps runs into the following
> exception, this happens with jdk11, 17 and 20.
>
> jdeps.exe --multi-release 11 --module-path . --inverse --package
> com.sap.nw.performance.supa.client
On 28/09/2022 07:58, Andrey Turbanov wrote:
Hello.
IntelliJ IDEA highlights redundant warning suppressions for
Thread.getThreadGroup() calls in ThreadGroup calls.
All of them were added during Loom integration.
On Thu, 22 Sep 2022 15:57:56 GMT, Sean Coffey wrote:
> New JFR event to record state of initial security properties.
>
> Debug output is also now added for these properties via
> -Djava.security.debug=properties
Hello Sean,
> Debug output is also now added for these properties via
>
Hello.
IntelliJ IDEA highlights redundant warning suppressions for
Thread.getThreadGroup() calls in ThreadGroup calls.
All of them were added during Loom integration.
On Mon, 26 Sep 2022 21:35:26 GMT, Brian Burkhalter wrote:
>> @bplb Fixed the issues you pointed out. Kindly requesting approval. :-)
>
>> @bplb Fixed the issues you pointed out.
>
> @mkarg You are welcome.
@bplb I would be very glad if you would `/sponsor` my PR. :-)
-
PR:
46 matches
Mail list logo
