RFR: 8295205: Add jcheck whitespace checking for markdown files

2022-10-12 Thread Magnus Ihse Bursie
Markdown files are basically source code for documentation. It should have the same whitespace checks as all other source code, so we don't get spurious trailing whitespace changes. - Commit messages: - 8295205: Add jcheck whitespace checking for markdown files Changes: https://gi

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v2]

2022-10-12 Thread Tagir F . Valeev
On Tue, 11 Oct 2022 01:48:41 GMT, Stuart Marks wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove Random -> ThreadLocalRandom change > > test/jdk/java/util/Collections/Shuffle.java line 92: > >> 90:

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v2]

2022-10-12 Thread Tagir F . Valeev
On Tue, 11 Oct 2022 01:56:38 GMT, Stuart Marks wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove Random -> ThreadLocalRandom change > > test/jdk/java/util/Collections/Shuffle.java line 66: > >> 64:

Re: RFR: 8295205: Add jcheck whitespace checking for markdown files

2022-10-12 Thread Erik Joelsson
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote: > Markdown files are basically source code for documentation. It should have > the same whitespace checks as all other source code, so we don't get spurious > trailing whitespace changes. Thank you! Since I enabled visible whitespace

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v3]

2022-10-12 Thread Tagir F . Valeev
> Java 17 added RandomGenerator interface. However, existing method > Collections.shuffle accepts old java.util.Random class. While since Java 19, > it's possible to use Random.from(RandomGenerator) wrapper, it would be more > convenient to provide direct overload shuffle(List list, RandomGenera

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v2]

2022-10-12 Thread Tagir F . Valeev
On Tue, 11 Oct 2022 02:00:40 GMT, Stuart Marks wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove Random -> ThreadLocalRandom change > > src/java.base/share/classes/java/util/Collections.java line 485: > >>

Integrated: 8295205: Add jcheck whitespace checking for markdown files

2022-10-12 Thread Magnus Ihse Bursie
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote: > Markdown files are basically source code for documentation. It should have > the same whitespace checks as all other source code, so we don't get spurious > trailing whitespace changes. This pull request has now been integrated. Ch

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v4]

2022-10-12 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-12 Thread Naoto Sato
On Mon, 10 Oct 2022 23:23:00 GMT, Bill Huang wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains cha

RFR: 8294899: Process.waitFor() throws IllegalThreadStateException when a process on Windows returns an exit code of 259

2022-10-12 Thread Roger Riggs
Process.waitFor() throws IllegalThreadStateException when a process returns an exit code of 259. As described in the bug report, `waitFor()` should be sensitive to the exit value. Previously, it erroneously threw IllegalStateException. Added a test to verify. - Commit messages: - 8

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v3]

2022-10-12 Thread Bill Huang
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification whic

Integrated: JDK-8289509 : Improve test coverage for XPath Axes: descendant, descendant-or-self, following, following-sibling

2022-10-12 Thread Mahendra Chhipa
On Tue, 4 Oct 2022 13:01:40 GMT, Mahendra Chhipa wrote: > Added test cases for xpath Axis: > 1. descendant > 2. descendant-or-self > 3. following > 4. following-sibling This pull request has now been integrated. Changeset: 1961e81e Author:Mahendra Chhipa URL: https://git.openjdk.org

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v4]

2022-10-12 Thread Bill Huang
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification whic

RFR: 8295232: "java.locale.useOldISOCodes" property is read lazily

2022-10-12 Thread Naoto Sato
Fixed to utilize `StaticProperty` so that the system property value for `java.locale.useOldISOCodes` set on the command line is honored even with lazy `Locale` initialization. - Commit messages: - 8295232: "java.locale.useOldISOCodes" property is read lazily Changes: https://git.o

Re: RFR: 8295232: "java.locale.useOldISOCodes" property is read lazily

2022-10-12 Thread Lance Andersen
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote: > Fixed to utilize `StaticProperty` so that the system property value for > `java.locale.useOldISOCodes` set on the command line is honored even with > lazy `Locale` initialization. Marked as reviewed by lancea (Reviewer). - PR:

Re: RFR: 8295232: "java.locale.useOldISOCodes" property is read lazily

2022-10-12 Thread Brian Burkhalter
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote: > Fixed to utilize `StaticProperty` so that the system property value for > `java.locale.useOldISOCodes` set on the command line is honored even with > lazy `Locale` initialization. Marked as reviewed by bpb (Reviewer). - PR: ht

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v4]

2022-10-12 Thread Naoto Sato
On Wed, 12 Oct 2022 18:31:16 GMT, Bill Huang wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains cha

Re: RFR: 8295232: "java.locale.useOldISOCodes" property is read lazily

2022-10-12 Thread Iris Clark
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote: > Fixed to utilize `StaticProperty` so that the system property value for > `java.locale.useOldISOCodes` set on the command line is honored even with > lazy `Locale` initialization. Marked as reviewed by iris (Reviewer). - PR: h

Re: RFR: 8295232: "java.locale.useOldISOCodes" property is read lazily

2022-10-12 Thread Roger Riggs
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote: > Fixed to utilize `StaticProperty` so that the system property value for > `java.locale.useOldISOCodes` set on the command line is honored even with > lazy `Locale` initialization. Marked as reviewed by rriggs (Reviewer). - PR:

Integrated: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-12 Thread Bill Huang
On Mon, 10 Oct 2022 18:18:55 GMT, Bill Huang wrote: > The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes