Withdrawn: 8291915: jpackage: use multiple Features in MSI installer

2022-10-28 Thread duke
On Thu, 4 Aug 2022 17:00:38 GMT, Alex Kasko wrote: > This change splits existing single Feature `DefaultFeature` into 3 different > feautures: > > - `DefaultFeature_Files`: application and runtime files > - `DefaultFeature_Shortcuts`: application Desktop and Start Menu shortcuts > -

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-10-28 Thread Xue-Lei Andrew Fan
On Fri, 14 Oct 2022 21:49:07 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293412 I think it is a good clean up so that the default one get used in testing. - Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.org/jdk/pull/10716

Re: RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-10-28 Thread Mark Powers
On Fri, 14 Oct 2022 21:49:07 GMT, Mark Powers wrote: > https://bugs.openjdk.org/browse/JDK-8293412 No failures were noticed during mach5 and jtreg testing. - PR: https://git.openjdk.org/jdk/pull/10716

RFR: JDK-8293412 Remove unnecessary java.security.egd overrides

2022-10-28 Thread Mark Powers
https://bugs.openjdk.org/browse/JDK-8293412 - Commit messages: - Merge - second iteration - Merge - first iteration Changes: https://git.openjdk.org/jdk/pull/10716/files Webrev: https://webrevs.openjdk.org/?repo=jdk=10716=00 Issue: https://bugs.openjdk.org/browse/JDK-8293412

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread ExE Boss
On Fri, 28 Oct 2022 19:13:54 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update TemplateRuntime::combine > > src/java.base/share/classes/java/lang/template/StringTemplate.java line 323: > >>

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v3]

2022-10-28 Thread Brian Burkhalter
On Wed, 12 Oct 2022 13:26:29 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Re: [External] : Re: New candidate JEP: 431: Sequenced Collections

2022-10-28 Thread Stuart Marks
On 10/18/22 8:04 AM, fo...@univ-mlv.fr wrote: Introduction of new types always poses a dilemma for library maintainers. They can move forward aggressively and embrace new features, or they can remain on older releases in order to reach a broader audience. That's not a reason to avoid

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-28 Thread Jonathan Gibbons
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v4]

2022-10-28 Thread j3graham
On Fri, 28 Oct 2022 19:51:49 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v3]

2022-10-28 Thread Stuart Marks
On Wed, 12 Oct 2022 13:26:29 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java

2022-10-28 Thread Naoto Sato
On Fri, 28 Oct 2022 21:51:03 GMT, Justin Lu wrote: > Issue: Duplication of methods between Basic*.java test classes, due to auto > generation by genBasic.sh > > Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. > Toggled -nel flag for generation script

Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java

2022-10-28 Thread Brent Christian
On Fri, 28 Oct 2022 21:51:03 GMT, Justin Lu wrote: > Issue: Duplication of methods between Basic*.java test classes, due to auto > generation by genBasic.sh > > Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. > Toggled -nel flag for generation script

RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java

2022-10-28 Thread Justin Lu
Issue: Duplication of methods between Basic*.java test classes, due to auto generation by genBasic.sh Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. Toggled -nel flag for generation script (genBasic.sh) to remove excessive white space. Moved a previous direct

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops

2022-10-28 Thread Claes Redestad
On Tue, 25 Oct 2022 10:37:40 GMT, Claes Redestad wrote: > Continuing the work initiated by @luhenry to unroll and then intrinsify > polynomial hash loops. > > I've rewired the library changes to route via a single `@IntrinsicCandidate` > method. To make this work I've harmonized how they are

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops

2022-10-28 Thread Ludovic Henry
On Tue, 25 Oct 2022 10:37:40 GMT, Claes Redestad wrote: > Continuing the work initiated by @luhenry to unroll and then intrinsify > polynomial hash loops. > > I've rewired the library changes to route via a single `@IntrinsicCandidate` > method. To make this work I've harmonized how they are

RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops

2022-10-28 Thread Claes Redestad
Continuing the work initiated by @luhenry to unroll and then intrinsify polynomial hash loops. I've rewired the library changes to route via a single `@IntrinsicCandidate` method. To make this work I've harmonized how they are invoked so that there's less special handling and checks in the

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 20:01:41 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line >> 1042: >> >>> 1040: * The number of fragments must be one more that the number of >>> ptypes. >>> 1041: * The total number of slots used by the ptypes

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Jim Laskey
On Fri, 28 Oct 2022 18:52:28 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update TemplateRuntime::combine > > src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line > 1042: >

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 19:52:14 GMT, Rémi Forax wrote: >> There have been several requests to make it public in the past. You really >> can't use the methods in this class unless you know the value. Better to >> have the value exposed instead of developers transcribing the value into >> their

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Franz Wilhelmstötter
On Fri, 28 Oct 2022 19:21:56 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update TemplateRuntime::combine > > src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 211: > >>

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 19:51:21 GMT, Franz Wilhelmstötter wrote: >> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 211: >> >>> 209: @SuppressWarnings("unchecked") >>> 210: public static List toList(E... elements) { >>> 211: return

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 19:34:37 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line >> 118: >> >>> 116: * @since 20 >>> 117: */ >>> 118: public static final int MAX_INDY_CONCAT_ARG_SLOTS = 200; >> >> I do not think it's a good idea

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 17:57:30 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v4]

2022-10-28 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 17:57:30 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Jim Laskey
On Fri, 28 Oct 2022 18:45:05 GMT, Rémi Forax wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update TemplateRuntime::combine > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 32: > >> 30:

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]

2022-10-28 Thread Jim Laskey
On Fri, 28 Oct 2022 16:33:11 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move StringConcatItem to FormatConcatItem > >

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]

2022-10-28 Thread Jim Laskey
On Fri, 28 Oct 2022 16:33:31 GMT, Maurizio Cimadamore wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 4139: >> >>> 4137: List typeArguments = >>> interfaceType.getTypeArguments(); >>> 4138: >>> 4139: if (typeArguments.size() == 2) {

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 17:57:30 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 17:57:30 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 17:57:30 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Rémi Forax
On Fri, 28 Oct 2022 17:57:30 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]

2022-10-28 Thread Maurizio Cimadamore
On Fri, 28 Oct 2022 16:09:16 GMT, Maurizio Cimadamore wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move StringConcatItem to FormatConcatItem > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Maurizio Cimadamore
On Fri, 28 Oct 2022 17:57:30 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]

2022-10-28 Thread Maurizio Cimadamore
On Fri, 28 Oct 2022 14:55:28 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]

2022-10-28 Thread Jim Laskey
On Fri, 28 Oct 2022 16:09:51 GMT, j3graham wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move StringConcatItem to FormatConcatItem > > src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 365:

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v3]

2022-10-28 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation

Re: RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v16]

2022-10-28 Thread Brent Christian
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote: >> Please review this change to replace the finalizer in >> `AbstractLdapNamingEnumeration` with a Cleaner. >> >> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult >> res`, and `LdapClient enumClnt`) are moved to

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-28 Thread Joe Wang
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]

2022-10-28 Thread j3graham
On Fri, 28 Oct 2022 14:55:28 GMT, Jim Laskey wrote: >> Enhance the Java programming language with string templates, which are >> similar to string literals but contain embedded expressions. A string >> template is interpreted at run time by replacing each expression with the >> result of

Re: RFR: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds [v2]

2022-10-28 Thread Andrey Turbanov
On Fri, 28 Oct 2022 15:18:06 GMT, Brian Burkhalter wrote: >> Add `@throws IndexOutOfBoundsException {@inheritDoc}` to some >> `write(byte[],int,int)` and `read(byte[],int,int)` methods of some classes >> in the `java.io` package to make things a bit clearer. > > Brian Burkhalter has updated

Re: RFR: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds [v2]

2022-10-28 Thread Alan Bateman
On Fri, 28 Oct 2022 15:18:06 GMT, Brian Burkhalter wrote: >> Add `@throws IndexOutOfBoundsException {@inheritDoc}` to some >> `write(byte[],int,int)` and `read(byte[],int,int)` methods of some classes >> in the `java.io` package to make things a bit clearer. > > Brian Burkhalter has updated

Re: RFR: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds [v2]

2022-10-28 Thread Brian Burkhalter
On Fri, 28 Oct 2022 06:09:49 GMT, Andrey Turbanov wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8156593: Fix accidental edit > > src/java.base/share/classes/java/io/FileOutputStream.java line 346: > >> 344:

Re: RFR: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds [v2]

2022-10-28 Thread Brian Burkhalter
> Add `@throws IndexOutOfBoundsException {@inheritDoc}` to some > `write(byte[],int,int)` and `read(byte[],int,int)` methods of some classes in > the `java.io` package to make things a bit clearer. Brian Burkhalter has updated the pull request incrementally with one additional commit since the

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]

2022-10-28 Thread Jim Laskey
On Thu, 27 Oct 2022 21:21:52 GMT, ExE Boss wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move StringConcatItem to FormatConcatItem > > src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line >

Re: RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v2]

2022-10-28 Thread Jim Laskey
> Enhance the Java programming language with string templates, which are > similar to string literals but contain embedded expressions. A string > template is interpreted at run time by replacing each expression with the > result of evaluating that expression, possibly after further validation

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-28 Thread Daniel Fuchs
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` > to parse or construct any URL. > > The `java.net.URL` class does not itself encode or decode any URL components > according to the escaping mechanism defined in RFC2396. It is the > responsibility of the caller to

Re: RFR: 8295970: Add jdk_vector tests in GHA [v2]

2022-10-28 Thread Jie Fu
On Fri, 28 Oct 2022 13:41:28 GMT, Erik Joelsson wrote: > I think you need to add at least one other label than `build` to this now to > make sure the right people can have a say in the change. Done. Thanks @erikj79 . - PR: https://git.openjdk.org/jdk/pull/10879

Re: RFR: 8156593: DataOutput.write(byte[],int,int) and its implementations do not specify index out bounds

2022-10-28 Thread Andrey Turbanov
On Thu, 27 Oct 2022 20:35:26 GMT, Brian Burkhalter wrote: > Add `@throws IndexOutOfBoundsException {@inheritDoc}` to some > `write(byte[],int,int)` and `read(byte[],int,int)` methods of some classes in > the `java.io` package to make things a bit clearer.