Re: RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v4]

2022-11-25 Thread Mahendra Chhipa
On Sat, 5 Nov 2022 00:04:39 GMT, Bill Huang wrote: >> The current non local registry tests require a manual process that runs >> rmiregitrty on a different machine and changes the -Dregistry.host property >> in the source before running the tests on the local machine. This task is >> created t

Re: What is meant by "document context" in JEP 198?

2022-11-25 Thread Ethan McCue
That tracks. The component I, personally, might want JSON available internally for is an artifact resolution API [1]. Gradle's module metadata is out there in the world and could be worth consuming [2]. That's neither here nor there though. I'd say that the JEP as written could use some rework ev

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API

2022-11-25 Thread Adam Sotona
On Mon, 7 Nov 2022 13:01:41 GMT, Adam Sotona wrote: >> make/modules/java.base/Java.gmk line 37: >> >>> 35: >>> 36: EXCLUDES += java/lang/doc-files >>> 37: EXCLUDES += jdk/classfile/snippets >> >> I don't like hard-coded excludes like this. Is this the first real-world >> example of snippets i

Re: What is meant by "document context" in JEP 198?

2022-11-25 Thread Alan Bateman
On 25/11/2022 13:27, Ethan McCue wrote: ...huh >>The recent removal of Nashorn has indicated several places were >> javascript were used in the JDK mainly due to it's built-in support for >> parsing JSON//None of those seem like they would have been using nashorn in the past, so i wonder what t

Re: What is meant by "document context" in JEP 198?

2022-11-25 Thread Ethan McCue
...huh >> The recent removal of Nashorn has indicated several places were >> javascript were used in the JDK mainly due to it's built-in support for >> parsing JSON None of those seem like they would have been using nashorn in the past, so i wonder what this is referring to. On Fri, Nov 25, 202

Redundant condition in java.math.MutableBigInteger#divideMagnitude

2022-11-25 Thread Andrey Turbanov
Hello. I noticed that IntelliJ IDEA show warning in the method java.math.MutableBigInteger#divideMagnitude here - https://github.com/openjdk/jdk/blob/4f65570204e2d38415e7761bd81660b081eae882/src/java.base/share/classes/java/math/MutableBigInteger.java#L1536 It seems that condition is always 'true'