On Sat, 26 Nov 2022 18:42:39 GMT, Magnus Ihse Bursie wrote:
>> Unfortunately I found only two use cases of external snippets in JDK. One is
>> explicitly excluding the snippets package and the other does not care, so
>> the snippets are included.
>
> Is the practice of naming the directory `sni
On Wed, 23 Nov 2022 05:01:40 GMT, Ryan Ernst wrote:
> This commit guards thread modifications for the process reaper thread with
> doPrivileged.
This pull request has now been integrated.
Changeset: 50f9043c
Author:Ryan Ernst
Committer: Chris Hegarty
URL:
https://git.openjdk.org/j
On Sat, 26 Nov 2022 17:24:02 GMT, Alan Bateman wrote:
> Not important but can eliminate the casts from privilegedThreadSetXXX methods
> if you separate the creation of the PrivilegedAction from the doPriv call.
I chose to keep it as is since there was already another doPriv in the file
that us
On Fri, 25 Nov 2022 15:18:09 GMT, Adam Sotona wrote:
>> I'll fix it, thanks.
>
> Unfortunately I found only two use cases of external snippets in JDK. One is
> explicitly excluding the snippets package and the other does not care, so the
> snippets are included.
Is the practice of naming the d
On Sat, 26 Nov 2022 15:55:27 GMT, Ryan Ernst wrote:
>> This commit guards thread modifications for the process reaper thread with
>> doPrivileged.
>
> Ryan Ernst has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert factory method
This l
On Wed, 23 Nov 2022 16:02:37 GMT, Chris Hegarty wrote:
>> I would prefer to to avoid creating new factories when the desired function
>> can be done on the resulting thread.
>> Such as `setDaemon()` and `setName()`, etc.
>> It does avoid the doPriv in this case, but is not necessary and when the
On Sat, 26 Nov 2022 15:50:54 GMT, Ryan Ernst wrote:
>> This commit guards thread modifications for the process reaper thread with
>> doPrivileged.
>
> Ryan Ernst has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert factory method
LGTM
> This commit guards thread modifications for the process reaper thread with
> doPrivileged.
Ryan Ernst has updated the pull request incrementally with one additional
commit since the last revision:
Revert factory method
-
Changes:
- all: https://git.openjdk.org/jdk/pull/11309
> This commit guards thread modifications for the process reaper thread with
> doPrivileged.
Ryan Ernst has updated the pull request incrementally with two additional
commits since the last revision:
- Merge pull request #1 from ChrisHegarty/reaper_thread_modify
Add privileged helper me
On Wed, 16 Nov 2022 15:02:08 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the ConstantDesc class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
>
> Here is how it would look like:
>
> src="http
On Wed, 16 Nov 2022 16:17:01 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the CallSite class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
> Here is how it would look like:
>
> src="https://use
11 matches
Mail list logo
