[jdk20] RFR: 8298894: java/lang/Thread/virtual/stress/Skynet.java timed out and threw OutOfMemoryError

2022-12-19 Thread Alan Bateman
This test started timing out recently on macosx-x64 when testing debug builds with ZGC. The test needs more heap so that it doesn't fail with OOME. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jdk20/pull/54/files Webrev: https://webrevs.openjdk.org/?repo=jd

Re: [jdk20] RFR: 8298894: java/lang/Thread/virtual/stress/Skynet.java timed out and threw OutOfMemoryError

2022-12-19 Thread Erik Österlund
On Mon, 19 Dec 2022 14:24:28 GMT, Alan Bateman wrote: > This test started timing out recently on macosx-x64 when testing debug builds > with ZGC. The test needs more heap so that it doesn't fail with OOME. Looks good. - Marked as reviewed by eosterlund (Reviewer). PR: https://git

[jdk20] RFR: JDK-8277074: Qualified exported types show up in JavaDoc

2022-12-19 Thread Hannes Wallnöfer
This `noreg-doc` PR has been moved over from the mainline repository, the original PR is openjdk/jdk#11163. The purpose is to hide internal classes in generated documentation by adding doc comments containing a @hidden tag. I verified the fix by making sure the internal vector and event classe

Re: RFR: [DRAFT] 8294982: Implementation of Classfile API [v7]

2022-12-19 Thread Adam Sotona
On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote: >> **This pull request is not intended for immediate integration to JDK >> mainline.** >> >> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolida

Re: [jdk20] RFR: 8298894: java/lang/Thread/virtual/stress/Skynet.java timed out and threw OutOfMemoryError

2022-12-19 Thread Alan Bateman
On Mon, 19 Dec 2022 14:24:28 GMT, Alan Bateman wrote: > This test started timing out recently on macosx-x64 when testing debug builds > with ZGC. The test needs more heap so that it doesn't fail with OOME. Thanks Erik. - PR: https://git.openjdk.org/jdk20/pull/54

Re: [jdk20] RFR: JDK-8277074: Qualified exported types show up in JavaDoc

2022-12-19 Thread Paul Sandoz
On Mon, 19 Dec 2022 16:28:17 GMT, Hannes Wallnöfer wrote: > This `noreg-doc` PR has been moved over from the mainline repository, the > original PR is openjdk/jdk#11163. > > The purpose is to hide internal classes in generated documentation by adding > doc comments containing a @hidden tag. I

[jdk20] Integrated: 8298894: java/lang/Thread/virtual/stress/Skynet.java timed out and threw OutOfMemoryError

2022-12-19 Thread Alan Bateman
On Mon, 19 Dec 2022 14:24:28 GMT, Alan Bateman wrote: > This test started timing out recently on macosx-x64 when testing debug builds > with ZGC. The test needs more heap so that it doesn't fail with OOME. This pull request has now been integrated. Changeset: 2c69c41d Author:Alan Bateman

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v18]

2022-12-19 Thread iaroslavski
On Wed, 9 Nov 2022 21:06:50 GMT, iaroslavski wrote: >> Sorting: >> >> - adopt radix sort for sequential and parallel sorts on >> int/long/float/double arrays (almost random and length > 6K) >> - fix tryMergeRuns() to better handle case when the last run is a single >> element >> - minor javado

[jdk20] Integrated: JDK-8277074: Qualified exported types show up in JavaDoc

2022-12-19 Thread Hannes Wallnöfer
On Mon, 19 Dec 2022 16:28:17 GMT, Hannes Wallnöfer wrote: > This `noreg-doc` PR has been moved over from the mainline repository, the > original PR is openjdk/jdk#11163. > > The purpose is to hide internal classes in generated documentation by adding > doc comments containing a @hidden tag. I

[jdk20] RFR: 4958969: ObjectOutputStream example leads to non-working code

2022-12-19 Thread Roger Riggs
Update javadoc examples to use try-with-resources and use javadoc snippet tags. The examples in ObjectInputStream and ObjectOutputStream get an update with try-with-resources and use of javadoc snippet tags. ObjectInputFilter is updated with use of snippet tags instead of html markup.

Re: [jdk20] RFR: 4958969: ObjectOutputStream example leads to non-working code

2022-12-19 Thread Lance Andersen
On Mon, 19 Dec 2022 20:12:15 GMT, Roger Riggs wrote: > Update javadoc examples to use try-with-resources and use javadoc snippet > tags. > The examples in ObjectInputStream and ObjectOutputStream get an update with > try-with-resources and use of javadoc snippet tags. > ObjectInputFilter is upda

Re: [jdk20] RFR: 4958969: ObjectOutputStream example leads to non-working code

2022-12-19 Thread Roger Riggs
On Mon, 19 Dec 2022 20:22:22 GMT, Lance Andersen wrote: >> Update javadoc examples to use try-with-resources and use javadoc snippet >> tags. >> The examples in ObjectInputStream and ObjectOutputStream get an update with >> try-with-resources and use of javadoc snippet tags. >> ObjectInputFilter

Re: [jdk20] RFR: 4958969: ObjectOutputStream example leads to non-working code

2022-12-19 Thread Naoto Sato
On Mon, 19 Dec 2022 20:12:15 GMT, Roger Riggs wrote: > Update javadoc examples to use try-with-resources and use javadoc snippet > tags. > The examples in ObjectInputStream and ObjectOutputStream get an update with > try-with-resources and use of javadoc snippet tags. > ObjectInputFilter is upda

RFR: 8298971: Move Console implementation into jdk internal package

2022-12-19 Thread Naoto Sato
Moving the built-in implementation of `Console` from `java.io` package into `jdk.internal.io` package. It now implements `JdkConsole` interface and is accessed through `ProxyingConsole`. - Commit messages: - Split Console_md.c - 8298971: Move Console implementation into jdk intern

Re: [jdk20] RFR: 4958969: ObjectOutputStream example leads to non-working code [v2]

2022-12-19 Thread Roger Riggs
> Update javadoc examples to use try-with-resources and use javadoc snippet > tags. > The examples in ObjectInputStream and ObjectOutputStream get an update with > try-with-resources and use of javadoc snippet tags. > ObjectInputFilter is updated with use of snippet tags instead of html markup. R

Re: [jdk20] RFR: 4958969: ObjectOutputStream example leads to non-working code [v2]

2022-12-19 Thread Naoto Sato
On Mon, 19 Dec 2022 20:50:18 GMT, Roger Riggs wrote: >> Update javadoc examples to use try-with-resources and use javadoc snippet >> tags. >> The examples in ObjectInputStream and ObjectOutputStream get an update with >> try-with-resources and use of javadoc snippet tags. >> ObjectInputFilter is

Withdrawn: JDK-8277074: Qualified exported types show up in JavaDoc

2022-12-19 Thread Hannes Wallnöfer
On Tue, 15 Nov 2022 12:15:42 GMT, Hannes Wallnöfer wrote: > Please review a simple change to hide internal classes in generated > documentation by adding doc comments containing a `@hidden` tag. I verified > the fix by making sure `grep -r jdk.internal` returns no matches in the > generated do

[jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Daniel D . Daugherty
A trivial fix to slightly increase the default timeout so that java/lang/reflect/IllegalArgumentsTest.java passes with slowdebug bits. - Commit messages: - 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits Changes: https://git.openjdk.org/jdk20/pul

Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Iris Clark
On Mon, 19 Dec 2022 22:20:08 GMT, Daniel D. Daugherty wrote: > A trivial fix to slightly increase the default timeout so that > java/lang/reflect/IllegalArgumentsTest.java > passes with slowdebug bits. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk20/pul

Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Daniel D . Daugherty
On Mon, 19 Dec 2022 22:34:00 GMT, Iris Clark wrote: >> A trivial fix to slightly increase the default timeout so that >> java/lang/reflect/IllegalArgumentsTest.java >> passes with slowdebug bits. > > Marked as reviewed by iris (Reviewer). @irisclark - Thanks for the fast review. Do you agree th

Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Iris Clark
I agree that this is a trivial fix. Iris From: core-libs-dev on behalf of Daniel D.Daugherty Sent: Monday, December 19, 2022 2:46 PM To: core-libs-dev@openjdk.org ; hotspot-runtime-...@openjdk.org Subject: Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalAr

Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Iris Clark
On Mon, 19 Dec 2022 22:20:08 GMT, Daniel D. Daugherty wrote: > A trivial fix to slightly increase the default timeout so that > java/lang/reflect/IllegalArgumentsTest.java > passes with slowdebug bits. Trivial update approved. - Marked as reviewed by iris (Reviewer). PR: https:/

Re: [jdk20] RFR: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Daniel D . Daugherty
On Mon, 19 Dec 2022 23:03:54 GMT, Iris Clark wrote: >> A trivial fix to slightly increase the default timeout so that >> java/lang/reflect/IllegalArgumentsTest.java >> passes with slowdebug bits. > > Trivial update approved. @irisclark - Thanks! - PR: https://git.openjdk.org/jdk20

[jdk20] Integrated: 8298699: java/lang/reflect/IllegalArgumentsTest.java times out with slowdebug bits

2022-12-19 Thread Daniel D . Daugherty
On Mon, 19 Dec 2022 22:20:08 GMT, Daniel D. Daugherty wrote: > A trivial fix to slightly increase the default timeout so that > java/lang/reflect/IllegalArgumentsTest.java > passes with slowdebug bits. This pull request has now been integrated. Changeset: f07acfc1 Author:Daniel D. Daugher

[jdk20] Integrated: 4958969: ObjectOutputStream example leads to non-working code

2022-12-19 Thread Roger Riggs
On Mon, 19 Dec 2022 20:12:15 GMT, Roger Riggs wrote: > Update javadoc examples to use try-with-resources and use javadoc snippet > tags. > The examples in ObjectInputStream and ObjectOutputStream get an update with > try-with-resources and use of javadoc snippet tags. > ObjectInputFilter is upda