Re: RFR: 8293630: Simplify TreeMap.get() with Comparator.naturalOrder() [v5]

2022-12-22 Thread Sergey Tsypanov
> We can use `Comparator.naturalOrder()` for cases when a `TreeMap` instance is > constructed without comparator. This allows to squash two branches in > `TreeMap.get()` into one. > > P.S. I think the comment of `TreeMap.getEntryUsingComparator()` is outdated. > Should we also change it? Serge

Re: RFR: 8282664: Unroll by hand StringUTF16 and StringLatin1 polynomial hash loops [v13]

2022-12-22 Thread Claes Redestad
On Wed, 21 Dec 2022 00:11:34 GMT, Sandhya Viswanathan wrote: >> Passing the constant node through as an input as suggested by @iwanowww and >> @sviswa7 meant we could eliminate most of the `instruct` blocks, removing a >> significant chunk of code and a little bit of complexity from the propos

Integrated: JDK-8295087: Manual Test to Automated Test Conversion

2022-12-22 Thread Bill Huang
On Mon, 10 Oct 2022 21:39:05 GMT, Bill Huang wrote: > This task converts 5 manual tests to automated tests. > > sun/security/provider/PolicyParser/ExtDirsDefaultPolicy.java > sun/security/provider/PolicyParser/ExtDirsChange.java > sun/security/provider/PolicyParser/ExtDirs.java > java/securit

Re: RFR: 8299194: CustomTzIDCheckDST.java may fail at future date [v2]

2022-12-22 Thread Naoto Sato
On Wed, 21 Dec 2022 23:21:42 GMT, Ichiroh Takiguchi wrote: >> test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java may fail at future date. >> I used following standalone testcase >> >> import java.util.Calendar; >> import java.util.Date; >> import java.util.SimpleTimeZone; >> >> public class C

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2022-12-22 Thread Harshitha Onkar
> ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added > robot.setAutoWaitForIdle() to ViewportOverlapping and its base class > (OverlappingTestBase) to stabilize the test. > > Additionally added awt & swings tests to exclusiveAccess.dir in TEST.ROOT. Harshitha Onkar ha

RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Stuart Marks
This test isn't part of any test group, so it isn't being run regularly! I'm adding it to the jdk_util_other test group. - Commit messages: - Add jdk/internal/util to jdk_util_other test group Changes: https://git.openjdk.org/jdk/pull/11769/files Webrev: https://webrevs.openjdk.or

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Naoto Sato
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote: > This test isn't part of any test group, so it isn't being run regularly! I'm > adding it to the jdk_util_other test group. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11769

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Roger Riggs
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote: > This test isn't part of any test group, so it isn't being run regularly! I'm > adding it to the jdk_util_other test group. LGTM; Test fixes are ok for JDK 20 backport. - Marked as reviewed by rriggs (Reviewer). PR: https://

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Stuart Marks
On Thu, 22 Dec 2022 19:47:30 GMT, Roger Riggs wrote: >> This test isn't part of any test group, so it isn't being run regularly! I'm >> adding it to the jdk_util_other test group. > > LGTM; Test fixes are ok for JDK 20 backport. @RogerRiggs > LGTM; Test fixes are ok for JDK 20 backport. Than

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Roger Riggs
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote: > This test isn't part of any test group, so it isn't being run regularly! I'm > adding it to the jdk_util_other test group. Or you can push to 21 and then use the lightweight "/backport" command. - PR: https://git.openjdk.org/

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Stuart Marks
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote: > This test isn't part of any test group, so it isn't being run regularly! I'm > adding it to the jdk_util_other test group. OK, I guess I'll need to withdraw this PR and open a new one against JDK 20. - PR: https://git.openjdk

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Naoto Sato
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote: > This test isn't part of any test group, so it isn't being run regularly! I'm > adding it to the jdk_util_other test group. I think backporting should do in this case (and simpler) - PR: https://git.openjdk.org/jdk/pull/11769

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Roger Riggs
On Thu, 22 Dec 2022 19:49:42 GMT, Stuart Marks wrote: > Thanks. Do you think I should push this into JDK 20 instead of 21? Yes, if the test should be run (and has not been running) pushing to 20 will get it running sooner on the release that ships next. - PR: https://git.openjdk.o

Re: RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v2]

2022-12-22 Thread Serguei Spitsyn
On Wed, 23 Nov 2022 10:14:23 GMT, Serguei Spitsyn wrote: >> This problem has two sides. >> One is that the `VirtualThread::run() `cashes the field `notifyJvmtiEvents` >> value. >> It caused the native method `notifyJvmtiUnmountBegin()` not called after the >> field `notifyJvmtiEvents` >> value

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Stuart Marks
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote: > This test isn't part of any test group, so it isn't being run regularly! I'm > adding it to the jdk_util_other test group. Yeah it would probably be simpler but it would clutter up the history. I've already started cloning jdk20 anyway, n

Integrated: 8299194: CustomTzIDCheckDST.java may fail at future date

2022-12-22 Thread Ichiroh Takiguchi
On Wed, 21 Dec 2022 15:57:29 GMT, Ichiroh Takiguchi wrote: > test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java may fail at future date. > I used following standalone testcase > > import java.util.Calendar; > import java.util.Date; > import java.util.SimpleTimeZone; > > public class CheckDST

Withdrawn: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Stuart Marks
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote: > This test isn't part of any test group, so it isn't being run regularly! I'm > adding it to the jdk_util_other test group. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/117

Re: RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Stuart Marks
On Thu, 22 Dec 2022 19:37:12 GMT, Stuart Marks wrote: > This test isn't part of any test group, so it isn't being run regularly! I'm > adding it to the jdk_util_other test group. Closing this in favor of PR https://github.com/openjdk/jdk20/pull/73 on JDK 20. - PR: https://git.open

Re: [jdk20] RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Naoto Sato
On Thu, 22 Dec 2022 21:25:39 GMT, Stuart Marks wrote: > It was running as part of tier4 (which is kind of a catch-all tier) but since > it's (an internal) part of java.util, it should really be in tier1. This adds > the test/jdk/jdk/internal/util directory to the :jdk_util_other test group. Ma

[jdk20] RFR: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Stuart Marks
It was running as part of tier4 (which is kind of a catch-all tier) but since it's (an internal) part of java.util, it should really be in tier1. This adds the test/jdk/jdk/internal/util directory to the :jdk_util_other test group. - Commit messages: - 8299237: add ArraysSupport.ne

[jdk20] Integrated: 8299237: add ArraysSupport.newLength test to a test group

2022-12-22 Thread Stuart Marks
On Thu, 22 Dec 2022 21:25:39 GMT, Stuart Marks wrote: > It was running as part of tier4 (which is kind of a catch-all tier) but since > it's (an internal) part of java.util, it should really be in tier1. This adds > the test/jdk/jdk/internal/util directory to the :jdk_util_other test group. Th

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2022-12-22 Thread Sergey Bylokhov
On Thu, 22 Dec 2022 18:15:07 GMT, Harshitha Onkar wrote: >> ViewportOverlapping was failing intermittently on Windows (Win10 & 11). >> Added robot.setAutoWaitForIdle() to ViewportOverlapping and its base class >> (OverlappingTestBase) to stabilize the test. >> >> Additionally added awt & swing

Re: RFR: JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 [v2]

2022-12-22 Thread Alexey Ivanov
On Wed, 21 Dec 2022 21:48:24 GMT, Harshitha Onkar wrote: >> *Headful* tests are not supposed concurrently: they display UI and often use >> Robot to send input events to the UI. Running such tests concurrently leads >> to obscure failures. In our CI system, `JTREG_JOBS=1` is passed to `make` >