Re: RFR: JDK-8262994: Refactor String.split to help method inlining

2022-12-27 Thread Ismael Juma
On Tue, 27 Dec 2022 20:12:51 GMT, Christian Wimmer wrote: > The method `String.split` contains a fast-path when the regular expression > parameter is not really a regular expression, but just a single split > character. > This fast path vs. slow path check can be constant folded when the

RFR: JDK-8262994: Refactor String.split to help method inlining

2022-12-27 Thread Christian Wimmer
The method `String.split` contains a fast-path when the regular expression parameter is not really a regular expression, but just a single split character. This fast path vs. slow path check can be constant folded when the regular expression parameter is a literal constant - a quite frequent

Re: RFR: JDK-8299336 - InputStream::DEFAULT_BUFFER_SIZE should be 16384

2022-12-27 Thread Markus KARG
On Tue, 27 Dec 2022 14:55:31 GMT, Peter Levart wrote: > Hello Markus! Could you show the JMH code that produced the benchmark results? The following lines make use of a custom method I have added to `InputStream` in a custom build of JDK 21, so JMH can control the size of the buffer. The test

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v7]

2022-12-27 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods

Re: RFR: JDK-8299336 - InputStream::DEFAULT_BUFFER_SIZE should be 16384

2022-12-27 Thread Peter Levart
On Fri, 23 Dec 2022 22:28:34 GMT, Markus KARG wrote: > I/O had always been much slower than CPU and memory access, and thanks to > physical constraints, always will be. > While CPUs can get shrinked more and more, and can hold more and more memory > cache on or nearby a CPU core, the distance

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-12-27 Thread Michael Ernst
On Mon, 28 Nov 2022 09:00:09 GMT, Jaikiran Pai wrote: >> Could someone who knows the undocumented ins and outs of creating JDK pull >> requests could split this pull request up into multiple PRs? Then it can be >> merged, rather than wasting all the effort that went into it. > >> Could

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v3]

2022-12-27 Thread Michael Ernst
> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni Michael Ernst has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits: - Merge ../jdk-openjdk into typos-typos - Reinstate typos in Apache code