Integrated: 8300817: The build is broken after JDK-8294693

2023-01-21 Thread Sergey Bylokhov
On Sat, 21 Jan 2023 19:40:58 GMT, Sergey Bylokhov wrote: > The next warning is fixed: > > === Output from failing command(s) repeated here === > * For target jdk_modules_java.base__the.java.base_batch: This pull request has now been integrated. Changeset: 3ea4eac1 Author:Sergey Bylokhov

RFR: 8300818: Reduce complexity of padding with DateTimeFormatter

2023-01-21 Thread Sergey Tsypanov
Currently it's O(n) - we do `n` shifts of bytes within `StringBuilder`. This can be reduced to O(1) improving the code like: DateTimeFormatter dtf = new DateTimeFormatterBuilder() .appendLiteral("Date:") .padNext(20, ' ') .append(DateTimeFormatter.ISO_DATE) .toFormatter(); String text =

Re: RFR: 8300817: The build is broken after JDK-8294693

2023-01-21 Thread Joe Darcy
On Sat, 21 Jan 2023 19:40:58 GMT, Sergey Bylokhov wrote: > The next warning is fixed: > > === Output from failing command(s) repeated here === > * For target jdk_modules_java.base__the.java.base_batch: Thanks for the quick fix. - Marked as reviewed by darcy (Reviewer). PR:

Re: RFR: 8300817: The build is broken after JDK-8294693

2023-01-21 Thread Tagir F . Valeev
On Sat, 21 Jan 2023 19:40:58 GMT, Sergey Bylokhov wrote: > The next warning is fixed: > > === Output from failing command(s) repeated here === > * For target jdk_modules_java.base__the.java.base_batch: Marked as reviewed by tvaleev (Committer). - PR:

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v6]

2023-01-21 Thread Tagir F . Valeev
On Sat, 21 Jan 2023 19:38:16 GMT, Sergey Bylokhov wrote: >> Tagir F. Valeev has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Whitespaces fixed >> - @implSpec added to shuffle(List) > > Filed, will create a PR soon. >

RFR: 8300817: The build is broken after JDK-8294693

2023-01-21 Thread Sergey Bylokhov
The next warning is fixed: === Output from failing command(s) repeated here === * For target jdk_modules_java.base__the.java.base_batch: - Commit messages: - The build is broken after JDK-8294693 Changes: https://git.openjdk.org/jdk/pull/12129/files Webrev:

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v6]

2023-01-21 Thread Sergey Bylokhov
On Sat, 21 Jan 2023 18:31:28 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v4]

2023-01-21 Thread Sergey Bylokhov
On Wed, 18 Jan 2023 22:06:55 GMT, Tagir F. Valeev wrote: >> Tagir F. Valeev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Copyright year and @since tag updated >> - Fixes according to review >> >>

Integrated: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface

2023-01-21 Thread Tagir F . Valeev
On Sat, 1 Oct 2022 08:06:44 GMT, Tagir F. Valeev wrote: > Java 17 added RandomGenerator interface. However, existing method > Collections.shuffle accepts old java.util.Random class. While since Java 19, > it's possible to use Random.from(RandomGenerator) wrapper, it would be more > convenient

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v6]

2023-01-21 Thread Sergey Bylokhov
On Sat, 21 Jan 2023 18:31:28 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v6]

2023-01-21 Thread Joe Darcy
On Sat, 21 Jan 2023 18:31:28 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v5]

2023-01-21 Thread Tagir F . Valeev
On Sat, 21 Jan 2023 18:24:24 GMT, Tagir F. Valeev wrote: >> src/java.base/share/classes/java/util/Collections.java line 464: >> >>> 462: * position, inclusive. >>> 463: * >>> 464: * @implSpec This method runs in linear time. If the specified >>> list does >> >> Please also

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v6]

2023-01-21 Thread Tagir F . Valeev
> Java 17 added RandomGenerator interface. However, existing method > Collections.shuffle accepts old java.util.Random class. While since Java 19, > it's possible to use Random.from(RandomGenerator) wrapper, it would be more > convenient to provide direct overload shuffle(List list,

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v5]

2023-01-21 Thread Tagir F . Valeev
On Sat, 21 Jan 2023 18:02:38 GMT, Joe Darcy wrote: >> Tagir F. Valeev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> @implSpec added > > src/java.base/share/classes/java/util/Collections.java line 464: > >> 462: * position,

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v5]

2023-01-21 Thread Joe Darcy
On Sat, 21 Jan 2023 08:26:31 GMT, Tagir F. Valeev wrote: >> Java 17 added RandomGenerator interface. However, existing method >> Collections.shuffle accepts old java.util.Random class. While since Java 19, >> it's possible to use Random.from(RandomGenerator) wrapper, it would be more >>

Integrated: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder

2023-01-21 Thread Claes Redestad
On Wed, 18 Jan 2023 16:53:04 GMT, Claes Redestad wrote: > `ZipCoder::checkedHashCode` emulates `StringLatin1::hashCode` but operates on > a `byte[]` subrange. It can profitably use the recently introduced > `ArraysSupport::vectorizedHashCode` method to see a speed-up, which > translates to a

Re: RFR: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder [v2]

2023-01-21 Thread Claes Redestad
On Fri, 20 Jan 2023 16:42:47 GMT, Lance Andersen wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Vary dir and entry name lengths across a wider spread, keeping most >> entries short but making the longest paths

Re: RFR: 8300208: Optimize Adler32 stub for AVX-512 targets.

2023-01-21 Thread Andrey Turbanov
On Tue, 17 Jan 2023 17:24:20 GMT, Jatin Bhateja wrote: > Patch optimizes Adler32 stub for AVX512 target. > > Main computation loop now uses zero extended lane widening load vector > operation. > > New sequence also honors AVX3Thresholds so that implementation uses existing > AVX2 instruction

Re: RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v5]

2023-01-21 Thread Tagir F . Valeev
> Java 17 added RandomGenerator interface. However, existing method > Collections.shuffle accepts old java.util.Random class. While since Java 19, > it's possible to use Random.from(RandomGenerator) wrapper, it would be more > convenient to provide direct overload shuffle(List list,