On Mon, 23 Jan 2023 13:53:38 GMT, Per Minborg wrote:
> Some variables are declared using old-style declarations. These should be
> modified to conform to modern style.
>
> This is a task derived from https://github.com/openjdk/jdk/pull/11848
This pull request has now been integrated.
Changes
On Tue, 24 Jan 2023 05:54:44 GMT, Joe Darcy wrote:
>> Please review this simple update to the manpage to set the version to 21-ea.
>>
>> This change also corrects a typo in javac.1 that was manually introduced by
>> JDK-8300591
>>
>> Thanks.
>
> Marked as reviewed by darcy (Reviewer).
Thanks
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
This pull request has now been integrated.
Changeset:
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
Marked as reviewed by darcy (Reviewer).
-
On Tue, 24 Jan 2023 01:28:53 GMT, Iris Clark wrote:
>> Please review this simple update to the manpage to set the version to 21-ea.
>>
>> This change also corrects a typo in javac.1 that was manually introduced by
>> JDK-8300591
>>
>> Thanks.
>
> Marked as reviewed by iris (Reviewer).
Thanks
On Thu, 19 Jan 2023 22:25:51 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.CollationKey](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/CollationKey.html)
> and
> [java.text.CompactNumberFormat](https://do
On Fri, 20 Jan 2023 17:41:35 GMT, Justin Lu wrote:
> Some classes / interfaces in java.text have already implemented JEP 413.
>
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for the
> rest of
> [java.text](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/j
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
Marked as reviewed by iris (Reviewer).
-
On Mon, 23 Jan 2023 23:24:06 GMT, Lance Andersen wrote:
>> Please review this simple update to the manpage to set the version to 21-ea.
>>
>> This change also corrects a typo in javac.1 that was manually introduced by
>> JDK-8300591
>>
>> Thanks.
>
> Marked as reviewed by lancea (Reviewer).
T
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
Marked as reviewed by lancea (Reviewer).
Please review this simple update to the manpage to set the version to 21-ea.
This change also corrects a typo in javac.1 that was manually introduced by
JDK-8300591
Thanks.
-
Commit messages:
- 8290918: Initial nroff manpage generation for JDK 21
Changes: https://git.openjdk.org/
On Mon, 9 Jan 2023 20:04:34 GMT, Christian Wimmer wrote:
>> The method `String.split` contains a fast-path when the regular expression
>> parameter is not really a regular expression, but just a single split
>> character.
>> This fast path vs. slow path check can be constant folded when the reg
> This task is created to update the manual test groups.
Bill Huang has updated the pull request incrementally with one additional
commit since the last revision:
Added missing manual tests from :jdk_core.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10864/files
- new:
> Added code for Base64 acceleration (encode and decode) which will accelerate
> ~4x for AVX2 platforms.
>
> Encode performance:
> **Old:**
>
> Benchmark (maxNumBytes) Mode Cnt Score Error
> Units
> Base64Encode.testBase64Encode 1024 thrpt3 4309.4
On Mon, 9 Jan 2023 20:04:34 GMT, Christian Wimmer wrote:
>> The method `String.split` contains a fast-path when the regular expression
>> parameter is not really a regular expression, but just a single split
>> character.
>> This fast path vs. slow path check can be constant folded when the reg
> Added code for Base64 acceleration (encode and decode) which will accelerate
> ~4x for AVX2 platforms.
>
> Encode performance:
> **Old:**
>
> Benchmark (maxNumBytes) Mode Cnt Score Error
> Units
> Base64Encode.testBase64Encode 1024 thrpt3 4309.4
On Mon, 23 Jan 2023 19:52:49 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 20 -> JDK 21
This pull request has now been integrated.
Changeset: 56dc3b08
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/56dc3b08a62f651835c5bccca987d93ba2bb8961
Stats: 28 lines i
On Mon, 23 Jan 2023 18:14:16 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 2661:
>>
>>> 2659: __ vpbroadcastq(xmm4, Address(r13, 0), Assembler::AVX_256bit);
>>> 2660: __ vmovdqu(xmm11, Address(r13, 0x28));
>>> 2661: __ vpbroadcastb(xmm10, Address(r13,
Forwardport JDK 20 -> JDK 21
-
Commit messages:
- Merge
- 8290919: Update nroff pages in JDK 20 before RC
The webrevs contain the adjustments done while merging with regards to each
parent branch:
- master: https://webrevs.openjdk.org/?repo=jdk&pr=12150&range=00.0
- jdk20: https
On Mon, 23 Jan 2023 13:53:38 GMT, Per Minborg wrote:
> Some variables are declared using old-style declarations. These should be
> modified to conform to modern style.
>
> This is a task derived from https://github.com/openjdk/jdk/pull/11848
Something is causing high contention in the bot, it
On Sun, 22 Jan 2023 23:17:10 GMT, Ichiroh Takiguchi
wrote:
>> On jdk17, following testcase works fine on Linux platform.
>>
>> Testcase
>>
>> $ cat cstest1.java
>> import java.nio.charset.*;
>>
>> public class cstest1 {
>> public static void main(String[] args) throws Exception {
>> Cha
On Thu, 12 Jan 2023 22:31:24 GMT, Justin Lu wrote:
> This PR implements _JEP 413: Code Snippets in Java API Documentation_ for
> [java.text.ChoiceFormat](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/text/ChoiceFormat.html).
>
> Code examples using ... blocks are replaced
On Mon, 23 Jan 2023 14:40:50 GMT, Per Minborg wrote:
> This PR proposes declaring some internal classes in java.io as `final`,
> explicitly indicating that they are not intended for sub-classing.
>
> If you think declaring classes final is just "static noice", please see
> http://minborgsjava
> This PR proposes declaring some internal classes in java.io as `final`,
> explicitly indicating that they are not intended for sub-classing.
>
> If you think declaring classes final is just "static noice", please see
> http://minborgsjavapot.blogspot.com/2021/12/why-general-inheritance-is-fla
On Mon, 23 Jan 2023 11:58:58 GMT, Claes Redestad wrote:
>> Added code for Base64 acceleration (encode and decode) which will accelerate
>> ~4x for AVX2 platforms.
>>
>> Encode performance:
>> **Old:**
>>
>> Benchmark (maxNumBytes) Mode Cnt Score Error
>> Units
On Mon, 23 Jan 2023 18:06:26 GMT, Per Minborg wrote:
> It looks like CE is used in `UnixFileSystem` via the system property
> "sun.io.useCanonCaches" ?
It was disabled in JDK 12 and the general plan was to eventually remove it
eventually.
-
PR: https://git.openjdk.org/jdk/pull/12
On Mon, 23 Jan 2023 13:53:38 GMT, Per Minborg wrote:
> Some variables are declared using old-style declarations. These should be
> modified to conform to modern style.
>
> This is a task derived from https://github.com/openjdk/jdk/pull/11848
Marked as reviewed by iris (Reviewer).
---
On Mon, 23 Jan 2023 18:02:44 GMT, Alan Bateman wrote:
> Look okay. We should probably think about removing ExpiringCache as it hasn't
> been used for many releases.
It looks like CE is used in `UnixFileSystem` via the system property
"sun.io.useCanonCaches" ?
-
PR: https://git.op
On Thu, 19 Jan 2023 20:43:11 GMT, Mandy Chung wrote:
> `java/lang/invoke/VarHandles` tests run with C1, C2 and tiered compilations
> and the test cases are executed in the warm up loop with 2 iterations to
> verify C1, C2 intrinsics. Default Tier4CompileThreshold is 15000.
>
> This PR pro
On Mon, 23 Jan 2023 14:40:50 GMT, Per Minborg wrote:
> This PR proposes declaring some internal classes in java.io as `final`,
> explicitly indicating that they are not intended for sub-classing.
>
> If you think declaring classes final is just "static noice", please see
> http://minborgsjava
On Mon, 23 Jan 2023 14:24:16 GMT, Per Minborg wrote:
> Some of the fields in java.io can be declared as final.
src/java.base/share/classes/java/io/File.java line 155:
> 153: * The FileSystem object representing the platform's local file
> system.
> 154: */
> 155: private static f
On Mon, 23 Jan 2023 14:59:08 GMT, Per Minborg wrote:
> This PR fixes a couple of typos in the documentation.
This pull request has now been integrated.
Changeset: 4525aa31
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/4525aa318a1025e19d4ed9924ed25992be0075e9
Stats:
On Mon, 23 Jan 2023 15:08:47 GMT, Per Minborg wrote:
> This PR proposes to reduce the visibility for constructor and methods in
> `java.io.SerialCallbackContext`.
This pull request has now been integrated.
Changeset: a7f035db
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/comm
On Mon, 23 Jan 2023 14:24:16 GMT, Per Minborg wrote:
> Some of the fields in java.io can be declared as final.
This pull request has now been integrated.
Changeset: 079255e3
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/079255e312a60584d748babcd320eacec99c5a02
Stats:
On Mon, 23 Jan 2023 13:53:38 GMT, Per Minborg wrote:
> Some variables are declared using old-style declarations. These should be
> modified to conform to modern style.
>
> This is a task derived from https://github.com/openjdk/jdk/pull/11848
Nice cleanup.
-
Marked as reviewed by
On Sat, 21 Jan 2023 19:38:16 GMT, Sergey Bylokhov wrote:
>> Tagir F. Valeev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Whitespaces fixed
>> - @implSpec added to shuffle(List)
>
> Filed, will create a PR soon.
> https://bugs.openj
On Mon, 23 Jan 2023 14:59:08 GMT, Per Minborg wrote:
> This PR fixes a couple of typos in the documentation.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12142
On Mon, 23 Jan 2023 14:59:08 GMT, Per Minborg wrote:
> This PR fixes a couple of typos in the documentation.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12142
On Mon, 23 Jan 2023 14:24:16 GMT, Per Minborg wrote:
> Some of the fields in java.io can be declared as final.
The changes look reasonable to me
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12140
On Mon, 23 Jan 2023 14:24:16 GMT, Per Minborg wrote:
> Some of the fields in java.io can be declared as final.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12140
On Fri, 20 Jan 2023 17:45:46 GMT, Mandy Chung wrote:
>> `java/lang/invoke/VarHandles` tests run with C1, C2 and tiered compilations
>> and the test cases are executed in the warm up loop with 2 iterations to
>> verify C1, C2 intrinsics. Default Tier4CompileThreshold is 15000.
>>
>> This P
On Mon, 9 Jan 2023 20:04:34 GMT, Christian Wimmer wrote:
>> The method `String.split` contains a fast-path when the regular expression
>> parameter is not really a regular expression, but just a single split
>> character.
>> This fast path vs. slow path check can be constant folded when the reg
On Mon, 23 Jan 2023 13:53:38 GMT, Per Minborg wrote:
> Some variables are declared using old-style declarations. These should be
> modified to conform to modern style.
>
> This is a task derived from https://github.com/openjdk/jdk/pull/11848
Marked as reviewed by rriggs (Reviewer).
-
On Mon, 23 Jan 2023 14:59:08 GMT, Per Minborg wrote:
> This PR fixes a couple of typos in the documentation.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12142
On Mon, 23 Jan 2023 13:53:38 GMT, Per Minborg wrote:
> Some variables are declared using old-style declarations. These should be
> modified to conform to modern style.
>
> This is a task derived from https://github.com/openjdk/jdk/pull/11848
Marked as reviewed by alanb (Reviewer).
--
On Mon, 23 Jan 2023 15:36:01 GMT, Per Minborg wrote:
>> This PR proposes to reduce the visibility for constructor and methods in
>> `java.io.SerialCallbackContext`.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update cop
> This PR proposes to reduce the visibility for constructor and methods in
> `java.io.SerialCallbackContext`.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.
This PR proposes to reduce the visibility for constructor and methods in
`java.io.SerialCallbackContext`.
-
Commit messages:
- Reduce visibility in j.i.SerialCallbackConext
Changes: https://git.openjdk.org/jdk/pull/12143/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12143
This PR fixes a couple of typos in the documentation.
-
Commit messages:
- Update copyright year
- Fix javadoc issues
Changes: https://git.openjdk.org/jdk/pull/12142/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12142&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
This PR proposes declaring some internal classes in java.io as `final`,
explicitly indicating that they are not intended for sub-classing.
If you think declaring classes final is just "static noice", please see
http://minborgsjavapot.blogspot.com/2021/12/why-general-inheritance-is-flawed-and.ht
Some of the fields in java.io can be declared as final.
-
Commit messages:
- Revert final class declaration
- Declare fields final
Changes: https://git.openjdk.org/jdk/pull/12140/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12140&range=00
Issue: https://bugs.openjdk.or
Some variables are declared using old-style declarations. These should be
modified to conform to modern style.
This is a task derived from https://github.com/openjdk/jdk/pull/11848
-
Commit messages:
- Fix more classes
- Remove c-style declarations
Changes: https://git.openjdk.o
On Sat, 21 Jan 2023 00:15:10 GMT, Scott Gibbons wrote:
> Added code for Base64 acceleration (encode and decode) which will accelerate
> ~4x for AVX2 platforms.
>
> Encode performance:
> **Old:**
>
> Benchmark (maxNumBytes) Mode Cnt Score Error
> Units
> Base64E
On Mon, 23 Jan 2023 09:44:48 GMT, Ichiroh Takiguchi
wrote:
> Java8 works `-Dfile.encoding=Cp943C` option on Linux. Since many users are
> migrating from Java8, I'm getting similar requests from my clients. Cp943C is
> not supported by Linux natively, but some clients want to use same encoding
On Mon, 28 Nov 2022 03:23:01 GMT, Justin King wrote:
> Fix memory leaks by making `AddOption` unconditionally duplicate passed in
> strings, taking ownership. Callers using dynamic memory free their storage
> after calling `AddOption`. This ensures no memory is dropped on the floor.
> This als
On Wed, 4 Jan 2023 15:37:23 GMT, Per Minborg wrote:
> Code in java.io contains many legacy constructs and semantics not recommended
> including:
>
> * C-style array declaration
> * Unnecessary visibility
> * Redundant keywords in interfaces (e.g. public, static)
> * Non-standard naming for
On Wed, 11 Jan 2023 15:31:22 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard nam
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove methods with implicit zero offset
On Sun, 22 Jan 2023 13:28:06 GMT, Sergey Tsypanov wrote:
>> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
>> line 2611:
>>
>>> 2609: "Cannot print as output of " + len + " characters
>>> exceeds pad width of " + padWidth);
>>> 2610:
On Mon, 23 Jan 2023 10:15:55 GMT, Per Minborg wrote:
>> Very good question. I will take a look at it. A fixed value is inserted in
>> the original var handle so potentially it might improve performance that way
>> too.
>
> No significant performance increase:
>
>
> 2-parameters
> Benchmark
On Mon, 23 Jan 2023 08:11:15 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java
>> line 614:
>>
>>> 612: /*
>>> 613: * Methods for packing primitive values into byte arrays starting
>>> at offset zero.
>>> 614: */
>>
>> Is the on
On Mon, 23 Jan 2023 07:48:41 GMT, Alan Bateman wrote:
>> Ichiroh Takiguchi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8300819: -Dfile.encoding=Cp943C option does not work as expected since
>> jdk18
>
> I'm trying to understand what
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Add benchmark
-
Changes:
- all: ht
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rename and move
-
Changes:
- all:
> This PR proposes using a performance optimization using a new supported API
> for operations similar to those found in `java.io.Bits`
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Improve doc and fix typo
-
Changes:
On Fri, 20 Jan 2023 18:21:59 GMT, Roger Riggs wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve doc and fix typo
>
> src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java
> line 614:
>
>>
On Mon, 23 Jan 2023 02:59:42 GMT, David Holmes wrote:
> There was one missing update in javac.1 from:
>
> [JDK-8245246](https://bugs.openjdk.org/browse/JDK-8245246): Deprecate
> -profile option in javac
>
> otherwise the change is limited to dropping the "-ea".
>
> Thanks.
This pull request
On Mon, 23 Jan 2023 07:56:08 GMT, Per Minborg wrote:
>> src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java
>> line 26:
>>
>>> 24: */
>>> 25:
>>> 26: package jdk.internal.util.access;
>>
>> This is pretty deep; I'd drop the final "access". The package name
>> `jdk.inte
On Fri, 20 Jan 2023 16:36:23 GMT, Roger Riggs wrote:
>> This PR proposes using a performance optimization using a new supported API
>> for operations similar to those found in `java.io.Bits`
>
> src/java.base/share/classes/jdk/internal/util/access/ByteArrayAccess.java
> line 26:
>
>> 24: */
>
69 matches
Mail list logo
